[INFO] fetching crate j4rs 0.20.0... [INFO] checking j4rs-0.20.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate j4rs 0.20.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate j4rs 0.20.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate j4rs 0.20.0 [INFO] finished tweaking crates.io crate j4rs 0.20.0 [INFO] tweaked toml for crates.io crate j4rs 0.20.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 142 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding async-channel v1.9.0 (available: v2.3.1) [INFO] [stderr] Adding event-listener v2.5.3 (available: v5.3.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e72f07499af8b5eb6dfb0948c2dec4fb0c3e9d8ced4621f64ff7dab26de607b7 [INFO] running `Command { std: "docker" "start" "-a" "e72f07499af8b5eb6dfb0948c2dec4fb0c3e9d8ced4621f64ff7dab26de607b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e72f07499af8b5eb6dfb0948c2dec4fb0c3e9d8ced4621f64ff7dab26de607b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e72f07499af8b5eb6dfb0948c2dec4fb0c3e9d8ced4621f64ff7dab26de607b7", kill_on_drop: false }` [INFO] [stdout] e72f07499af8b5eb6dfb0948c2dec4fb0c3e9d8ced4621f64ff7dab26de607b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8688655fb5e76cada710e2eed9c917e8a70b9fa75a2228176ad9a920c534401b [INFO] running `Command { std: "docker" "start" "-a" "8688655fb5e76cada710e2eed9c917e8a70b9fa75a2228176ad9a920c534401b", kill_on_drop: false }` [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking clap_builder v4.5.18 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking java-locator v0.1.7 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling j4rs v0.20.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Compiling jni-sys-macros v0.1.0 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking jni-sys v0.4.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/instance.rs:179:60 [INFO] [stdout] | [INFO] [stdout] 178 | impl<'a> ChainableInstance<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 179 | pub(crate) fn new(instance: Instance, jvm: &'a Jvm) -> ChainableInstance { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1719:83 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1719 | pub fn classpath_entry(&'a mut self, cp_entry: ClasspathEntry<'a>) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1728:18 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1728 | ) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1736:64 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1736 | pub fn java_opt(&'a mut self, opt: JavaOpt<'a>) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1742:71 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1742 | pub fn java_opts(&'a mut self, opts: Vec>) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1751:64 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1751 | pub fn with_no_implicit_classpath(&'a mut self) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1761:88 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1761 | pub fn detach_thread_on_drop(&'a mut self, detach_thread_on_drop: bool) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1770:74 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1770 | pub fn with_native_lib_name(&'a mut self, lib_name: &str) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1777:61 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1777 | pub fn skip_setting_native_lib(&'a mut self) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1784:69 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1784 | pub fn with_base_path(&'a mut self, base_path: &str) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1790:88 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1790 | pub fn with_maven_settings(&'a mut self, maven_settings: MavenSettings) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1796:57 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1796 | pub fn with_javafx_support(&'a mut self) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/api/mod.rs:1822:62 [INFO] [stdout] | [INFO] [stdout] 1701 | impl<'a> JvmBuilder<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 1822 | pub fn with_default_classloader(&'a mut self) -> &'a mut JvmBuilder { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/mod.rs:755:13 [INFO] [stdout] | [INFO] [stdout] 739 | let mut inv_args = inv_args; [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 755 | inv_args?.as_ref(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stdout] error: this value of type `std::result::Result<(), std::sync::mpsc::SendError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 90 | let mut jvm = Jvm::attach_thread() [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let instance_res = Instance::from_jobject_with_global_ref(java_instance); [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let result = tx.send(instance); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 118 | let mut jvm = Jvm::attach_thread().expect( [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let instance_res = Instance::from_jobject_with_global_ref(java_instance); [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let tx = unsafe { Box::from_raw(p) }; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 143 | let mut jvm = Jvm::attach_thread().expect( [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let tx = unsafe { Box::from_raw(p) }; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking async-std v1.13.0 [INFO] [stdout] error: aborting due to 4 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `j4rs` (lib) due to 5 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8688655fb5e76cada710e2eed9c917e8a70b9fa75a2228176ad9a920c534401b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8688655fb5e76cada710e2eed9c917e8a70b9fa75a2228176ad9a920c534401b", kill_on_drop: false }` [INFO] [stdout] 8688655fb5e76cada710e2eed9c917e8a70b9fa75a2228176ad9a920c534401b