[INFO] fetching crate itertools 0.13.0... [INFO] checking itertools-0.13.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate itertools 0.13.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate itertools 0.13.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate itertools 0.13.0 [INFO] finished tweaking crates.io crate itertools 0.13.0 [INFO] tweaked toml for crates.io crate itertools 0.13.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate itertools 0.13.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `quickcheck` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9270a8c733bf901907da96e924d42835c1db387aba0311db74527eb6fb2b7fe2 [INFO] running `Command { std: "docker" "start" "-a" "9270a8c733bf901907da96e924d42835c1db387aba0311db74527eb6fb2b7fe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9270a8c733bf901907da96e924d42835c1db387aba0311db74527eb6fb2b7fe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9270a8c733bf901907da96e924d42835c1db387aba0311db74527eb6fb2b7fe2", kill_on_drop: false }` [INFO] [stdout] 9270a8c733bf901907da96e924d42835c1db387aba0311db74527eb6fb2b7fe2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6ac8a6631da4c89792b59389d58c710c348a941d403b7062f78e3e31ddfa2f0f [INFO] running `Command { std: "docker" "start" "-a" "6ac8a6631da4c89792b59389d58c710c348a941d403b7062f78e3e31ddfa2f0f", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `quickcheck` dependency) [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking permutohedron v0.2.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking itertools v0.13.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling syn v2.0.63 [INFO] [stdout] error: this value of type `Option<::Item>>::CItem>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adaptors/coalesce.rs:91:29 [INFO] [stdout] | [INFO] [stdout] 82 | fn fold(self, acc: Acc, mut fn_acc: FnAcc) -> Acc [INFO] [stdout] | ---- ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | mut iter, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | last, [INFO] [stdout] 89 | mut f, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | } = self; [INFO] [stdout] 91 | if let Some(last) = last.unwrap_or_else(|| iter.next().map(C::new)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<::Item>>::CItem, (::Item>>::CItem, ::Item>>::CItem)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adaptors/coalesce.rs:93:23 [INFO] [stdout] | [INFO] [stdout] 92 | let (last, acc) = iter.fold((last, acc), |(last, acc), elt| { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | match f.coalesce_pair(last, elt) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adaptors/mod.rs:542:15 [INFO] [stdout] | [INFO] [stdout] 541 | let old = self.iter.clone(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 542 | match self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extrema_set.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 7 | mut it: I, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | mut key_for: F, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | mut compare: Compare, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | match it.next() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grouping_map.rs:118:35 [INFO] [stdout] | [INFO] [stdout] 116 | self.iter.for_each(|(key, val)| { [INFO] [stdout] | ---------- [INFO] [stdout] | || [INFO] [stdout] | |these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | let acc = destination_map.remove(&key); [INFO] [stdout] 118 | if let Some(op_res) = operation(acc, &key, val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peek_nth.rs:122:15 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn next_if(&mut self, func: impl FnOnce(&I::Item) -> bool) -> Option { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | match self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peeking_take_while.rs:62:26 [INFO] [stdout] | [INFO] [stdout] 58 | fn peeking_next(&mut self, accept: F) -> Option [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | if let Some(r) = self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peeking_take_while.rs:83:26 [INFO] [stdout] | [INFO] [stdout] 79 | fn peeking_next(&mut self, accept: F) -> Option [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | if let Some(r) = self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tee.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 58 | let mut buffer = self.rcbuffer.borrow_mut(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | match buffer.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1953:15 [INFO] [stdout] | [INFO] [stdout] 1948 | fn collect_tuple(mut self) -> Option [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1953 | match self.next_tuple() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<::Item, Option<::Item>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2609:15 [INFO] [stdout] | [INFO] [stdout] 2552 | fn tree_reduce(mut self, mut f: F) -> Option [INFO] [stdout] | -------- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2609 | match inner(usize::MAX, &mut self, &mut f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MinMaxResult<(usize, ::Item)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:3982:15 [INFO] [stdout] | [INFO] [stdout] 3975 | fn position_minmax_by_key(self, mut key: F) -> MinMaxResult [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3982 | match self.enumerate().minmax_by_key(|e| key(&e.1)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MinMaxResult<(usize, ::Item)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:4026:15 [INFO] [stdout] | [INFO] [stdout] 4020 | fn position_minmax_by(self, mut compare: F) -> MinMaxResult [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4026 | match self.enumerate().minmax_by(|x, y| compare(&x.1, &y.1)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:4054:15 [INFO] [stdout] | [INFO] [stdout] 4050 | fn exactly_one(mut self) -> Result> [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4054 | match self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:4087:15 [INFO] [stdout] | [INFO] [stdout] 4083 | fn at_most_one(mut self) -> Result, ExactlyOneError> [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4087 | match self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option<::Item>, Option<::Item>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:4282:15 [INFO] [stdout] | [INFO] [stdout] 4278 | let mut ia = a.into_iter(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 4279 | let mut ib = b.into_iter(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4282 | match (ia.next(), ib.next()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `itertools` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6ac8a6631da4c89792b59389d58c710c348a941d403b7062f78e3e31ddfa2f0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ac8a6631da4c89792b59389d58c710c348a941d403b7062f78e3e31ddfa2f0f", kill_on_drop: false }` [INFO] [stdout] 6ac8a6631da4c89792b59389d58c710c348a941d403b7062f78e3e31ddfa2f0f