[INFO] fetching crate index_datamanip 0.5.2... [INFO] checking index_datamanip-0.5.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate index_datamanip 0.5.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate index_datamanip 0.5.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate index_datamanip 0.5.2 [INFO] finished tweaking crates.io crate index_datamanip 0.5.2 [INFO] tweaked toml for crates.io crate index_datamanip 0.5.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (available: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding lexical-core v0.7.6 (available: v1.0.2) [INFO] [stderr] Adding libflate v0.1.27 (available: v2.1.0) [INFO] [stderr] Adding nom v5.1.3 (available: v7.1.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 72be478f1c29a955d206974356890692c0c33ab87b25f9f079d6ae80793de071 [INFO] running `Command { std: "docker" "start" "-a" "72be478f1c29a955d206974356890692c0c33ab87b25f9f079d6ae80793de071", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "72be478f1c29a955d206974356890692c0c33ab87b25f9f079d6ae80793de071", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72be478f1c29a955d206974356890692c0c33ab87b25f9f079d6ae80793de071", kill_on_drop: false }` [INFO] [stdout] 72be478f1c29a955d206974356890692c0c33ab87b25f9f079d6ae80793de071 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 235bffc5201f4885eb2f3215916e1e3fe25ab88722d1f022695234d01363df8e [INFO] running `Command { std: "docker" "start" "-a" "235bffc5201f4885eb2f3215916e1e3fe25ab88722d1f022695234d01363df8e", kill_on_drop: false }` [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking libflate v0.1.27 [INFO] [stderr] Checking index_datamanip v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parse7.rs:208:27 [INFO] [stdout] | [INFO] [stdout] 208 | fn deserialize_seq(mut self, visitor: V) -> Result [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `help_index` and `attributes` are never read [INFO] [stdout] --> src/parse_messages.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 49 | struct StashItem { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 52 | help_index: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 53 | attributes: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StashItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `creator_version`, `required_read_version`, `archive_header_size`, and `file_header_size` are never read [INFO] [stdout] --> src/pigg.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 92 | struct Header { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 93 | creator_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 94 | required_read_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 95 | archive_header_size: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 96 | file_header_size: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name_id`, `size`, `timestamp`, `reserved`, `header_data_id`, and `checksum` are never read [INFO] [stdout] --> src/pigg.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 127 | struct FileHeader { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 128 | name_id: i32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 129 | size: u32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 130 | timestamp: u32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 131 | offset: u32, [INFO] [stdout] 132 | reserved: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 133 | header_data_id: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 134 | checksum: u128, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parse7.rs:208:27 [INFO] [stdout] | [INFO] [stdout] 208 | fn deserialize_seq(mut self, visitor: V) -> Result [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/parse7.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 299 | / fn deserialize_enum( [INFO] [stdout] 300 | | self, [INFO] [stdout] 301 | | _name: &'static str, [INFO] [stdout] 302 | | _variants: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 305 | | where [INFO] [stdout] 306 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] 307 | { [INFO] [stdout] 308 | impl<'de, 'a> serde::de::EnumAccess<'de> for &'a mut Deserializer<'de> { [INFO] [stdout] | ^^^^^^^^^^^^^^---------------------^^^^^^^^^^^^^^^^^^------------^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `EnumAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `help_index` and `attributes` are never read [INFO] [stdout] --> src/parse_messages.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 49 | struct StashItem { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 52 | help_index: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 53 | attributes: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StashItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `creator_version`, `required_read_version`, `archive_header_size`, and `file_header_size` are never read [INFO] [stdout] --> src/pigg.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 92 | struct Header { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 93 | creator_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 94 | required_read_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 95 | archive_header_size: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 96 | file_header_size: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name_id`, `size`, `timestamp`, `reserved`, `header_data_id`, and `checksum` are never read [INFO] [stdout] --> src/pigg.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 127 | struct FileHeader { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 128 | name_id: i32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 129 | size: u32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 130 | timestamp: u32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 131 | offset: u32, [INFO] [stdout] 132 | reserved: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 133 | header_data_id: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 134 | checksum: u128, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/parse7.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 299 | / fn deserialize_enum( [INFO] [stdout] 300 | | self, [INFO] [stdout] 301 | | _name: &'static str, [INFO] [stdout] 302 | | _variants: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 305 | | where [INFO] [stdout] 306 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] 307 | { [INFO] [stdout] 308 | impl<'de, 'a> serde::de::EnumAccess<'de> for &'a mut Deserializer<'de> { [INFO] [stdout] | ^^^^^^^^^^^^^^---------------------^^^^^^^^^^^^^^^^^^------------^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `EnumAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.44s [INFO] running `Command { std: "docker" "inspect" "235bffc5201f4885eb2f3215916e1e3fe25ab88722d1f022695234d01363df8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "235bffc5201f4885eb2f3215916e1e3fe25ab88722d1f022695234d01363df8e", kill_on_drop: false }` [INFO] [stdout] 235bffc5201f4885eb2f3215916e1e3fe25ab88722d1f022695234d01363df8e