[INFO] fetching crate hydra-websockets 0.1.30... [INFO] checking hydra-websockets-0.1.30 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate hydra-websockets 0.1.30 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate hydra-websockets 0.1.30 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hydra-websockets 0.1.30 [INFO] finished tweaking crates.io crate hydra-websockets 0.1.30 [INFO] tweaked toml for crates.io crate hydra-websockets 0.1.30 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate hydra-websockets 0.1.30 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc748448a09037fc031e749cf548d76e8e700f629166ea83ea41ba28bddd938f [INFO] running `Command { std: "docker" "start" "-a" "dc748448a09037fc031e749cf548d76e8e700f629166ea83ea41ba28bddd938f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc748448a09037fc031e749cf548d76e8e700f629166ea83ea41ba28bddd938f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc748448a09037fc031e749cf548d76e8e700f629166ea83ea41ba28bddd938f", kill_on_drop: false }` [INFO] [stdout] dc748448a09037fc031e749cf548d76e8e700f629166ea83ea41ba28bddd938f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01fb33af0ff1e17b3d97a0ad040e1412d4077d579f621d62b130dd66285fd0f6 [INFO] running `Command { std: "docker" "start" "-a" "01fb33af0ff1e17b3d97a0ad040e1412d4077d579f621d62b130dd66285fd0f6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling virtue v0.0.13 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling bincode_derive v2.0.0-rc.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking bincode v2.0.0-rc.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking tungstenite v0.23.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking tokio-tungstenite v0.23.0 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking pingora-timeout v0.2.0 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking hydra v0.1.30 [INFO] [stderr] Checking hydra-websockets v0.1.30 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket_handler.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 135 | pub(crate) async fn start_websocket_handler(mut handler: T, mut stream: WebSocketStream) [INFO] [stdout] | ----------- ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | / tokio::select! { [INFO] [stdout] 153 | | message = Process::receive::() => { [INFO] [stdout] 154 | | match handler.websocket_info(message).await { [INFO] [stdout] 155 | | Ok(commands) => { [INFO] [stdout] ... | [INFO] [stdout] 167 | | ws_message = stream.next() => { [INFO] [stdout] | | ^^^^^^^^^^ [INFO] [stdout] ... | [INFO] [stdout] 217 | | } [INFO] [stdout] 218 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket_handler.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 135 | pub(crate) async fn start_websocket_handler(mut handler: T, mut stream: WebSocketStream) [INFO] [stdout] | ----------- ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | / tokio::select! { [INFO] [stdout] 153 | | message = Process::receive::() => { [INFO] [stdout] 154 | | match handler.websocket_info(message).await { [INFO] [stdout] 155 | | Ok(commands) => { [INFO] [stdout] ... | [INFO] [stdout] 167 | | ws_message = stream.next() => { [INFO] [stdout] | | ^^^^^^^^^^ [INFO] [stdout] ... | [INFO] [stdout] 217 | | } [INFO] [stdout] 218 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hydra-websockets` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hydra-websockets` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "01fb33af0ff1e17b3d97a0ad040e1412d4077d579f621d62b130dd66285fd0f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01fb33af0ff1e17b3d97a0ad040e1412d4077d579f621d62b130dd66285fd0f6", kill_on_drop: false }` [INFO] [stdout] 01fb33af0ff1e17b3d97a0ad040e1412d4077d579f621d62b130dd66285fd0f6