[INFO] fetching crate holochain_tracing 0.0.24... [INFO] checking holochain_tracing-0.0.24 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate holochain_tracing 0.0.24 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate holochain_tracing 0.0.24 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate holochain_tracing 0.0.24 [INFO] finished tweaking crates.io crate holochain_tracing 0.0.24 [INFO] tweaked toml for crates.io crate holochain_tracing 0.0.24 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate holochain_tracing 0.0.24 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0f452951160a7b04862ebfb045de5ec622f8aaf9bd0615ce51c9d7672bd652d6 [INFO] running `Command { std: "docker" "start" "-a" "0f452951160a7b04862ebfb045de5ec622f8aaf9bd0615ce51c9d7672bd652d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0f452951160a7b04862ebfb045de5ec622f8aaf9bd0615ce51c9d7672bd652d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f452951160a7b04862ebfb045de5ec622f8aaf9bd0615ce51c9d7672bd652d6", kill_on_drop: false }` [INFO] [stdout] 0f452951160a7b04862ebfb045de5ec622f8aaf9bd0615ce51c9d7672bd652d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 02bf37a013777c09ab7e2fc9fc5be3f88d378838ebb163b938b6658f3b6ae0d2 [INFO] running `Command { std: "docker" "start" "-a" "02bf37a013777c09ab7e2fc9fc5be3f88d378838ebb163b938b6658f3b6ae0d2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.16 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling cc v1.0.46 [INFO] [stderr] Compiling protobuf v2.10.2 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking tracing-core v0.1.10 [INFO] [stderr] Compiling prometheus v0.7.0 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking regex-syntax v0.6.16 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking crossbeam-channel v0.3.8 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking integer-encoding v1.1.4 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling either v1.5.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling itertools v0.8.2 [INFO] [stderr] Checking tracing-log v0.1.1 [INFO] [stderr] Checking hostname v0.1.5 [INFO] [stderr] Checking sharded-slab v0.0.8 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking smallvec v1.2.0 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking thrift v0.13.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking backtrace v0.3.40 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking gag v0.1.10 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Compiling trackable_derive v0.1.2 [INFO] [stderr] Checking trackable v0.2.23 [INFO] [stderr] Checking thrift_codec v0.1.1 [INFO] [stderr] Checking rustracing v0.2.1 [INFO] [stderr] Checking rustracing_jaeger v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling pin-project-internal v0.4.8 [INFO] [stderr] Compiling tracing-attributes v0.1.7 [INFO] [stderr] Compiling shrinkwraprs v0.3.0 [INFO] [stderr] Checking tracing v0.1.13 [INFO] [stderr] Checking pin-project v0.4.8 [INFO] [stderr] Checking bincode v1.2.1 [INFO] [stderr] Checking tracing-serde v0.1.1 [INFO] [stderr] Checking serde_json v1.0.47 [INFO] [stderr] Checking opentelemetry v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.2.3 [INFO] [stderr] Checking opentelemetry-jaeger v0.1.0 [INFO] [stderr] Checking holochain_tracing v0.0.24 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result<(), crossbeam_channel::SendError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 53 | tx: SpanSender, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | match tx.send_wrapped(val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/span_context.rs:15:10 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Deserialize, Serialize, Clone, Debug)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_EncodedSpanContext` [INFO] [stdout] 16 | pub struct EncodedSpanContext(pub Vec); [INFO] [stdout] | ------------------ `EncodedSpanContext` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/span_context.rs:15:23 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Deserialize, Serialize, Clone, Debug)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_EncodedSpanContext` [INFO] [stdout] 16 | pub struct EncodedSpanContext(pub Vec); [INFO] [stdout] | ------------------ `EncodedSpanContext` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/span_wrap.rs:90:10 [INFO] [stdout] | [INFO] [stdout] 90 | #[derive(Serialize, Deserialize, Clone)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_EncodedSpanWrap` [INFO] [stdout] 91 | pub struct EncodedSpanWrap [INFO] [stdout] | --------------- `EncodedSpanWrap` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/span_wrap.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 90 | #[derive(Serialize, Deserialize, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_EncodedSpanWrap` [INFO] [stdout] 91 | pub struct EncodedSpanWrap [INFO] [stdout] | --------------- `EncodedSpanWrap` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/stack.rs:106:31 [INFO] [stdout] | [INFO] [stdout] 106 | Mode::Panic => panic!(msg), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 106 | Mode::Panic => panic!("{}", msg), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `holochain_tracing` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result<(), crossbeam_channel::SendError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 53 | tx: SpanSender, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | match tx.send_wrapped(val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/span_context.rs:15:10 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Deserialize, Serialize, Clone, Debug)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_EncodedSpanContext` [INFO] [stdout] 16 | pub struct EncodedSpanContext(pub Vec); [INFO] [stdout] | ------------------ `EncodedSpanContext` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/span_context.rs:15:23 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Deserialize, Serialize, Clone, Debug)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_EncodedSpanContext` [INFO] [stdout] 16 | pub struct EncodedSpanContext(pub Vec); [INFO] [stdout] | ------------------ `EncodedSpanContext` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/span_wrap.rs:90:10 [INFO] [stdout] | [INFO] [stdout] 90 | #[derive(Serialize, Deserialize, Clone)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_EncodedSpanWrap` [INFO] [stdout] 91 | pub struct EncodedSpanWrap [INFO] [stdout] | --------------- `EncodedSpanWrap` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/span_wrap.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 90 | #[derive(Serialize, Deserialize, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_EncodedSpanWrap` [INFO] [stdout] 91 | pub struct EncodedSpanWrap [INFO] [stdout] | --------------- `EncodedSpanWrap` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/stack.rs:106:31 [INFO] [stdout] | [INFO] [stdout] 106 | Mode::Panic => panic!(msg), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 106 | Mode::Panic => panic!("{}", msg), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `holochain_tracing` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "02bf37a013777c09ab7e2fc9fc5be3f88d378838ebb163b938b6658f3b6ae0d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "02bf37a013777c09ab7e2fc9fc5be3f88d378838ebb163b938b6658f3b6ae0d2", kill_on_drop: false }` [INFO] [stdout] 02bf37a013777c09ab7e2fc9fc5be3f88d378838ebb163b938b6658f3b6ae0d2