[INFO] fetching crate h3arrow 0.4.0... [INFO] checking h3arrow-0.4.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate h3arrow 0.4.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate h3arrow 0.4.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate h3arrow 0.4.0 [INFO] finished tweaking crates.io crate h3arrow 0.4.0 [INFO] tweaked toml for crates.io crate h3arrow 0.4.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 156 packages to latest compatible versions [INFO] [stderr] Adding arrow v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-arith v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-array v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-buffer v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-cast v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-csv v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-data v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-ipc v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-json v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-ord v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-row v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-schema v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-select v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-string v50.0.0 (available: v53.0.0) [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding flatbuffers v23.5.26 (available: v24.3.25) [INFO] [stderr] Adding geo v0.27.0 (available: v0.28.0) [INFO] [stderr] Adding geoarrow v0.1.0 (available: v0.3.0) [INFO] [stderr] Adding geozero v0.11.0 (available: v0.14.0) [INFO] [stderr] Adding geozero v0.12.0 (available: v0.14.0) [INFO] [stderr] Adding hash32 v0.2.1 (available: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (available: v0.8.0) [INFO] [stderr] Adding itertools v0.11.0 (available: v0.13.0) [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding lexical-core v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-integer v0.8.6 (available: v1.0.2) [INFO] [stderr] Adding lexical-util v0.8.5 (available: v1.0.3) [INFO] [stderr] Adding lexical-write-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-write-integer v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding rstar v0.11.0 (available: v0.12.0) [INFO] [stderr] Adding scroll v0.11.0 (available: v0.12.0) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding wkt v0.10.3 (available: v0.11.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 66cda7e8fd752e4fc2d30dbf8b61166878107be959b3b8a0cea49a3ce11c4924 [INFO] running `Command { std: "docker" "start" "-a" "66cda7e8fd752e4fc2d30dbf8b61166878107be959b3b8a0cea49a3ce11c4924", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "66cda7e8fd752e4fc2d30dbf8b61166878107be959b3b8a0cea49a3ce11c4924", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66cda7e8fd752e4fc2d30dbf8b61166878107be959b3b8a0cea49a3ce11c4924", kill_on_drop: false }` [INFO] [stdout] 66cda7e8fd752e4fc2d30dbf8b61166878107be959b3b8a0cea49a3ce11c4924 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] deec065b2b886b490c30e7c661aa272a4d92c72c034cb7731416033813bfc274 [INFO] running `Command { std: "docker" "start" "-a" "deec065b2b886b490c30e7c661aa272a4d92c72c034cb7731416033813bfc274", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking arrow-schema v50.0.0 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Compiling flatbuffers v23.5.26 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking geographiclib-rs v0.2.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rstar v0.12.0 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking earcutr v0.4.3 [INFO] [stderr] Checking spade v2.12.1 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking float_next_after v1.0.0 [INFO] [stderr] Checking h3o-bit v0.1.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking float_eq v1.0.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v50.0.0 [INFO] [stderr] Checking arrow-data v50.0.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking arrow-array v50.0.0 [INFO] [stderr] Checking arrow-select v50.0.0 [INFO] [stderr] Checking arrow-row v50.0.0 [INFO] [stderr] Checking arrow-arith v50.0.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking geo-types v0.7.13 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking arrow-cast v50.0.0 [INFO] [stderr] Checking arrow-string v50.0.0 [INFO] [stderr] Checking arrow-ord v50.0.0 [INFO] [stderr] Checking geo v0.28.0 [INFO] [stderr] Checking geojson v0.24.1 [INFO] [stderr] Checking arrow-json v50.0.0 [INFO] [stderr] Checking arrow-ipc v50.0.0 [INFO] [stderr] Checking arrow-csv v50.0.0 [INFO] [stderr] Checking arrow v50.0.0 [INFO] [stderr] Checking h3o v0.6.4 [INFO] [stderr] Checking h3arrow v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Flatten>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/cell.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 94 | let arr: CellIndexArray = vec![ [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let children = arr.children(Resolution::Six).unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | assert_eq!(children.len(), 2); [INFO] [stdout] 102 | let cellarray = children.iter_arrays().next().flatten().unwrap().unwrap(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | for child in cellarray.iter().flatten() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator> + '_` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/from_geo.rs:344:18 [INFO] [stdout] | [INFO] [stdout] 339 | let cells = rect.as_slice().to_cellindexarray(&options).unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | assert!(cells.len() > 400); [INFO] [stdout] 341 | let resolution = cells.resolution(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | for r in resolution.iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `cell_vecs_to_h3listarray` is never used [INFO] [stdout] --> src/array/from_geo.rs:221:15 [INFO] [stdout] | [INFO] [stdout] 221 | pub(crate) fn cell_vecs_to_h3listarray( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_with_validity` is never used [INFO] [stdout] --> src/array/validity.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait FromWithValidity { [INFO] [stdout] | ---------------- associated function in this trait [INFO] [stdout] 6 | fn from_with_validity(value: T) -> Self; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `cell_vecs_to_h3listarray` is never used [INFO] [stdout] --> src/array/from_geo.rs:221:15 [INFO] [stdout] | [INFO] [stdout] 221 | pub(crate) fn cell_vecs_to_h3listarray( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_with_validity` is never used [INFO] [stdout] --> src/array/validity.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait FromWithValidity { [INFO] [stdout] | ---------------- associated function in this trait [INFO] [stdout] 6 | fn from_with_validity(value: T) -> Self; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `h3arrow` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "deec065b2b886b490c30e7c661aa272a4d92c72c034cb7731416033813bfc274", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "deec065b2b886b490c30e7c661aa272a4d92c72c034cb7731416033813bfc274", kill_on_drop: false }` [INFO] [stdout] deec065b2b886b490c30e7c661aa272a4d92c72c034cb7731416033813bfc274