[INFO] fetching crate gsim 1.1.4... [INFO] checking gsim-1.1.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate gsim 1.1.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate gsim 1.1.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gsim 1.1.4 [INFO] finished tweaking crates.io crate gsim 1.1.4 [INFO] tweaked toml for crates.io crate gsim 1.1.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 123 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (available: v4.5.18) [INFO] [stderr] Adding clap_lex v0.2.4 (available: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (available: v0.5.1) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding indoc v1.0.9 (available: v2.0.5) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding itertools v0.11.0 (available: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (available: v7.0.0) [INFO] [stderr] Adding pyo3 v0.19.2 (available: v0.22.3) [INFO] [stderr] Adding pyo3-build-config v0.19.2 (available: v0.22.3) [INFO] [stderr] Adding pyo3-ffi v0.19.2 (available: v0.22.3) [INFO] [stderr] Adding pyo3-macros v0.19.2 (available: v0.22.3) [INFO] [stderr] Adding pyo3-macros-backend v0.19.2 (available: v0.22.3) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding unindent v0.1.11 (available: v0.2.3) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 100d928e50cd32f24f5cb3f0d243fac93b9b2aabfa520ec2529c10e3cace88f4 [INFO] running `Command { std: "docker" "start" "-a" "100d928e50cd32f24f5cb3f0d243fac93b9b2aabfa520ec2529c10e3cace88f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "100d928e50cd32f24f5cb3f0d243fac93b9b2aabfa520ec2529c10e3cace88f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "100d928e50cd32f24f5cb3f0d243fac93b9b2aabfa520ec2529c10e3cace88f4", kill_on_drop: false }` [INFO] [stdout] 100d928e50cd32f24f5cb3f0d243fac93b9b2aabfa520ec2529c10e3cace88f4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2edd17c96a0dde6ac91faef39cb98ce7b04097e991eb9503b531e3639a6f229d [INFO] running `Command { std: "docker" "start" "-a" "2edd17c96a0dde6ac91faef39cb98ce7b04097e991eb9503b531e3639a6f229d", kill_on_drop: false }` [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking bounded-integer v0.5.7 [INFO] [stderr] Checking sync-unsafe-cell v0.1.1 [INFO] [stderr] Checking cow-utils v0.1.3 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking gsim v1.1.4 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stdout] warning: associated function `from_u32` is never used [INFO] [stdout] --> src/id_lists.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 68 | pub(crate) trait IdInternal: Id { [INFO] [stdout] | ---------- associated function in this trait [INFO] [stdout] 69 | fn to_u32(self) -> u32; [INFO] [stdout] 70 | fn from_u32(val: u32) -> Self; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `EnsureLen` is never used [INFO] [stdout] --> src/import/yosys.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | trait EnsureLen { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/import/yosys.rs:671:9 [INFO] [stdout] | [INFO] [stdout] 667 | / fn perform_fixups( [INFO] [stdout] 668 | | &mut self, [INFO] [stdout] 669 | | builder: &mut crate::SimulatorBuilder, [INFO] [stdout] 670 | | ) -> Result<(), YosysModuleImportError> { [INFO] [stdout] | |___________________________________________- move the `impl` block outside of this method `perform_fixups` [INFO] [stdout] 671 | impl WireMap { [INFO] [stdout] | ^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | `WireMap` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Simulator` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/component.rs:886:13 [INFO] [stdout] | [INFO] [stdout] 825 | &[ [INFO] [stdout] | ______________- [INFO] [stdout] 826 | | $( [INFO] [stdout] 827 | | TestData { [INFO] [stdout] 828 | | input: bits!($($i),+), [INFO] [stdout] ... | [INFO] [stdout] 832 | | )* [INFO] [stdout] 833 | | ] [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 886 | let mut sim = builder.build(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Simulator` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/component.rs:965:13 [INFO] [stdout] | [INFO] [stdout] 916 | &[ [INFO] [stdout] | ______________- [INFO] [stdout] 917 | | $( [INFO] [stdout] 918 | | TestData { [INFO] [stdout] 919 | | inputs: vec![$(bits!($($i),+)),+], [INFO] [stdout] ... | [INFO] [stdout] 922 | | )* [INFO] [stdout] 923 | | ] [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 965 | let mut sim = builder.build(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/component.rs:1365:13 [INFO] [stdout] | [INFO] [stdout] 1258 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1352 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1365 | let output_state = sim.get_wire_state(output).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/component.rs:1704:13 [INFO] [stdout] | [INFO] [stdout] 1635 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1704 | let output_state = sim.get_wire_state(data_out).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/component.rs:2204:13 [INFO] [stdout] | [INFO] [stdout] 2193 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2204 | let output_state = sim.get_wire_state(output).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/test.rs:233:10 [INFO] [stdout] | [INFO] [stdout] 233 | &[ [INFO] [stdout] | __________- [INFO] [stdout] 234 | | $( [INFO] [stdout] 235 | | UnaryGateTestData { [INFO] [stdout] 236 | | input: logic_state!($i), [INFO] [stdout] ... | [INFO] [stdout] 239 | | )* [INFO] [stdout] 240 | | ] [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/component.rs:2241:13 [INFO] [stdout] | [INFO] [stdout] 2230 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2241 | let output_state = sim.get_wire_state(output).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/test.rs:233:10 [INFO] [stdout] | [INFO] [stdout] 233 | &[ [INFO] [stdout] | __________- [INFO] [stdout] 234 | | $( [INFO] [stdout] 235 | | UnaryGateTestData { [INFO] [stdout] 236 | | input: logic_state!($i), [INFO] [stdout] ... | [INFO] [stdout] 239 | | )* [INFO] [stdout] 240 | | ] [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/component.rs:2370:13 [INFO] [stdout] | [INFO] [stdout] 2275 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2370 | let output_state = sim.get_wire_state(data_out).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/component.rs:2434:13 [INFO] [stdout] | [INFO] [stdout] 2413 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2434 | let output_state = sim.get_wire_state(data).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/import/yosys.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 89 | let (connections, mut sim) = test_yosys_import( [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let pc_next = sim.get_wire_state(connections.outputs["pc_next"]).unwrap(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/import/yosys.rs:302:13 [INFO] [stdout] | [INFO] [stdout] 224 | let (connections, mut sim) = test_yosys_import( [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | let output = sim.get_wire_state(connections.outputs["data_out"]).unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/import/yosys.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 322 | let (connections, mut sim) = test_yosys_import(JSON, &[("i", i_width)], &[("o", o_width)]); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | let output_state = sim.get_wire_state(connections.outputs["o"]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/import/yosys.rs:380:13 [INFO] [stdout] | [INFO] [stdout] 361 | let (connections, mut sim) = test_yosys_import(JSON, &[("i", i_width)], &[("o", o_width)]); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 380 | let output_state = sim.get_wire_state(connections.outputs["o"]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/test.rs:233:10 [INFO] [stdout] | [INFO] [stdout] 233 | &[ [INFO] [stdout] | __________- [INFO] [stdout] 234 | | $( [INFO] [stdout] 235 | | UnaryGateTestData { [INFO] [stdout] 236 | | input: logic_state!($i), [INFO] [stdout] ... | [INFO] [stdout] 239 | | )* [INFO] [stdout] 240 | | ] [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 50 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let output_state = sim.get_wire_state(output).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 85 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let output_state = sim.get_wire_state(output).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 173 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let output_state = sim.get_wire_state(output).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 209 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | let output_state = sim.get_wire_state(output).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Simulator` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:270:13 [INFO] [stdout] | [INFO] [stdout] 251 | fn test_wide_gate(add_gate: F, width: NonZeroU8, test_data: &[WideGateTestData], max_steps: u64) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | let mut sim = builder.build(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:334:17 [INFO] [stdout] | [INFO] [stdout] 304 | fn test_comparator(add_comparator: F, compare_op: impl Fn(u32, u32) -> bool) [INFO] [stdout] | -------------- ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | let expected = LogicState::from_bool(compare_op(a, b)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `logic::LogicState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:377:17 [INFO] [stdout] | [INFO] [stdout] 347 | fn test_signed_comparator(add_comparator: F, compare_op: impl Fn(i32, i32) -> bool) [INFO] [stdout] | -------------- ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | let mut sim = builder.build(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | let expected = LogicState::from_bool(compare_op(a, b)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_u32` is never used [INFO] [stdout] --> src/id_lists.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 68 | pub(crate) trait IdInternal: Id { [INFO] [stdout] | ---------- associated function in this trait [INFO] [stdout] 69 | fn to_u32(self) -> u32; [INFO] [stdout] 70 | fn from_u32(val: u32) -> Self; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `EnsureLen` is never used [INFO] [stdout] --> src/import/yosys.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | trait EnsureLen { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/import/yosys.rs:671:9 [INFO] [stdout] | [INFO] [stdout] 667 | / fn perform_fixups( [INFO] [stdout] 668 | | &mut self, [INFO] [stdout] 669 | | builder: &mut crate::SimulatorBuilder, [INFO] [stdout] 670 | | ) -> Result<(), YosysModuleImportError> { [INFO] [stdout] | |___________________________________________- move the `impl` block outside of this method `perform_fixups` [INFO] [stdout] 671 | impl WireMap { [INFO] [stdout] | ^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | `WireMap` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gsim` (lib test) due to 20 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2edd17c96a0dde6ac91faef39cb98ce7b04097e991eb9503b531e3639a6f229d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2edd17c96a0dde6ac91faef39cb98ce7b04097e991eb9503b531e3639a6f229d", kill_on_drop: false }` [INFO] [stdout] 2edd17c96a0dde6ac91faef39cb98ce7b04097e991eb9503b531e3639a6f229d