[INFO] fetching crate goscript-parser 0.1.0... [INFO] checking goscript-parser-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate goscript-parser 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate goscript-parser 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate goscript-parser 0.1.0 [INFO] finished tweaking crates.io crate goscript-parser 0.1.0 [INFO] tweaked toml for crates.io crate goscript-parser 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Adding slotmap v0.4.3 (available: v1.0.7) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d5885da3dddf0ee1bce05ac309ac5a24d535eaeae69792053b9417a866631d8b [INFO] running `Command { std: "docker" "start" "-a" "d5885da3dddf0ee1bce05ac309ac5a24d535eaeae69792053b9417a866631d8b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d5885da3dddf0ee1bce05ac309ac5a24d535eaeae69792053b9417a866631d8b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5885da3dddf0ee1bce05ac309ac5a24d535eaeae69792053b9417a866631d8b", kill_on_drop: false }` [INFO] [stdout] d5885da3dddf0ee1bce05ac309ac5a24d535eaeae69792053b9417a866631d8b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1a5ff315a05ffceca8c165d20116ae2fff4ded9fe7fa08d64cf4afd01af92817 [INFO] running `Command { std: "docker" "start" "-a" "1a5ff315a05ffceca8c165d20116ae2fff4ded9fe7fa08d64cf4afd01af92817", kill_on_drop: false }` [INFO] [stderr] Checking slotmap v0.4.3 [INFO] [stderr] Checking goscript-parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/position.rs:197:30 [INFO] [stdout] | [INFO] [stdout] 197 | return Some(f.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `position::File` does not implement `Borrow`, so calling `borrow` on `&position::File` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 197 - return Some(f.borrow()); [INFO] [stdout] 197 + return Some(f); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `position::File`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 42 + #[derive(Clone)] [INFO] [stdout] 43 | pub struct File { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/position.rs:197:30 [INFO] [stdout] | [INFO] [stdout] 197 | return Some(f.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `position::File` does not implement `Borrow`, so calling `borrow` on `&position::File` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 197 - return Some(f.borrow()); [INFO] [stdout] 197 + return Some(f); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `position::File`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 42 + #[derive(Clone)] [INFO] [stdout] 43 | pub struct File { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `Command { std: "docker" "inspect" "1a5ff315a05ffceca8c165d20116ae2fff4ded9fe7fa08d64cf4afd01af92817", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a5ff315a05ffceca8c165d20116ae2fff4ded9fe7fa08d64cf4afd01af92817", kill_on_drop: false }` [INFO] [stdout] 1a5ff315a05ffceca8c165d20116ae2fff4ded9fe7fa08d64cf4afd01af92817