[INFO] fetching crate goods 0.12.1... [INFO] checking goods-0.12.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate goods 0.12.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate goods 0.12.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate goods 0.12.1 [INFO] finished tweaking crates.io crate goods 0.12.1 [INFO] tweaked toml for crates.io crate goods 0.12.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate goods 0.12.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c81645d41d51adf5a389fa181a08d47b22166f1a3651737ced5f09f391ea4384 [INFO] running `Command { std: "docker" "start" "-a" "c81645d41d51adf5a389fa181a08d47b22166f1a3651737ced5f09f391ea4384", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c81645d41d51adf5a389fa181a08d47b22166f1a3651737ced5f09f391ea4384", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c81645d41d51adf5a389fa181a08d47b22166f1a3651737ced5f09f391ea4384", kill_on_drop: false }` [INFO] [stdout] c81645d41d51adf5a389fa181a08d47b22166f1a3651737ced5f09f391ea4384 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3382e5c326f55135d7c0e0e17c6cf588657b9845479b4664ebdeafefd8aa5734 [INFO] running `Command { std: "docker" "start" "-a" "3382e5c326f55135d7c0e0e17c6cf588657b9845479b4664ebdeafefd8aa5734", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking futures-sink v0.3.17 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Checking futures-io v0.3.17 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking slab v0.4.4 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling serde_json v1.0.67 [INFO] [stderr] Checking tracing-core v0.1.19 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling futures-macro v0.3.17 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Compiling tokio v1.11.0 [INFO] [stderr] Compiling ahash v0.7.4 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking hashbrown v0.12.0 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Compiling thiserror-impl v1.0.29 [INFO] [stderr] Compiling tracing-attributes v0.1.15 [INFO] [stderr] Compiling goods-proc v0.2.0 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking thiserror v1.0.29 [INFO] [stderr] Checking futures-executor v0.3.17 [INFO] [stderr] Checking futures v0.3.17 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking goods v0.12.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:672:51 [INFO] [stdout] | [INFO] [stdout] 672 | let path_shard = &self.path_cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 672 - let path_shard = &self.path_cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 672 + let path_shard = &self.path_cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:717:57 [INFO] [stdout] | [INFO] [stdout] 717 | ... let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 717 - let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 717 + let shard = &self.cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:778:41 [INFO] [stdout] | [INFO] [stdout] 778 | let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 778 - let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 778 + let shard = &self.cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:672:51 [INFO] [stdout] | [INFO] [stdout] 672 | let path_shard = &self.path_cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 672 - let path_shard = &self.path_cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 672 + let path_shard = &self.path_cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:717:57 [INFO] [stdout] | [INFO] [stdout] 717 | ... let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 717 - let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 717 + let shard = &self.cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:778:41 [INFO] [stdout] | [INFO] [stdout] 778 | let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 778 - let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 778 + let shard = &self.cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `AssetState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:871:9 [INFO] [stdout] | [INFO] [stdout] 870 | async fn load_asset_task(loader: &Loader, shard: Shard, key_hash: u64, id: AssetId) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 871 | let new_state = match load_asset(&loader.sources, id).await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `AssetState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:871:9 [INFO] [stdout] | [INFO] [stdout] 870 | async fn load_asset_task(loader: &Loader, shard: Shard, key_hash: u64, id: AssetId) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 871 | let new_state = match load_asset(&loader.sources, id).await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, hashbrown::HashMap>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:924:17 [INFO] [stdout] | [INFO] [stdout] 917 | path_shard: PathShard, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 924 | let mut locked_shard = path_shard.lock(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, hashbrown::HashMap>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:924:17 [INFO] [stdout] | [INFO] [stdout] 917 | path_shard: PathShard, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 924 | let mut locked_shard = path_shard.lock(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, hashbrown::HashMap>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:498:25 [INFO] [stdout] | [INFO] [stdout] 476 | pub fn get_impl(&mut self, waker: impl FnOnce() -> Option) -> Option> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | let mut locked_shard = path_shard.lock(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, hashbrown::HashMap>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:498:25 [INFO] [stdout] | [INFO] [stdout] 476 | pub fn get_impl(&mut self, waker: impl FnOnce() -> Option) -> Option> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | let mut locked_shard = path_shard.lock(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update` is never used [INFO] [stdout] --> src/loader.rs:114:8 [INFO] [stdout] | [INFO] [stdout] 111 | trait AnySource: Send + Sync + 'static { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 114 | fn update(&self, id: AssetId, version: u64) -> BoxFuture, Error>>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update` is never used [INFO] [stdout] --> src/loader.rs:114:8 [INFO] [stdout] | [INFO] [stdout] 111 | trait AnySource: Send + Sync + 'static { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 114 | fn update(&self, id: AssetId, version: u64) -> BoxFuture, Error>>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goods` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goods` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3382e5c326f55135d7c0e0e17c6cf588657b9845479b4664ebdeafefd8aa5734", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3382e5c326f55135d7c0e0e17c6cf588657b9845479b4664ebdeafefd8aa5734", kill_on_drop: false }` [INFO] [stdout] 3382e5c326f55135d7c0e0e17c6cf588657b9845479b4664ebdeafefd8aa5734