[INFO] fetching crate git-subset 0.1.0... [INFO] checking git-subset-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate git-subset 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate git-subset 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-subset 0.1.0 [INFO] finished tweaking crates.io crate git-subset 0.1.0 [INFO] tweaked toml for crates.io crate git-subset 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding bitflags v0.9.1 (available: v2.6.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding git2 v0.6.11 (available: v0.19.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding idna v0.1.5 (available: v1.0.2) [INFO] [stderr] Adding libgit2-sys v0.6.19 (available: v0.17.0+1.8.1) [INFO] [stderr] Adding libssh2-sys v0.2.23 (available: v0.3.0) [INFO] [stderr] Adding percent-encoding v1.0.1 (available: v2.3.1) [INFO] [stderr] Adding strsim v0.8.0 (available: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding url v1.7.2 (available: v2.5.2) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2f21431ea8b945aad19a8adb69b7d8bfe1f75479035950b3938a3e4ae93056a [INFO] running `Command { std: "docker" "start" "-a" "a2f21431ea8b945aad19a8adb69b7d8bfe1f75479035950b3938a3e4ae93056a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2f21431ea8b945aad19a8adb69b7d8bfe1f75479035950b3938a3e4ae93056a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2f21431ea8b945aad19a8adb69b7d8bfe1f75479035950b3938a3e4ae93056a", kill_on_drop: false }` [INFO] [stdout] a2f21431ea8b945aad19a8adb69b7d8bfe1f75479035950b3938a3e4ae93056a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 10f59236d204c663b6578ef028d3429c17bff772d8c3228e9fa9605ab9b28a88 [INFO] running `Command { std: "docker" "start" "-a" "10f59236d204c663b6578ef028d3429c17bff772d8c3228e9fa9605ab9b28a88", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling cc v1.1.22 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling curl-sys v0.4.76+curl-8.10.1 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking git2 v0.6.11 [INFO] [stderr] Checking git-subset v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/filter.rs:72:21 [INFO] [stdout] | [INFO] [stdout] 72 | let mut filter = self.filter [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `git2::Tree<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:188:10 [INFO] [stdout] | [INFO] [stdout] 164 | let commit = repo.find_commit(id)?; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | [INFO] [stdout] 166 | let tree = commit.tree()?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let parents : Vec<_> = commit [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let author = commit.author(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let committer = commit.committer(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | &repo.find_tree(newtree)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-subset` (bin "git-subset") due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/filter.rs:72:21 [INFO] [stdout] | [INFO] [stdout] 72 | let mut filter = self.filter [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `git2::Tree<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:188:10 [INFO] [stdout] | [INFO] [stdout] 164 | let commit = repo.find_commit(id)?; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | [INFO] [stdout] 166 | let tree = commit.tree()?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let parents : Vec<_> = commit [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let author = commit.author(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let committer = commit.committer(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | &repo.find_tree(newtree)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-subset` (bin "git-subset" test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "10f59236d204c663b6578ef028d3429c17bff772d8c3228e9fa9605ab9b28a88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10f59236d204c663b6578ef028d3429c17bff772d8c3228e9fa9605ab9b28a88", kill_on_drop: false }` [INFO] [stdout] 10f59236d204c663b6578ef028d3429c17bff772d8c3228e9fa9605ab9b28a88