[INFO] fetching crate git-snapshot 0.1.1... [INFO] checking git-snapshot-0.1.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate git-snapshot 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate git-snapshot 0.1.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-snapshot 0.1.1 [INFO] finished tweaking crates.io crate git-snapshot 0.1.1 [INFO] tweaked toml for crates.io crate git-snapshot 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate git-snapshot 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 706201fb0852a68a6777784578ce2a8265db4e597f6641cd4f94be601b7f7f11 [INFO] running `Command { std: "docker" "start" "-a" "706201fb0852a68a6777784578ce2a8265db4e597f6641cd4f94be601b7f7f11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "706201fb0852a68a6777784578ce2a8265db4e597f6641cd4f94be601b7f7f11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "706201fb0852a68a6777784578ce2a8265db4e597f6641cd4f94be601b7f7f11", kill_on_drop: false }` [INFO] [stdout] 706201fb0852a68a6777784578ce2a8265db4e597f6641cd4f94be601b7f7f11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ff4b91f0ecfde8ca4728a49911d6f83587b83827fe4a6418005f518afc2ef9a6 [INFO] running `Command { std: "docker" "start" "-a" "ff4b91f0ecfde8ca4728a49911d6f83587b83827fe4a6418005f518afc2ef9a6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling crossbeam-utils v0.8.9 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking crossbeam-channel v0.5.5 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.16 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking tokio v1.19.2 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking shellexpand v2.1.0 [INFO] [stderr] Checking notify v5.0.0-pre.15 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Compiling openssl-sys v0.9.74 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.13.4+1.4.2 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking tokio-util v0.7.3 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking tokio-stream v0.1.9 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking git2 v0.14.4 [INFO] [stderr] Checking git-snapshot v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result, git2::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 297 | let config = repo.git_repo.config().unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | let snapshot_branch = Repo::snapshot_branch(&config, &repo.current_branch().unwrap()); [INFO] [stdout] 299 | / repo.git_repo [INFO] [stdout] 300 | | .resolve_reference_from_short_name(&snapshot_branch) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/repo_watcher.rs:34:24 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct RepoWatcher(SyncWatcher); [INFO] [stdout] | ----------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/repo.rs:173:32 [INFO] [stdout] | [INFO] [stdout] 173 | let config = config.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `git2::Config` does not implement `Clone`, so calling `clone` on `&git2::Config` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 173 - let config = config.clone(); [INFO] [stdout] 173 + let config = config; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `git2::Config`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/git2-0.14.4/src/config.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 + #[derive(Clone)] [INFO] [stdout] 13 | pub struct Config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/repo_watcher.rs:34:24 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct RepoWatcher(SyncWatcher); [INFO] [stdout] | ----------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/repo.rs:173:32 [INFO] [stdout] | [INFO] [stdout] 173 | let config = config.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `git2::Config` does not implement `Clone`, so calling `clone` on `&git2::Config` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 173 - let config = config.clone(); [INFO] [stdout] 173 + let config = config; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `git2::Config`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/git2-0.14.4/src/config.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 + #[derive(Clone)] [INFO] [stdout] 13 | pub struct Config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-snapshot` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "ff4b91f0ecfde8ca4728a49911d6f83587b83827fe4a6418005f518afc2ef9a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff4b91f0ecfde8ca4728a49911d6f83587b83827fe4a6418005f518afc2ef9a6", kill_on_drop: false }` [INFO] [stdout] ff4b91f0ecfde8ca4728a49911d6f83587b83827fe4a6418005f518afc2ef9a6