[INFO] fetching crate gdbmi 0.0.2... [INFO] checking gdbmi-0.0.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate gdbmi 0.0.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gdbmi 0.0.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gdbmi 0.0.2 [INFO] finished tweaking crates.io crate gdbmi 0.0.2 [INFO] tweaked toml for crates.io crate gdbmi 0.0.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 126 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.15.2 (available: v0.24.1) [INFO] [stderr] Adding aho-corasick v0.7.15 (available: v0.7.20) [INFO] [stderr] Adding arrayvec v0.5.2 (available: v0.7.6) [INFO] [stderr] Adding backtrace v0.3.59 (available: v0.3.74) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding bitvec v0.19.6 (available: v1.0.1) [INFO] [stderr] Adding color-eyre v0.5.11 (available: v0.6.3) [INFO] [stderr] Adding color-spantrace v0.1.6 (available: v0.2.1) [INFO] [stderr] Adding ctor v0.1.26 (available: v0.2.8) [INFO] [stderr] Adding encode_unicode v0.3.6 (available: v1.0.0) [INFO] [stderr] Adding funty v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding gimli v0.24.0 (available: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding lexical-core v0.7.6 (available: v1.0.2) [INFO] [stderr] Adding matchers v0.0.1 (available: v0.2.0) [INFO] [stderr] Adding memchr v2.3.4 (available: v2.7.4) [INFO] [stderr] Adding miniz_oxide v0.4.4 (available: v0.8.0) [INFO] [stderr] Adding nom v6.2.2 (available: v7.1.3) [INFO] [stderr] Adding object v0.24.0 (available: v0.36.4) [INFO] [stderr] Adding owo-colors v1.3.0 (available: v4.1.0) [INFO] [stderr] Adding pretty_assertions v0.7.2 (available: v1.4.1) [INFO] [stderr] Adding radium v0.5.3 (available: v1.1.0) [INFO] [stderr] Adding regex v1.4.6 (available: v1.10.6) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding tracing-error v0.1.2 (available: v0.2.0) [INFO] [stderr] Adding tracing-log v0.1.4 (available: v0.2.0) [INFO] [stderr] Adding tracing-subscriber v0.2.25 (available: v0.3.18) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding wyz v0.2.0 (available: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 59804e7f1eb5322173d7e17202b6bd26153126369983a039034a6d040dabb807 [INFO] running `Command { std: "docker" "start" "-a" "59804e7f1eb5322173d7e17202b6bd26153126369983a039034a6d040dabb807", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "59804e7f1eb5322173d7e17202b6bd26153126369983a039034a6d040dabb807", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59804e7f1eb5322173d7e17202b6bd26153126369983a039034a6d040dabb807", kill_on_drop: false }` [INFO] [stdout] 59804e7f1eb5322173d7e17202b6bd26153126369983a039034a6d040dabb807 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 88f0bf5215a0825b51ddb6de029740d39047823cb14d8af4d4188ae639dcb49a [INFO] running `Command { std: "docker" "start" "-a" "88f0bf5215a0825b51ddb6de029740d39047823cb14d8af4d4188ae639dcb49a", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling nom v6.2.2 [INFO] [stderr] Compiling backtrace v0.3.59 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking gimli v0.24.0 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking owo-colors v1.3.0 [INFO] [stderr] Checking object v0.24.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking bitvec v0.19.6 [INFO] [stderr] Checking os_pipe v1.2.1 [INFO] [stderr] Checking shared_child v1.0.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking duct v0.13.7 [INFO] [stderr] Checking pretty_assertions v0.7.2 [INFO] [stderr] Checking regex v1.4.6 [INFO] [stderr] Checking insta v1.40.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking addr2line v0.15.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing-error v0.1.2 [INFO] [stderr] Checking color-spantrace v0.1.6 [INFO] [stderr] Checking color-eyre v0.5.11 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking gdbmi v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `State` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 81 | async fn mainloop(mut cmd: process::Child, mut rx: mpsc::UnboundedReceiver) { [INFO] [stdout] | ------- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let mut state = State { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | / select! { [INFO] [stdout] 113 | | // Don't pull any new command while we're waiting for console output [INFO] [stdout] 114 | | msg = rx.recv(), if &state.pending_console.is_none() => { [INFO] [stdout] 115 | | if let Err(err) = process_msg(msg, &mut state).await { [INFO] [stdout] ... | [INFO] [stdout] 136 | | } [INFO] [stdout] 137 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `State` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 81 | async fn mainloop(mut cmd: process::Child, mut rx: mpsc::UnboundedReceiver) { [INFO] [stdout] | ------- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let mut state = State { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | / select! { [INFO] [stdout] 113 | | // Don't pull any new command while we're waiting for console output [INFO] [stdout] 114 | | msg = rx.recv(), if &state.pending_console.is_none() => { [INFO] [stdout] 115 | | if let Err(err) = process_msg(msg, &mut state).await { [INFO] [stdout] ... | [INFO] [stdout] 136 | | } [INFO] [stdout] 137 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/worker.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | let mut pending = state.pending_console.as_mut().unwrap(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/worker.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | let mut pending = state.pending_console.as_mut().unwrap(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gdbmi` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gdbmi` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "88f0bf5215a0825b51ddb6de029740d39047823cb14d8af4d4188ae639dcb49a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88f0bf5215a0825b51ddb6de029740d39047823cb14d8af4d4188ae639dcb49a", kill_on_drop: false }` [INFO] [stdout] 88f0bf5215a0825b51ddb6de029740d39047823cb14d8af4d4188ae639dcb49a