[INFO] fetching crate gbas 0.1.0... [INFO] checking gbas-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate gbas 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate gbas 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gbas 0.1.0 [INFO] finished tweaking crates.io crate gbas 0.1.0 [INFO] tweaked toml for crates.io crate gbas 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 85927851340bf36dcf838cf38fc76487b1bc5fc0bce27dbe7259a2b46bcbffac [INFO] running `Command { std: "docker" "start" "-a" "85927851340bf36dcf838cf38fc76487b1bc5fc0bce27dbe7259a2b46bcbffac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "85927851340bf36dcf838cf38fc76487b1bc5fc0bce27dbe7259a2b46bcbffac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85927851340bf36dcf838cf38fc76487b1bc5fc0bce27dbe7259a2b46bcbffac", kill_on_drop: false }` [INFO] [stdout] 85927851340bf36dcf838cf38fc76487b1bc5fc0bce27dbe7259a2b46bcbffac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e6f257542f7976858b5bdbc8685220b0904d94909ffc7294eab0605507bb818 [INFO] running `Command { std: "docker" "start" "-a" "0e6f257542f7976858b5bdbc8685220b0904d94909ffc7294eab0605507bb818", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking gbas v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/codebase.rs:268:47 [INFO] [stdout] | [INFO] [stdout] 267 | impl<'a, FS: FileSystem + ?Sized> FileCodebase<'a, FS> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 268 | pub fn new(fs: &'a mut FS) -> FileCodebase { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/frontend/syntax/lexer.rs:106:16 [INFO] [stdout] | [INFO] [stdout] 106 | '0'...'9' => self.lex_decimal_number(), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/frontend/mod.rs:390:68 [INFO] [stdout] | [INFO] [stdout] 389 | impl<'a, C: Codebase + 'a, TT: TokenTracker> TokenStreamSource<'a, C, TT> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 390 | fn new(codebase: &'a C, token_tracker: TT) -> TokenStreamSource { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BinaryOperator` [INFO] [stdout] --> src/instruction.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | pub use backend::{BinaryOperator, RelocExpr}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/codebase.rs:268:47 [INFO] [stdout] | [INFO] [stdout] 267 | impl<'a, FS: FileSystem + ?Sized> FileCodebase<'a, FS> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 268 | pub fn new(fs: &'a mut FS) -> FileCodebase { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/frontend/syntax/lexer.rs:106:16 [INFO] [stdout] | [INFO] [stdout] 106 | '0'...'9' => self.lex_decimal_number(), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/frontend/mod.rs:390:68 [INFO] [stdout] | [INFO] [stdout] 389 | impl<'a, C: Codebase + 'a, TT: TokenTracker> TokenStreamSource<'a, C, TT> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 390 | fn new(codebase: &'a C, token_tracker: TT) -> TokenStreamSource { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/diagnostics.rs:342:43 [INFO] [stdout] | [INFO] [stdout] 342 | .map(|(_, line)| line.trim_right()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 342 | .map(|(_, line)| line.trim_end()) [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(LdDest, LdOperand>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/semantics/instruction/ld.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 12 | let src = self.next_operand_out_of(2)?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | match (dest.into_ld_dest()?, src.into_ld_src()?) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `S` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/semantics/instruction/ld.rs:113:33 [INFO] [stdout] | [INFO] [stdout] 110 | fn into_ld_dest(self) -> Result, InternalDiagnostic> { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Operand::Atom(kind, span) => match kind { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::ExpandedMacro>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/mod.rs:217:15 [INFO] [stdout] | [INFO] [stdout] 210 | name: (Self::Ident, Self::Span), [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | match self.macros.expand(name.clone(), args) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gbas` (lib) due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/diagnostics.rs:342:43 [INFO] [stdout] | [INFO] [stdout] 342 | .map(|(_, line)| line.trim_right()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 342 | .map(|(_, line)| line.trim_end()) [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(LdDest, LdOperand>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/semantics/instruction/ld.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 12 | let src = self.next_operand_out_of(2)?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | match (dest.into_ld_dest()?, src.into_ld_src()?) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `S` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/semantics/instruction/ld.rs:113:33 [INFO] [stdout] | [INFO] [stdout] 110 | fn into_ld_dest(self) -> Result, InternalDiagnostic> { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Operand::Atom(kind, span) => match kind { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, Vec>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/semantics/mod.rs:525:13 [INFO] [stdout] | [INFO] [stdout] 521 | (name, _): (impl Into, Self::Span), [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 525 | / self.operations [INFO] [stdout] 526 | | .borrow_mut() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::ExpandedMacro>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/mod.rs:217:15 [INFO] [stdout] | [INFO] [stdout] 210 | name: (Self::Ident, Self::Span), [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | match self.macros.expand(name.clone(), args) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, Vec>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/mod.rs:620:13 [INFO] [stdout] | [INFO] [stdout] 619 | fn add_label(&mut self, (label, _): (impl Into, ())) { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 620 | / self.log [INFO] [stdout] 621 | | .borrow_mut() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gbas` (lib test) due to 6 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0e6f257542f7976858b5bdbc8685220b0904d94909ffc7294eab0605507bb818", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e6f257542f7976858b5bdbc8685220b0904d94909ffc7294eab0605507bb818", kill_on_drop: false }` [INFO] [stdout] 0e6f257542f7976858b5bdbc8685220b0904d94909ffc7294eab0605507bb818