[INFO] fetching crate garando_syntax 0.1.1... [INFO] checking garando_syntax-0.1.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate garando_syntax 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate garando_syntax 0.1.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate garando_syntax 0.1.1 [INFO] finished tweaking crates.io crate garando_syntax 0.1.1 [INFO] tweaked toml for crates.io crate garando_syntax 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding dirs v2.0.2 (available: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (available: v0.4.1) [INFO] [stderr] Adding term v0.6.1 (available: v1.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 617551e8ca8a3e12157a8cea05e553d45482218d442ea3060f2cdb035c011cbe [INFO] running `Command { std: "docker" "start" "-a" "617551e8ca8a3e12157a8cea05e553d45482218d442ea3060f2cdb035c011cbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "617551e8ca8a3e12157a8cea05e553d45482218d442ea3060f2cdb035c011cbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "617551e8ca8a3e12157a8cea05e553d45482218d442ea3060f2cdb035c011cbe", kill_on_drop: false }` [INFO] [stdout] 617551e8ca8a3e12157a8cea05e553d45482218d442ea3060f2cdb035c011cbe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7e976c10c92adfed20e63064ff2ce0415234d4024e97b77ba3a1f0a3bae2be6 [INFO] running `Command { std: "docker" "start" "-a" "d7e976c10c92adfed20e63064ff2ce0415234d4024e97b77ba3a1f0a3bae2be6", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking unicode-xid v0.2.6 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking garando_pos v0.1.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking garando_errors v0.1.0 [INFO] [stderr] Checking garando_syntax v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::ext` [INFO] [stdout] --> src/ext/build.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | pub use crate::ext; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::parse` [INFO] [stdout] --> src/ext/build.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | pub use crate::parse; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::ext` [INFO] [stdout] --> src/ext/build.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | pub use crate::ext; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::parse` [INFO] [stdout] --> src/ext/build.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | pub use crate::parse; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SmallVectorRepr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/small_vector.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn push(&mut self, v: T) { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let one = mem::replace(&mut self.repr, Zero); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SmallVectorRepr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/small_vector.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn push(&mut self, v: T) { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let one = mem::replace(&mut self.repr, Zero); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sp_lhs` [INFO] [stdout] --> src/codemap.rs:499:27 [INFO] [stdout] | [INFO] [stdout] 499 | fn merge_spans(&self, sp_lhs: Span, sp_rhs: Span) -> Option { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sp_lhs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sp_rhs` [INFO] [stdout] --> src/codemap.rs:499:41 [INFO] [stdout] | [INFO] [stdout] 499 | fn merge_spans(&self, sp_lhs: Span, sp_rhs: Span) -> Option { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sp_rhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sp_lhs` [INFO] [stdout] --> src/codemap.rs:499:27 [INFO] [stdout] | [INFO] [stdout] 499 | fn merge_spans(&self, sp_lhs: Span, sp_rhs: Span) -> Option { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sp_lhs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sp_rhs` [INFO] [stdout] --> src/codemap.rs:499:41 [INFO] [stdout] | [INFO] [stdout] 499 | fn merge_spans(&self, sp_lhs: Span, sp_rhs: Span) -> Option { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sp_rhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext/expand.rs:452:38 [INFO] [stdout] | [INFO] [stdout] 430 | fn expand_attr_invoc(&mut self, invoc: Invocation, ext: Rc) -> Expansion { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | let meta = panictry!(attr.parse_meta(self.cx.parse_sess)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, DiagnosticBuilder<'_>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext/source_util.rs:113:28 [INFO] [stdout] | [INFO] [stdout] 112 | fn make_expr(mut self: Box>) -> Option> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Some(panictry!(self.p.parse_expr())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext/expand.rs:452:38 [INFO] [stdout] | [INFO] [stdout] 430 | fn expand_attr_invoc(&mut self, invoc: Invocation, ext: Rc) -> Expansion { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | let meta = panictry!(attr.parse_meta(self.cx.parse_sess)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `finish` is never used [INFO] [stdout] --> src/rustc_data_structures/stable_hasher.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 44 | pub trait StableHasherResult: Sized { [INFO] [stdout] | ------------------ associated function in this trait [INFO] [stdout] 45 | fn finish(hasher: StableHasher) -> Self; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, DiagnosticBuilder<'_>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext/source_util.rs:113:28 [INFO] [stdout] | [INFO] [stdout] 112 | fn make_expr(mut self: Box>) -> Option> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Some(panictry!(self.p.parse_expr())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ptr.rs:210:18 [INFO] [stdout] | [INFO] [stdout] 210 | self.ptr.into_iter() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 210 | self.ptr.iter() [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 210 | IntoIterator::into_iter(self.ptr) [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:231:35 [INFO] [stdout] | [INFO] [stdout] 231 | walk_list!(visitor, visit_ty, &local.ty); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:232:37 [INFO] [stdout] | [INFO] [stdout] 232 | walk_list!(visitor, visit_expr, &local.init); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:317:50 [INFO] [stdout] | [INFO] [stdout] 317 | walk_list!(visitor, visit_trait_ref, opt_trait_reference); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:368:37 [INFO] [stdout] | [INFO] [stdout] 368 | walk_list!(visitor, visit_expr, &variant.node.disr_expr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:377:49 [INFO] [stdout] | [INFO] [stdout] 377 | walk_list!(visitor, visit_lifetime, opt_lifetime); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:448:43 [INFO] [stdout] | [INFO] [stdout] 448 | walk_list!(visitor, visit_ty, &data.output); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:486:44 [INFO] [stdout] | [INFO] [stdout] 486 | walk_list!(visitor, visit_pat, optional_subpattern); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:496:44 [INFO] [stdout] | [INFO] [stdout] 496 | walk_list!(visitor, visit_pat, slice_pattern); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:533:39 [INFO] [stdout] | [INFO] [stdout] 533 | walk_list!(visitor, visit_ty, ¶m.default); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:617:45 [INFO] [stdout] | [INFO] [stdout] 617 | walk_list!(visitor, visit_expr, default); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:633:43 [INFO] [stdout] | [INFO] [stdout] 633 | walk_list!(visitor, visit_ty, default); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:727:45 [INFO] [stdout] | [INFO] [stdout] 727 | walk_list!(visitor, visit_expr, optional_base); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:756:45 [INFO] [stdout] | [INFO] [stdout] 756 | walk_list!(visitor, visit_expr, optional_else); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:767:45 [INFO] [stdout] | [INFO] [stdout] 767 | walk_list!(visitor, visit_expr, optional_else); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:816:45 [INFO] [stdout] | [INFO] [stdout] 816 | walk_list!(visitor, visit_expr, start); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:817:45 [INFO] [stdout] | [INFO] [stdout] 817 | walk_list!(visitor, visit_expr, end); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:827:45 [INFO] [stdout] | [INFO] [stdout] 827 | walk_list!(visitor, visit_expr, opt_expr); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:833:45 [INFO] [stdout] | [INFO] [stdout] 833 | walk_list!(visitor, visit_expr, optional_expression); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:854:37 [INFO] [stdout] | [INFO] [stdout] 854 | walk_list!(visitor, visit_expr, &arm.guard); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 25 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `finish` is never used [INFO] [stdout] --> src/rustc_data_structures/stable_hasher.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 44 | pub trait StableHasherResult: Sized { [INFO] [stdout] | ------------------ associated function in this trait [INFO] [stdout] 45 | fn finish(hasher: StableHasher) -> Self; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `CodeMapExtension` is never used [INFO] [stdout] --> src/codemap.rs:772:11 [INFO] [stdout] | [INFO] [stdout] 772 | trait CodeMapExtension { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garando_syntax` (lib) due to 4 previous errors; 25 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ptr.rs:210:18 [INFO] [stdout] | [INFO] [stdout] 210 | self.ptr.into_iter() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 210 | self.ptr.iter() [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 210 | IntoIterator::into_iter(self.ptr) [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:231:35 [INFO] [stdout] | [INFO] [stdout] 231 | walk_list!(visitor, visit_ty, &local.ty); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:232:37 [INFO] [stdout] | [INFO] [stdout] 232 | walk_list!(visitor, visit_expr, &local.init); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:317:50 [INFO] [stdout] | [INFO] [stdout] 317 | walk_list!(visitor, visit_trait_ref, opt_trait_reference); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:368:37 [INFO] [stdout] | [INFO] [stdout] 368 | walk_list!(visitor, visit_expr, &variant.node.disr_expr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:377:49 [INFO] [stdout] | [INFO] [stdout] 377 | walk_list!(visitor, visit_lifetime, opt_lifetime); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:448:43 [INFO] [stdout] | [INFO] [stdout] 448 | walk_list!(visitor, visit_ty, &data.output); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:486:44 [INFO] [stdout] | [INFO] [stdout] 486 | walk_list!(visitor, visit_pat, optional_subpattern); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:496:44 [INFO] [stdout] | [INFO] [stdout] 496 | walk_list!(visitor, visit_pat, slice_pattern); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:533:39 [INFO] [stdout] | [INFO] [stdout] 533 | walk_list!(visitor, visit_ty, ¶m.default); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:617:45 [INFO] [stdout] | [INFO] [stdout] 617 | walk_list!(visitor, visit_expr, default); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:633:43 [INFO] [stdout] | [INFO] [stdout] 633 | walk_list!(visitor, visit_ty, default); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:727:45 [INFO] [stdout] | [INFO] [stdout] 727 | walk_list!(visitor, visit_expr, optional_base); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:756:45 [INFO] [stdout] | [INFO] [stdout] 756 | walk_list!(visitor, visit_expr, optional_else); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:767:45 [INFO] [stdout] | [INFO] [stdout] 767 | walk_list!(visitor, visit_expr, optional_else); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:816:45 [INFO] [stdout] | [INFO] [stdout] 816 | walk_list!(visitor, visit_expr, start); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:817:45 [INFO] [stdout] | [INFO] [stdout] 817 | walk_list!(visitor, visit_expr, end); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:827:45 [INFO] [stdout] | [INFO] [stdout] 827 | walk_list!(visitor, visit_expr, opt_expr); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:833:45 [INFO] [stdout] | [INFO] [stdout] 833 | walk_list!(visitor, visit_expr, optional_expression); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:854:37 [INFO] [stdout] | [INFO] [stdout] 854 | walk_list!(visitor, visit_expr, &arm.guard); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some() = in $list { [INFO] [stdout] | ~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 26 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garando_syntax` (lib test) due to 4 previous errors; 26 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d7e976c10c92adfed20e63064ff2ce0415234d4024e97b77ba3a1f0a3bae2be6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7e976c10c92adfed20e63064ff2ce0415234d4024e97b77ba3a1f0a3bae2be6", kill_on_drop: false }` [INFO] [stdout] d7e976c10c92adfed20e63064ff2ce0415234d4024e97b77ba3a1f0a3bae2be6