[INFO] fetching crate garage_net 1.0.1... [INFO] checking garage_net-1.0.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate garage_net 1.0.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate garage_net 1.0.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate garage_net 1.0.1 [INFO] finished tweaking crates.io crate garage_net 1.0.1 [INFO] tweaked toml for crates.io crate garage_net 1.0.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 114 packages to latest compatible versions [INFO] [stderr] Adding dashmap v4.0.2 (available: v6.1.0) [INFO] [stderr] Adding env_logger v0.10.2 (available: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding opentelemetry v0.17.0 (available: v0.25.0) [INFO] [stderr] Adding opentelemetry-contrib v0.9.0 (available: v0.16.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding synstructure v0.12.6 (available: v0.13.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe113e1290f6ceb39b25083fab0adef4db957427d47b4b1400167cad1bb22243 [INFO] running `Command { std: "docker" "start" "-a" "fe113e1290f6ceb39b25083fab0adef4db957427d47b4b1400167cad1bb22243", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe113e1290f6ceb39b25083fab0adef4db957427d47b4b1400167cad1bb22243", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe113e1290f6ceb39b25083fab0adef4db957427d47b4b1400167cad1bb22243", kill_on_drop: false }` [INFO] [stdout] fe113e1290f6ceb39b25083fab0adef4db957427d47b4b1400167cad1bb22243 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 186f7429642a90e7429d06c75dff63e22f23ac420ad8b754f13634150fe62c96 [INFO] running `Command { std: "docker" "start" "-a" "186f7429642a90e7429d06c75dff63e22f23ac420ad8b754f13634150fe62c96", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling err-derive v0.3.1 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Compiling libsodium-sys v0.2.7 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking kuska-sodiumoxide v0.2.5-0 [INFO] [stderr] Checking kuska-handshake v0.2.0 [INFO] [stderr] Checking garage_net v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `tokio::net::TcpListener` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netapp.rs:209:7 [INFO] [stdout] | [INFO] [stdout] 192 | self: Arc, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | mut must_exit: watch::Receiver, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | let listener = TcpListener::bind(listen_addr).await.unwrap(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 243 | let (socket, peer_addr) = select! { [INFO] [stdout] | _______________________________________- [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 244 | | sockres = listener.accept() => { [INFO] [stdout] 245 | | match sockres { [INFO] [stdout] 246 | | Ok(x) => x, [INFO] [stdout] ... | [INFO] [stdout] 253 | | _ = must_exit.changed() => continue, [INFO] [stdout] 254 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::net::TcpListener` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netapp.rs:209:7 [INFO] [stdout] | [INFO] [stdout] 192 | self: Arc, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | mut must_exit: watch::Receiver, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | let listener = TcpListener::bind(listen_addr).await.unwrap(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 243 | let (socket, peer_addr) = select! { [INFO] [stdout] | _______________________________________- [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 244 | | sockres = listener.accept() => { [INFO] [stdout] 245 | | match sockres { [INFO] [stdout] 246 | | Ok(x) => x, [INFO] [stdout] ... | [INFO] [stdout] 253 | | _ = must_exit.changed() => continue, [INFO] [stdout] 254 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option> + std::marker::Send + Sync>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> client.rs:229:21 [INFO] [stdout] | [INFO] [stdout] 225 | fn recv_handler(self: &Arc, id: RequestID, stream: ByteStream) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | let mut inflight = self.inflight.lock().unwrap(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | if let Some(ch) = inflight.remove(&id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option> + std::marker::Send + Sync>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> client.rs:229:21 [INFO] [stdout] | [INFO] [stdout] 225 | fn recv_handler(self: &Arc, id: RequestID, stream: ByteStream) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | let mut inflight = self.inflight.lock().unwrap(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | if let Some(ch) = inflight.remove(&id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `Error` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_std_error_Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_fmt_Display_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_io_Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] 8 | #[error(display = "IO error: {}", _0)] [INFO] [stdout] 9 | Io(#[error(source)] io::Error), [INFO] [stdout] | --------- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_rmp_serde_encode_Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 12 | RMPEncode(#[error(source)] rmp_serde::encode::Error), [INFO] [stdout] | ------------------------ `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_rmp_serde_decode_Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 14 | RMPDecode(#[error(source)] rmp_serde::decode::Error), [INFO] [stdout] | ------------------------ `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_tokio_task_JoinError_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 17 | TokioJoin(#[error(source)] tokio::task::JoinError), [INFO] [stdout] | ---------------------- `JoinError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_tokio_sync_oneshot_error_RecvError_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 20 | OneshotRecv(#[error(source)] tokio::sync::oneshot::error::RecvError), [INFO] [stdout] | -------------------------------------- `RecvError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_kuska_handshake_async_std_Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 23 | Handshake(#[error(source)] kuska_handshake::async_std::Error), [INFO] [stdout] | --------------------------------- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_std_string_FromUtf8Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 26 | UTF8(#[error(source)] std::string::FromUtf8Error), [INFO] [stdout] | -------------------------- `FromUtf8Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `Error` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_std_error_Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_fmt_Display_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_io_Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] 8 | #[error(display = "IO error: {}", _0)] [INFO] [stdout] 9 | Io(#[error(source)] io::Error), [INFO] [stdout] | --------- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_rmp_serde_encode_Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 12 | RMPEncode(#[error(source)] rmp_serde::encode::Error), [INFO] [stdout] | ------------------------ `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_rmp_serde_decode_Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 14 | RMPDecode(#[error(source)] rmp_serde::decode::Error), [INFO] [stdout] | ------------------------ `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_tokio_task_JoinError_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 17 | TokioJoin(#[error(source)] tokio::task::JoinError), [INFO] [stdout] | ---------------------- `JoinError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_tokio_sync_oneshot_error_RecvError_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 20 | OneshotRecv(#[error(source)] tokio::sync::oneshot::error::RecvError), [INFO] [stdout] | -------------------------------------- `RecvError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_kuska_handshake_async_std_Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 23 | Handshake(#[error(source)] kuska_handshake::async_std::Error), [INFO] [stdout] | --------------------------------- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> error.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Error)] [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | `From` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_core_convert_From_std_string_FromUtf8Error_FOR_Error` [INFO] [stdout] 7 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] ... [INFO] [stdout] 26 | UTF8(#[error(source)] std::string::FromUtf8Error), [INFO] [stdout] | -------------------------- `FromUtf8Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Error` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Error` may come from an old version of the `err_derive` crate, try updating your dependency with `cargo update -p err_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garage_net` (lib) due to 3 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garage_net` (lib test) due to 3 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "186f7429642a90e7429d06c75dff63e22f23ac420ad8b754f13634150fe62c96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "186f7429642a90e7429d06c75dff63e22f23ac420ad8b754f13634150fe62c96", kill_on_drop: false }` [INFO] [stdout] 186f7429642a90e7429d06c75dff63e22f23ac420ad8b754f13634150fe62c96