[INFO] fetching crate forgefix 0.2.2... [INFO] checking forgefix-0.2.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate forgefix 0.2.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate forgefix 0.2.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate forgefix 0.2.2 [INFO] finished tweaking crates.io crate forgefix 0.2.2 [INFO] tweaked toml for crates.io crate forgefix 0.2.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 78 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding fallible-iterator v0.2.0 (available: v0.3.0) [INFO] [stderr] Adding hashlink v0.8.4 (available: v0.9.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding libsqlite3-sys v0.25.2 (available: v0.30.1) [INFO] [stderr] Adding rusqlite v0.28.0 (available: v0.32.1) [INFO] [stderr] Adding tokio-rusqlite v0.3.0 (available: v0.6.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc0016d6521f064a7a053b949d7076614581eb605e033e54d16cfbaddfc33440 [INFO] running `Command { std: "docker" "start" "-a" "dc0016d6521f064a7a053b949d7076614581eb605e033e54d16cfbaddfc33440", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc0016d6521f064a7a053b949d7076614581eb605e033e54d16cfbaddfc33440", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc0016d6521f064a7a053b949d7076614581eb605e033e54d16cfbaddfc33440", kill_on_drop: false }` [INFO] [stdout] dc0016d6521f064a7a053b949d7076614581eb605e033e54d16cfbaddfc33440 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 75cdee9293f0851f8d02f52efefa26e8401567ed670fcedded2139b35c2e64b8 [INFO] running `Command { std: "docker" "start" "-a" "75cdee9293f0851f8d02f52efefa26e8401567ed670fcedded2139b35c2e64b8", kill_on_drop: false }` [INFO] [stderr] Compiling libsqlite3-sys v0.25.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking rusqlite v0.28.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tokio-rusqlite v0.3.0 [INFO] [stderr] Checking forgefix v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Store` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fix.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 294 | mut stream: TcpStream, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | mut request_receiver: mpsc::UnboundedReceiver, [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | message_received_event_sender: mpsc::UnboundedSender>, [INFO] [stdout] | ----------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | let store = Store::build(&settings).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 363 | / tokio::select! { [INFO] [stdout] 364 | | bytes_read = stream::peek_stream(&mut stream, &mut peek_buf, stream::PEEK_LEN) => { [INFO] [stdout] 365 | | let maybe_message = match bytes_read { [INFO] [stdout] 366 | | Ok(b) => stream::preparse_stream(&peek_buf[..b], &mut stream, &mut logger).await, [INFO] [stdout] ... | [INFO] [stdout] 394 | | } [INFO] [stdout] 395 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Store` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fix.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 294 | mut stream: TcpStream, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | mut request_receiver: mpsc::UnboundedReceiver, [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | message_received_event_sender: mpsc::UnboundedSender>, [INFO] [stdout] | ----------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | let store = Store::build(&settings).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 363 | / tokio::select! { [INFO] [stdout] 364 | | bytes_read = stream::peek_stream(&mut stream, &mut peek_buf, stream::PEEK_LEN) => { [INFO] [stdout] 365 | | let maybe_message = match bytes_read { [INFO] [stdout] 366 | | Ok(b) => stream::preparse_stream(&peek_buf[..b], &mut stream, &mut logger).await, [INFO] [stdout] ... | [INFO] [stdout] 394 | | } [INFO] [stdout] 395 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/fix/session.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | SendTestRequest(u32), [INFO] [stdout] | --------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 64 | SendTestRequest(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/fix/session.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | SendTestRequest(u32), [INFO] [stdout] | --------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 64 | SendTestRequest(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `1` and `2` are never read [INFO] [stdout] --> src/fix/session.rs:65:32 [INFO] [stdout] | [INFO] [stdout] 65 | ResendRequestReceived(u32, u32, u32, Option), [INFO] [stdout] | --------------------- ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the fields to be of unit type to suppress this warning while preserving the field numbering, or remove the fields [INFO] [stdout] | [INFO] [stdout] 65 | ResendRequestReceived(u32, (), (), Option), [INFO] [stdout] | ~~ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `forgefix` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stdout] warning: fields `1` and `2` are never read [INFO] [stdout] --> src/fix/session.rs:65:32 [INFO] [stdout] | [INFO] [stdout] 65 | ResendRequestReceived(u32, u32, u32, Option), [INFO] [stdout] | --------------------- ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the fields to be of unit type to suppress this warning while preserving the field numbering, or remove the fields [INFO] [stdout] | [INFO] [stdout] 65 | ResendRequestReceived(u32, (), (), Option), [INFO] [stdout] | ~~ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `forgefix` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "75cdee9293f0851f8d02f52efefa26e8401567ed670fcedded2139b35c2e64b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75cdee9293f0851f8d02f52efefa26e8401567ed670fcedded2139b35c2e64b8", kill_on_drop: false }` [INFO] [stdout] 75cdee9293f0851f8d02f52efefa26e8401567ed670fcedded2139b35c2e64b8