[INFO] fetching crate fishrock_lambda_runtime 0.3.0-patched.1... [INFO] checking fishrock_lambda_runtime-0.3.0-patched.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate fishrock_lambda_runtime 0.3.0-patched.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate fishrock_lambda_runtime 0.3.0-patched.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fishrock_lambda_runtime 0.3.0-patched.1 [INFO] finished tweaking crates.io crate fishrock_lambda_runtime 0.3.0-patched.1 [INFO] tweaked toml for crates.io crate fishrock_lambda_runtime 0.3.0-patched.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate fishrock_lambda_runtime 0.3.0-patched.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f291c59f7306742c333405ae9257b2b713b8d218ffd7f6ffe563ba2f33db467 [INFO] running `Command { std: "docker" "start" "-a" "5f291c59f7306742c333405ae9257b2b713b8d218ffd7f6ffe563ba2f33db467", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f291c59f7306742c333405ae9257b2b713b8d218ffd7f6ffe563ba2f33db467", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f291c59f7306742c333405ae9257b2b713b8d218ffd7f6ffe563ba2f33db467", kill_on_drop: false }` [INFO] [stdout] 5f291c59f7306742c333405ae9257b2b713b8d218ffd7f6ffe563ba2f33db467 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3f3c3f4cf96af359340f4285160a0978ee512b3d2b2c374314ba3a312f21521b [INFO] running `Command { std: "docker" "start" "-a" "3f3c3f4cf96af359340f4285160a0978ee512b3d2b2c374314ba3a312f21521b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Compiling futures-core v0.3.15 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling futures-macro v0.3.15 [INFO] [stderr] Checking tracing-core v0.1.18 [INFO] [stderr] Compiling futures-channel v0.3.15 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling futures-task v0.3.15 [INFO] [stderr] Compiling futures-util v0.3.15 [INFO] [stderr] Checking futures-sink v0.3.15 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling tokio v1.6.0 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking futures-io v0.3.15 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling httparse v1.4.1 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Checking http v0.2.4 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking sharded-slab v0.1.1 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking socket2 v0.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking httpdate v1.0.0 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking simple-error v0.2.3 [INFO] [stderr] Checking simple_logger v1.11.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking http-body v0.4.2 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Compiling tracing-attributes v0.1.15 [INFO] [stderr] Compiling tokio-macros v1.2.0 [INFO] [stderr] Compiling pin-project-internal v1.0.7 [INFO] [stderr] Compiling async-stream-impl v0.3.1 [INFO] [stderr] Checking async-stream v0.3.1 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking pin-project v1.0.7 [INFO] [stderr] Checking futures-executor v0.3.15 [INFO] [stderr] Checking futures v0.3.15 [INFO] [stderr] Checking tokio-stream v0.1.6 [INFO] [stderr] Checking hyper v0.14.7 [INFO] [stderr] Checking tracing-serde v0.1.2 [INFO] [stderr] Checking tracing-subscriber v0.2.18 [INFO] [stderr] Checking tracing-error v0.1.2 [INFO] [stderr] Checking fishrock_lambda_runtime v0.3.0-patched.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | let handler = Arc::new(handler); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 152 | tokio::pin!(incoming); [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | let handler = Arc::new(handler); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 152 | tokio::pin!(incoming); [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Future, Box<(dyn StdError + Send + Sync + 'static)>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:268:5 [INFO] [stdout] | [INFO] [stdout] 268 | / async_stream::stream! { [INFO] [stdout] 269 | | loop { [INFO] [stdout] 270 | | trace!("Waiting for next event (incoming loop)"); [INFO] [stdout] 271 | | let req = NextEventRequest.into_req().expect("Unable to construct request"); [INFO] [stdout] 272 | | let res = client.call(req).await; [INFO] [stdout] | | ----- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | | yield res; [INFO] [stdout] 274 | | } [INFO] [stdout] 275 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `async_stream::stream` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Future, Box<(dyn StdError + Send + Sync + 'static)>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:268:5 [INFO] [stdout] | [INFO] [stdout] 268 | / async_stream::stream! { [INFO] [stdout] 269 | | loop { [INFO] [stdout] 270 | | trace!("Waiting for next event (incoming loop)"); [INFO] [stdout] 271 | | let req = NextEventRequest.into_req().expect("Unable to construct request"); [INFO] [stdout] 272 | | let res = client.call(req).await; [INFO] [stdout] | | ----- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | | yield res; [INFO] [stdout] 274 | | } [INFO] [stdout] 275 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `async_stream::stream` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `IntoResponse` is never used [INFO] [stdout] --> src/requests.rs:12:18 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) trait IntoResponse { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `InitErrorRequest` is never constructed [INFO] [stdout] --> src/requests.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 134 | struct InitErrorRequest; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MobileClientContext` is never constructed [INFO] [stdout] --> src/types.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | struct MobileClientContext(String); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MobileClientIdentity` is never constructed [INFO] [stdout] --> src/types.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | struct MobileClientIdentity(String); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fishrock_lambda_runtime` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result<(), JoinError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:184:15 [INFO] [stdout] | [INFO] [stdout] 173 | let client = Client::with(base, conn); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let rsp = client.call(req).await.expect("Unable to send request"); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | match server.await { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), JoinError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:215:15 [INFO] [stdout] | [INFO] [stdout] 202 | let client = Client::with(base, conn); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let rsp = client.call(req).await?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | match server.await { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), JoinError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:248:15 [INFO] [stdout] | [INFO] [stdout] 233 | let client = Client::with(base, conn); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let rsp = client.call(req).await?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | match server.await { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), JoinError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:304:15 [INFO] [stdout] | [INFO] [stdout] 266 | let runtime = Runtime::builder() [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | match server.await { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>, PoisonError>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulated.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn insert(&self, uri: Uri, stream: DuplexStreamWrapper) -> Result<(), Error> { [INFO] [stdout] | --- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | match self.inner.lock() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulated.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 48 | let connector = Connector::new(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | match connector.insert(uri, stream) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MobileClientContext` is never constructed [INFO] [stdout] --> src/types.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | struct MobileClientContext(String); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MobileClientIdentity` is never constructed [INFO] [stdout] --> src/types.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | struct MobileClientIdentity(String); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fishrock_lambda_runtime` (lib test) due to 9 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3f3c3f4cf96af359340f4285160a0978ee512b3d2b2c374314ba3a312f21521b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f3c3f4cf96af359340f4285160a0978ee512b3d2b2c374314ba3a312f21521b", kill_on_drop: false }` [INFO] [stdout] 3f3c3f4cf96af359340f4285160a0978ee512b3d2b2c374314ba3a312f21521b