[INFO] fetching crate firestore 0.43.1... [INFO] checking firestore-0.43.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate firestore 0.43.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate firestore 0.43.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate firestore 0.43.1 [INFO] finished tweaking crates.io crate firestore 0.43.1 [INFO] tweaked toml for crates.io crate firestore 0.43.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate firestore 0.43.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 74e42a04b24514a914434e1036bf17c8ec3fa08173ef61a58da32d7d27eef381 [INFO] running `Command { std: "docker" "start" "-a" "74e42a04b24514a914434e1036bf17c8ec3fa08173ef61a58da32d7d27eef381", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "74e42a04b24514a914434e1036bf17c8ec3fa08173ef61a58da32d7d27eef381", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74e42a04b24514a914434e1036bf17c8ec3fa08173ef61a58da32d7d27eef381", kill_on_drop: false }` [INFO] [stdout] 74e42a04b24514a914434e1036bf17c8ec3fa08173ef61a58da32d7d27eef381 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 67ce410abb39d09e7ccc95ee59dc3fb57580bb3c1a45267a09050c4616373172 [INFO] running `Command { std: "docker" "start" "-a" "67ce410abb39d09e7ccc95ee59dc3fb57580bb3c1a45267a09050c4616373172", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling cc v1.1.16 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling pin-project-internal v0.4.30 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking rustls-native-certs v0.7.3 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking rustls-native-certs v0.8.0 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Compiling rustix v0.38.36 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking tower v0.5.0 [INFO] [stderr] Compiling cargo-husky v1.5.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling struct-path v0.2.3 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling rvs_derive v0.3.2 [INFO] [stderr] Compiling rsb_derive v0.5.1 [INFO] [stderr] Checking rvstruct v0.3.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking pin-project v0.4.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling prost-derive v0.13.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.82 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking prost v0.13.2 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking prost-types v0.13.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking tower-util v0.3.1 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking jsonwebtoken v9.3.0 [INFO] [stderr] Checking secret-vault-value v0.3.9 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-rustls v0.27.3 [INFO] [stderr] Checking hyper-timeout v0.5.1 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking tonic v0.12.2 [INFO] [stderr] Checking gcloud-sdk v0.25.6 [INFO] [stderr] Checking firestore v0.43.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::result::Result> + std::marker::Send>>, errors::FirestoreError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/listen_changes.rs:382:19 [INFO] [stdout] | [INFO] [stdout] 360 | db: D, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 361 | storage: S, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | mut shutdown_receiver: UnboundedReceiver, [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | cb: FN, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | match db [INFO] [stdout] | ___________________^ [INFO] [stdout] 383 | | .listen_doc_changes(targets_state.values().cloned().collect()) [INFO] [stdout] 384 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] ... [INFO] [stdout] 392 | / tokio::select! { [INFO] [stdout] 393 | | shutdown_trigger = shutdown_receiver.recv() => { [INFO] [stdout] 394 | | if shutdown_trigger.is_none() { [INFO] [stdout] 395 | | debug!("Listener dropped. Exiting..."); [INFO] [stdout] ... | [INFO] [stdout] 456 | | } [INFO] [stdout] 457 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/batch_streaming_writer.rs:259:31 [INFO] [stdout] | [INFO] [stdout] 227 | pub async fn finish(mut self) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | if let Some(thread) = self.thread.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 260 | let _ = tokio::join!(thread); [INFO] [stdout] | -------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result> + std::marker::Send>>, errors::FirestoreError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/listen_changes.rs:382:19 [INFO] [stdout] | [INFO] [stdout] 360 | db: D, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 361 | storage: S, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | mut shutdown_receiver: UnboundedReceiver, [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | cb: FN, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | match db [INFO] [stdout] | ___________________^ [INFO] [stdout] 383 | | .listen_doc_changes(targets_state.values().cloned().collect()) [INFO] [stdout] 384 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] ... [INFO] [stdout] 392 | / tokio::select! { [INFO] [stdout] 393 | | shutdown_trigger = shutdown_receiver.recv() => { [INFO] [stdout] 394 | | if shutdown_trigger.is_none() { [INFO] [stdout] 395 | | debug!("Listener dropped. Exiting..."); [INFO] [stdout] ... | [INFO] [stdout] 456 | | } [INFO] [stdout] 457 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/batch_streaming_writer.rs:259:31 [INFO] [stdout] | [INFO] [stdout] 227 | pub async fn finish(mut self) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | if let Some(thread) = self.thread.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 260 | let _ = tokio::join!(thread); [INFO] [stdout] | -------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/list.rs:300:15 [INFO] [stdout] | [INFO] [stdout] 298 | span: Span, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | ) -> BoxFuture<'b, FirestoreResult> { [INFO] [stdout] 300 | match self.create_list_doc_request(params) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/list.rs:300:15 [INFO] [stdout] | [INFO] [stdout] 298 | span: Span, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | ) -> BoxFuture<'b, FirestoreResult> { [INFO] [stdout] 300 | match self.create_list_doc_request(params) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `firestore` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `firestore` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "67ce410abb39d09e7ccc95ee59dc3fb57580bb3c1a45267a09050c4616373172", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67ce410abb39d09e7ccc95ee59dc3fb57580bb3c1a45267a09050c4616373172", kill_on_drop: false }` [INFO] [stdout] 67ce410abb39d09e7ccc95ee59dc3fb57580bb3c1a45267a09050c4616373172