[INFO] fetching crate finality-grandpa 0.16.2... [INFO] checking finality-grandpa-0.16.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate finality-grandpa 0.16.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate finality-grandpa 0.16.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate finality-grandpa 0.16.2 [INFO] finished tweaking crates.io crate finality-grandpa 0.16.2 [INFO] tweaked toml for crates.io crate finality-grandpa 0.16.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 77 packages to latest compatible versions [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding env_logger v0.8.4 (available: v0.11.5) [INFO] [stderr] Adding radium v0.7.0 (available: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.5.1 (available: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f931cf04c32b247fde6ee0f21b7c269e09db88b49cb8c80f0a49aea8cabd0621 [INFO] running `Command { std: "docker" "start" "-a" "f931cf04c32b247fde6ee0f21b7c269e09db88b49cb8c80f0a49aea8cabd0621", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f931cf04c32b247fde6ee0f21b7c269e09db88b49cb8c80f0a49aea8cabd0621", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f931cf04c32b247fde6ee0f21b7c269e09db88b49cb8c80f0a49aea8cabd0621", kill_on_drop: false }` [INFO] [stdout] f931cf04c32b247fde6ee0f21b7c269e09db88b49cb8c80f0a49aea8cabd0621 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 568da2b762ea2a0174096cd63bb79baf5aa61c674a5ec93daaa2d3787e73ad24 [INFO] running `Command { std: "docker" "start" "-a" "568da2b762ea2a0174096cd63bb79baf5aa61c674a5ec93daaa2d3787e73ad24", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Compiling parity-scale-codec-derive v3.6.12 [INFO] [stderr] Compiling impl-trait-for-tuples v0.2.2 [INFO] [stderr] Compiling scale-info-derive v2.11.3 [INFO] [stderr] Checking parity-scale-codec v3.6.12 [INFO] [stderr] Checking scale-info v2.11.3 [INFO] [stderr] Checking finality-grandpa v0.16.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::collections::btree_map::Entry<'_, Id, VoteMultiplicity>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/round.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 101 | vote: Vote, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | signature: Signature, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | match self.votes.entry(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_graph.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn cumulative_vote<'a>(&'a self, hash: H, number: N) -> V { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | match self.find_containing_nodes(hash.clone(), number) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Subchain` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_graph.rs:360:3 [INFO] [stdout] | [INFO] [stdout] 296 | pub fn find_ghost<'a, F>(&'a self, current_best: Option<(H, N)>, condition: F) -> Option<(H, N)> [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | / self.ghost_find_merge_point( [INFO] [stdout] 361 | | node_key, [INFO] [stdout] 362 | | active_node, [INFO] [stdout] 363 | | if force_constrain { current_best } else { None }, [INFO] [stdout] 364 | | condition, [INFO] [stdout] 365 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_graph.rs:536:27 [INFO] [stdout] | [INFO] [stdout] 495 | fn introduce_branch(&mut self, descendents: Vec, ancestor_hash: H, ancestor_number: N) { [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 496 | let produced_entry = descendents.into_iter().fold(None, |mut maybe_entry, descendent| { [INFO] [stdout] | -------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 536 | if let Some((new_entry, prev_ancestor)) = produced_entry { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `finality-grandpa` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::collections::btree_map::Entry<'_, Id, VoteMultiplicity>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/round.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 101 | vote: Vote, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | signature: Signature, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | match self.votes.entry(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_graph.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn cumulative_vote<'a>(&'a self, hash: H, number: N) -> V { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | match self.find_containing_nodes(hash.clone(), number) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Subchain` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_graph.rs:360:3 [INFO] [stdout] | [INFO] [stdout] 296 | pub fn find_ghost<'a, F>(&'a self, current_best: Option<(H, N)>, condition: F) -> Option<(H, N)> [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | / self.ghost_find_merge_point( [INFO] [stdout] 361 | | node_key, [INFO] [stdout] 362 | | active_node, [INFO] [stdout] 363 | | if force_constrain { current_best } else { None }, [INFO] [stdout] 364 | | condition, [INFO] [stdout] 365 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_graph.rs:536:27 [INFO] [stdout] | [INFO] [stdout] 495 | fn introduce_branch(&mut self, descendents: Vec, ancestor_hash: H, ancestor_number: N) { [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 496 | let produced_entry = descendents.into_iter().fold(None, |mut maybe_entry, descendent| { [INFO] [stdout] | -------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 536 | if let Some((new_entry, prev_ancestor)) = produced_entry { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `finality-grandpa` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "568da2b762ea2a0174096cd63bb79baf5aa61c674a5ec93daaa2d3787e73ad24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "568da2b762ea2a0174096cd63bb79baf5aa61c674a5ec93daaa2d3787e73ad24", kill_on_drop: false }` [INFO] [stdout] 568da2b762ea2a0174096cd63bb79baf5aa61c674a5ec93daaa2d3787e73ad24