[INFO] fetching crate fil_actors_runtime_v8 2.0.0... [INFO] checking fil_actors_runtime_v8-2.0.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate fil_actors_runtime_v8 2.0.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate fil_actors_runtime_v8 2.0.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fil_actors_runtime_v8 2.0.0 [INFO] finished tweaking crates.io crate fil_actors_runtime_v8 2.0.0 [INFO] tweaked toml for crates.io crate fil_actors_runtime_v8 2.0.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 84 packages to latest compatible versions [INFO] [stderr] Adding cbor4ii v0.2.14 (available: v0.3.3) [INFO] [stderr] Adding cid v0.8.6 (available: v0.11.1) [INFO] [stderr] Adding cid v0.10.1 (available: v0.11.1) [INFO] [stderr] Adding fvm_ipld_amt v0.5.1 (available: v0.6.2) [INFO] [stderr] Adding fvm_ipld_blockstore v0.1.2 (available: v0.2.1) [INFO] [stderr] Adding fvm_ipld_encoding v0.3.3 (available: v0.4.0) [INFO] [stderr] Adding fvm_ipld_hamt v0.6.1 (available: v0.9.0) [INFO] [stderr] Adding fvm_shared v2.9.0 (available: v4.4.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding libipld-core v0.14.0 (available: v0.16.0) [INFO] [stderr] Adding multihash v0.16.3 (available: v0.19.1) [INFO] [stderr] Adding multihash v0.18.1 (available: v0.19.1) [INFO] [stderr] Adding multihash-derive v0.8.1 (available: v0.9.0) [INFO] [stderr] Adding num-derive v0.3.3 (available: v0.4.2) [INFO] [stderr] Adding proc-macro-crate v1.1.3 (available: v1.3.1) [INFO] [stderr] Adding serde-big-array v0.3.3 (available: v0.5.1) [INFO] [stderr] Adding serde_ipld_dagcbor v0.2.2 (available: v0.6.1) [INFO] [stderr] Adding serde_ipld_dagcbor v0.4.2 (available: v0.6.1) [INFO] [stderr] Adding serde_tuple v0.5.0 (available: v1.0.0) [INFO] [stderr] Adding serde_tuple_macros v0.5.0 (available: v1.0.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding synstructure v0.12.6 (available: v0.13.1) [INFO] [stderr] Adding toml v0.5.11 (available: v0.8.19) [INFO] [stderr] Adding unsigned-varint v0.7.2 (available: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3267045f9b22743967151603af9d01eb2b3e33a1641aa6eb5b7e59553a8704e8 [INFO] running `Command { std: "docker" "start" "-a" "3267045f9b22743967151603af9d01eb2b3e33a1641aa6eb5b7e59553a8704e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3267045f9b22743967151603af9d01eb2b3e33a1641aa6eb5b7e59553a8704e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3267045f9b22743967151603af9d01eb2b3e33a1641aa6eb5b7e59553a8704e8", kill_on_drop: false }` [INFO] [stdout] 3267045f9b22743967151603af9d01eb2b3e33a1641aa6eb5b7e59553a8704e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 36bd6eed83c883784e29f8a64a5db426494b05867814c5e45f1674ddd3060695 [INFO] running `Command { std: "docker" "start" "-a" "36bd6eed83c883784e29f8a64a5db426494b05867814c5e45f1674ddd3060695", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Compiling data-encoding v2.6.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking unsigned-varint v0.7.2 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking ripemd v0.1.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking unsigned-varint v0.8.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling proc-macro-crate v1.1.3 [INFO] [stderr] Compiling multihash-derive v0.8.1 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.13 [INFO] [stderr] Compiling serde_tuple_macros v0.5.0 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking data-encoding-macro v0.1.15 [INFO] [stderr] Checking multibase v0.9.1 [INFO] [stderr] Checking serde-big-array v0.3.3 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking cbor4ii v0.2.14 [INFO] [stderr] Checking serde_tuple v0.5.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking cs_serde_bytes v0.12.2 [INFO] [stderr] Checking multihash v0.16.3 [INFO] [stderr] Checking multihash v0.18.1 [INFO] [stderr] Checking forest_hash_utils v0.1.0 [INFO] [stderr] Checking cid v0.8.6 [INFO] [stderr] Checking cid v0.10.1 [INFO] [stderr] Checking fvm_ipld_blockstore v0.1.2 [INFO] [stderr] Checking serde_ipld_dagcbor v0.2.2 [INFO] [stderr] Checking libipld-core v0.14.0 [INFO] [stderr] Checking serde_ipld_dagcbor v0.4.2 [INFO] [stderr] Checking fvm_ipld_blockstore v0.2.1 [INFO] [stderr] Checking fvm_ipld_encoding v0.3.3 [INFO] [stderr] Checking fvm_ipld_amt v0.5.1 [INFO] [stderr] Checking fvm_ipld_encoding v0.4.0 [INFO] [stderr] Checking fvm_ipld_hamt v0.6.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking fvm_shared v2.9.0 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking fil_actors_runtime_v9 v2.0.0 [INFO] [stderr] Checking fil_actors_runtime_v8 v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use builtin::HAMT_BIT_WIDTH; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `HAMT_BIT_WIDTH` in the value namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub use self::builtin::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use builtin::HAMT_BIT_WIDTH; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use builtin::HAMT_BIT_WIDTH; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `HAMT_BIT_WIDTH` in the value namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub use self::builtin::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use builtin::HAMT_BIT_WIDTH; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/downcast.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 23 | fn downcast_default(self, default_exit_code: ExitCode, msg: impl AsRef) -> ActorError { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | match downcast_util(self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/downcast.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 31 | fn downcast_wrap(self, msg: impl AsRef) -> anyhow::Error { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match downcast_util(self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/downcast.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 23 | fn downcast_default(self, default_exit_code: ExitCode, msg: impl AsRef) -> ActorError { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | match downcast_util(self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/downcast.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 31 | fn downcast_wrap(self, msg: impl AsRef) -> anyhow::Error { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match downcast_util(self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/runtime/randomness.rs:8:38 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(PartialEq, Eq, Copy, Clone, FromPrimitive, Debug, Hash, Deserialize_repr)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_DomainSeparationTag` [INFO] [stdout] 9 | #[repr(i64)] [INFO] [stdout] 10 | pub enum DomainSeparationTag { [INFO] [stdout] | ------------------- `DomainSeparationTag` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/runtime/randomness.rs:8:38 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(PartialEq, Eq, Copy, Clone, FromPrimitive, Debug, Hash, Deserialize_repr)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_DomainSeparationTag` [INFO] [stdout] 9 | #[repr(i64)] [INFO] [stdout] 10 | pub enum DomainSeparationTag { [INFO] [stdout] | ------------------- `DomainSeparationTag` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fil_actors_runtime_v8` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `fil_actors_runtime_v8` (lib) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "36bd6eed83c883784e29f8a64a5db426494b05867814c5e45f1674ddd3060695", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36bd6eed83c883784e29f8a64a5db426494b05867814c5e45f1674ddd3060695", kill_on_drop: false }` [INFO] [stdout] 36bd6eed83c883784e29f8a64a5db426494b05867814c5e45f1674ddd3060695