[INFO] fetching crate ffs 0.1.2... [INFO] checking ffs-0.1.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate ffs 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ffs 0.1.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ffs 0.1.2 [INFO] finished tweaking crates.io crate ffs 0.1.2 [INFO] tweaked toml for crates.io crate ffs 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate ffs 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cb3df5ddae2be823eee7cdfe39129f1d33f9f0d0ceea9776b337d83f19845872 [INFO] running `Command { std: "docker" "start" "-a" "cb3df5ddae2be823eee7cdfe39129f1d33f9f0d0ceea9776b337d83f19845872", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cb3df5ddae2be823eee7cdfe39129f1d33f9f0d0ceea9776b337d83f19845872", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb3df5ddae2be823eee7cdfe39129f1d33f9f0d0ceea9776b337d83f19845872", kill_on_drop: false }` [INFO] [stdout] cb3df5ddae2be823eee7cdfe39129f1d33f9f0d0ceea9776b337d83f19845872 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0fb60e8aebdd082b057a0b95d81a766dc018040e26891aada078808959d8846 [INFO] running `Command { std: "docker" "start" "-a" "a0fb60e8aebdd082b057a0b95d81a766dc018040e26891aada078808959d8846", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling libc v0.2.95 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking tracing-core v0.1.18 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling fuser v0.9.1 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Checking sharded-slab v0.1.1 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking page_size v0.4.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking tracing-serde v0.1.2 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Compiling zerocopy-derive v0.3.0 [INFO] [stderr] Compiling tracing-attributes v0.1.15 [INFO] [stderr] Checking zerocopy v0.5.0 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking tracing-subscriber v0.2.18 [INFO] [stderr] Checking ffs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Span` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:891:7 [INFO] [stdout] | [INFO] [stdout] 890 | reply: ReplyEntry, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 891 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 892 | | info!("called"); [INFO] [stdout] 893 | | [INFO] [stdout] 894 | | // access control [INFO] [stdout] ... | [INFO] [stdout] 974 | | assert!(self.dirty.get()); [INFO] [stdout] 975 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Span` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:986:7 [INFO] [stdout] | [INFO] [stdout] 985 | reply: ReplyEntry, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 986 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 987 | | info!("called"); [INFO] [stdout] 988 | | [INFO] [stdout] 989 | | if !self.check_access(req) { [INFO] [stdout] ... | [INFO] [stdout] 1050 | | assert!(self.dirty.get()); [INFO] [stdout] 1051 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Span` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:1166:90 [INFO] [stdout] | [INFO] [stdout] 1166 | fn rmdir(&mut self, req: &Request<'_>, parent: u64, name: &OsStr, reply: ReplyEmpty) { [INFO] [stdout] | _______________________________________________________________________-----______________^ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1167 | | info!("called"); [INFO] [stdout] 1168 | | [INFO] [stdout] 1169 | | // access control [INFO] [stdout] ... | [INFO] [stdout] 1249 | | reply.ok(); [INFO] [stdout] 1250 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Span` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:1262:7 [INFO] [stdout] | [INFO] [stdout] 1261 | reply: ReplyEmpty, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1262 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 1263 | | info!("called"); [INFO] [stdout] 1264 | | [INFO] [stdout] 1265 | | // access control [INFO] [stdout] ... | [INFO] [stdout] 1388 | | reply.ok(); [INFO] [stdout] 1389 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/format.rs:635:12 [INFO] [stdout] | [INFO] [stdout] 635 | Io(std::io::Error), [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 635 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Span` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:891:7 [INFO] [stdout] | [INFO] [stdout] 890 | reply: ReplyEntry, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 891 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 892 | | info!("called"); [INFO] [stdout] 893 | | [INFO] [stdout] 894 | | // access control [INFO] [stdout] ... | [INFO] [stdout] 974 | | assert!(self.dirty.get()); [INFO] [stdout] 975 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/format.rs:798:12 [INFO] [stdout] | [INFO] [stdout] 798 | Io(std::io::Error), [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 798 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/fs.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | NoSuchInode(u64), [INFO] [stdout] | ----------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FSError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 106 | NoSuchInode(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/fs.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 107 | InvalidInode(u64), [INFO] [stdout] | ------------ ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FSError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 107 | InvalidInode(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Span` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:986:7 [INFO] [stdout] | [INFO] [stdout] 985 | reply: ReplyEntry, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 986 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 987 | | info!("called"); [INFO] [stdout] 988 | | [INFO] [stdout] 989 | | if !self.check_access(req) { [INFO] [stdout] ... | [INFO] [stdout] 1050 | | assert!(self.dirty.get()); [INFO] [stdout] 1051 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Span` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:1166:90 [INFO] [stdout] | [INFO] [stdout] 1166 | fn rmdir(&mut self, req: &Request<'_>, parent: u64, name: &OsStr, reply: ReplyEmpty) { [INFO] [stdout] | _______________________________________________________________________-----______________^ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1167 | | info!("called"); [INFO] [stdout] 1168 | | [INFO] [stdout] 1169 | | // access control [INFO] [stdout] ... | [INFO] [stdout] 1249 | | reply.ok(); [INFO] [stdout] 1250 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ffs` (bin "ffs" test) due to 5 previous errors; 4 warnings emitted [INFO] [stdout] error: this value of type `Span` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:1262:7 [INFO] [stdout] | [INFO] [stdout] 1261 | reply: ReplyEmpty, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1262 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 1263 | | info!("called"); [INFO] [stdout] 1264 | | [INFO] [stdout] 1265 | | // access control [INFO] [stdout] ... | [INFO] [stdout] 1388 | | reply.ok(); [INFO] [stdout] 1389 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/format.rs:635:12 [INFO] [stdout] | [INFO] [stdout] 635 | Io(std::io::Error), [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 635 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/format.rs:798:12 [INFO] [stdout] | [INFO] [stdout] 798 | Io(std::io::Error), [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 798 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/fs.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | NoSuchInode(u64), [INFO] [stdout] | ----------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FSError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 106 | NoSuchInode(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/fs.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 107 | InvalidInode(u64), [INFO] [stdout] | ------------ ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FSError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 107 | InvalidInode(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ffs` (bin "ffs") due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a0fb60e8aebdd082b057a0b95d81a766dc018040e26891aada078808959d8846", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0fb60e8aebdd082b057a0b95d81a766dc018040e26891aada078808959d8846", kill_on_drop: false }` [INFO] [stdout] a0fb60e8aebdd082b057a0b95d81a766dc018040e26891aada078808959d8846