[INFO] fetching crate fclones 0.34.0... [INFO] checking fclones-0.34.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate fclones 0.34.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate fclones 0.34.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fclones 0.34.0 [INFO] finished tweaking crates.io crate fclones 0.34.0 [INFO] tweaked toml for crates.io crate fclones 0.34.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate fclones 0.34.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a14420d9d4383faa8d45cbb825f23022eea194884ba32a8eb03f2d2538d3c66 [INFO] running `Command { std: "docker" "start" "-a" "1a14420d9d4383faa8d45cbb825f23022eea194884ba32a8eb03f2d2538d3c66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a14420d9d4383faa8d45cbb825f23022eea194884ba32a8eb03f2d2538d3c66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a14420d9d4383faa8d45cbb825f23022eea194884ba32a8eb03f2d2538d3c66", kill_on_drop: false }` [INFO] [stdout] 1a14420d9d4383faa8d45cbb825f23022eea194884ba32a8eb03f2d2538d3c66 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0bdb556db13cee9636a62ba0755b073795613d420b65c030b2471bcac6565983 [INFO] running `Command { std: "docker" "start" "-a" "0bdb556db13cee9636a62ba0755b073795613d420b65c030b2471bcac6565983", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling serde v1.0.189 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling rustix v0.38.20 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling rust_decimal v1.32.0 [INFO] [stderr] Compiling priority-queue v1.3.2 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking hashbrown v0.14.2 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking bstr v1.7.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking keccak v0.1.4 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking ansi-escapes v0.1.1 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking utf8-width v0.1.6 [INFO] [stderr] Checking indexmap v2.0.2 [INFO] [stderr] Checking fiemap v0.1.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking dunce v1.0.4 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking lazy-init v0.5.1 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking status-line v0.2.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking uuid v1.5.0 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking xattr v1.0.1 [INFO] [stderr] Compiling blake3 v1.5.0 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking metrohash v1.0.6 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking xxhash-rust v0.8.7 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking reflink v0.1.3 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking clap_builder v4.4.6 [INFO] [stderr] Checking tempfile v3.8.0 [INFO] [stderr] Checking file-owner v0.1.2 [INFO] [stderr] Checking sysinfo v0.29.10 [INFO] [stderr] Compiling serde_derive v1.0.189 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking globset v0.4.13 [INFO] [stderr] Checking stfu8 v0.2.6 [INFO] [stderr] Checking nom-regex v0.2.0 [INFO] [stderr] Checking ignore v0.4.20 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking clap v4.4.6 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking byte-unit v4.0.19 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_test v1.0.176 [INFO] [stderr] Checking typed-sled v0.2.3 [INFO] [stderr] Checking dtparse v2.0.0 [INFO] [stderr] Checking fclones v0.34.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 135 | fn eprintln(&self, msg: I) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | match self.progress_bar.lock().unwrap().upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 135 | fn eprintln(&self, msg: I) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | match self.progress_bar.lock().unwrap().upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:373:15 [INFO] [stdout] | [INFO] [stdout] 347 | path: Path, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | gitignore: IgnoreStack, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | let gitignore = if self.no_ignore { [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | match fs::read_dir(path.to_path_buf()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `as_file_hash` is never used [INFO] [stdout] --> src/file.rs:454:8 [INFO] [stdout] | [INFO] [stdout] 453 | pub trait AsFileHash { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 454 | fn as_file_hash(&self) -> &FileHash; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `total_size` is never used [INFO] [stdout] --> src/file.rs:542:8 [INFO] [stdout] | [INFO] [stdout] 538 | pub(crate) trait FileCollection { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 542 | fn total_size(&self) -> FileLen; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fclones` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:373:15 [INFO] [stdout] | [INFO] [stdout] 347 | path: Path, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | gitignore: IgnoreStack, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | let gitignore = if self.no_ignore { [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | match fs::read_dir(path.to_path_buf()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Vec>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:668:13 [INFO] [stdout] | [INFO] [stdout] 667 | walk.run(vec![Path::from(root)], |path| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 668 | results.lock().unwrap().push(path.to_path_buf()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `as_file_hash` is never used [INFO] [stdout] --> src/file.rs:454:8 [INFO] [stdout] | [INFO] [stdout] 453 | pub trait AsFileHash { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 454 | fn as_file_hash(&self) -> &FileHash; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `total_size` is never used [INFO] [stdout] --> src/file.rs:542:8 [INFO] [stdout] | [INFO] [stdout] 538 | pub(crate) trait FileCollection { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 542 | fn total_size(&self) -> FileLen; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/reflink.rs:357:34 [INFO] [stdout] | [INFO] [stdout] 357 | pub struct CrossTest<'a>(MutexGuard<'a, ()>); [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fclones` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0bdb556db13cee9636a62ba0755b073795613d420b65c030b2471bcac6565983", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bdb556db13cee9636a62ba0755b073795613d420b65c030b2471bcac6565983", kill_on_drop: false }` [INFO] [stdout] 0bdb556db13cee9636a62ba0755b073795613d420b65c030b2471bcac6565983