[INFO] fetching crate fav_utils 0.0.14... [INFO] checking fav_utils-0.0.14 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate fav_utils 0.0.14 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate fav_utils 0.0.14 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fav_utils 0.0.14 [INFO] finished tweaking crates.io crate fav_utils 0.0.14 [INFO] tweaked toml for crates.io crate fav_utils 0.0.14 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 188 packages to latest compatible versions [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (available: v1.0.0) [INFO] [stderr] Adding foreign-types v0.3.2 (available: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding idna v0.3.0 (available: v1.0.2) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding papergrid v0.11.0 (available: v0.12.0) [INFO] [stderr] Adding security-framework v2.11.1 (available: v3.0.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding tabled v0.15.0 (available: v0.16.0) [INFO] [stderr] Adding tabled_derive v0.7.0 (available: v0.8.0) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (available: v6.0.3) [INFO] [stderr] Adding windows-registry v0.2.0 (available: v0.3.0) [INFO] [stderr] Adding windows-strings v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2b246b04caee59d83b9fde0f13fbf2ce26e1b3ad691dbf10ad5bbfd1504a4fab [INFO] running `Command { std: "docker" "start" "-a" "2b246b04caee59d83b9fde0f13fbf2ce26e1b3ad691dbf10ad5bbfd1504a4fab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2b246b04caee59d83b9fde0f13fbf2ce26e1b3ad691dbf10ad5bbfd1504a4fab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b246b04caee59d83b9fde0f13fbf2ce26e1b3ad691dbf10ad5bbfd1504a4fab", kill_on_drop: false }` [INFO] [stdout] 2b246b04caee59d83b9fde0f13fbf2ce26e1b3ad691dbf10ad5bbfd1504a4fab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af05880fb01ab1c84b2da4838b570bcff25c1ef9a8f3b05351ecf9e0eecc8d77 [INFO] running `Command { std: "docker" "start" "-a" "af05880fb01ab1c84b2da4838b570bcff25c1ef9a8f3b05351ecf9e0eecc8d77", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling protobuf v3.5.1 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Compiling fastrand v2.1.1 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling bytes v1.7.2 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking psl-types v2.0.11 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking rustls-pki-types v1.9.0 [INFO] [stderr] Compiling fav_derive v0.0.3 [INFO] [stderr] Compiling portable-atomic v1.9.0 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking papergrid v0.11.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking ipnet v2.10.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking qrcode v0.14.1 [INFO] [stderr] Checking publicsuffix v2.2.3 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling tempfile v3.13.0 [INFO] [stderr] Compiling tabled_derive v0.7.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tabled v0.15.0 [INFO] [stderr] Checking sanitize-filename v0.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling trait-variant v0.1.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling protobuf-support v3.5.1 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking protobuf-json-mapping v3.5.1 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Compiling protobuf-parse v3.5.1 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling protobuf-codegen v3.5.1 [INFO] [stderr] Checking cookie_store v0.21.0 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Compiling fav_core v0.1.5 [INFO] [stderr] Compiling fav_utils v0.0.14 (/opt/rustwide/workdir) [INFO] [stderr] Checking hyper-util v0.1.9 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> src/bili/data.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> src/bili/data.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Response` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bili/local.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let mut resp_v = self.client().get(urls.pop().unwrap()).send().await?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | / tokio::select! { [INFO] [stdout] 54 | | _ = async { [INFO] [stdout] 55 | | while let Some(chunk) = resp_v.chunk().await? { [INFO] [stdout] 56 | | pb.inc(chunk.len() as u64); [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Response` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bili/local.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let mut resp_v = self.client().get(urls.pop().unwrap()).send().await?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | / tokio::select! { [INFO] [stdout] 54 | | _ = async { [INFO] [stdout] 55 | | while let Some(chunk) = resp_v.chunk().await? { [INFO] [stdout] 56 | | pb.inc(chunk.len() as u64); [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `BufferUnordered>, {closure@src/bili/ops.rs:98:18: 98:22}>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bili/ops.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | let mut stream = tokio_stream::iter(1..=page_count) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 110 | / tokio::select! { [INFO] [stdout] 111 | | res = async { [INFO] [stdout] 112 | | while let Some(res) = stream.next().await { [INFO] [stdout] 113 | | match res { [INFO] [stdout] ... | [INFO] [stdout] 123 | | _ = cancelled => Err(FavCoreError::Cancel) [INFO] [stdout] 124 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `BufferUnordered>, {closure@src/bili/ops.rs:98:18: 98:22}>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bili/ops.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | let mut stream = tokio_stream::iter(1..=page_count) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 110 | / tokio::select! { [INFO] [stdout] 111 | | res = async { [INFO] [stdout] 112 | | while let Some(res) = stream.next().await { [INFO] [stdout] 113 | | match res { [INFO] [stdout] ... | [INFO] [stdout] 123 | | _ = cancelled => Err(FavCoreError::Cancel) [INFO] [stdout] 124 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fav_utils` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fav_utils` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "af05880fb01ab1c84b2da4838b570bcff25c1ef9a8f3b05351ecf9e0eecc8d77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af05880fb01ab1c84b2da4838b570bcff25c1ef9a8f3b05351ecf9e0eecc8d77", kill_on_drop: false }` [INFO] [stdout] af05880fb01ab1c84b2da4838b570bcff25c1ef9a8f3b05351ecf9e0eecc8d77