[INFO] fetching crate fake_haproxy 0.1.1... [INFO] checking fake_haproxy-0.1.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate fake_haproxy 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate fake_haproxy 0.1.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fake_haproxy 0.1.1 [INFO] finished tweaking crates.io crate fake_haproxy 0.1.1 [INFO] tweaked toml for crates.io crate fake_haproxy 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate fake_haproxy 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3cf37503340fd999a1a014b5f25e413bdc2d56f97996ab442a8e9e21127c241a [INFO] running `Command { std: "docker" "start" "-a" "3cf37503340fd999a1a014b5f25e413bdc2d56f97996ab442a8e9e21127c241a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3cf37503340fd999a1a014b5f25e413bdc2d56f97996ab442a8e9e21127c241a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3cf37503340fd999a1a014b5f25e413bdc2d56f97996ab442a8e9e21127c241a", kill_on_drop: false }` [INFO] [stdout] 3cf37503340fd999a1a014b5f25e413bdc2d56f97996ab442a8e9e21127c241a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 353f375288f09043308cb31e30859d0a2935980043d0603b9d90f9cba4bd865c [INFO] running `Command { std: "docker" "start" "-a" "353f375288f09043308cb31e30859d0a2935980043d0603b9d90f9cba4bd865c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking futures v0.1.29 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling cc v1.0.45 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking arc-swap v0.4.2 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking signal-hook-registry v1.1.1 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking signal-hook v0.1.10 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Checking mio v0.6.19 [INFO] [stderr] Checking tokio-executor v0.1.8 [INFO] [stderr] Checking tokio-sync v0.1.6 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking tokio-timer v0.2.11 [INFO] [stderr] Checking tokio-current-thread v0.1.6 [INFO] [stderr] Checking tokio-io v0.1.12 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking tokio-threadpool v0.1.15 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking tokio-reactor v0.1.9 [INFO] [stderr] Checking tokio-fs v0.1.6 [INFO] [stderr] Checking tokio-udp v0.1.5 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking backtrace v0.3.37 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking fake_haproxy v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result<((), SelectNext>, {closure@src/forwarder.rs:113:13: 113:16}>, futures::MapErr, {closure@src/forwarder.rs:114:29: 114:32}>>), (error::Error, SelectNext>, {closure@src/forwarder.rs:113:13: 113:16}>, futures::MapErr, {closure@src/forwarder.rs:114:29: 114:32}>>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forwarder.rs:118:24 [INFO] [stdout] | [INFO] [stdout] 96 | fn listen(self, listener: TcpListener, core: Core, handle: Handle, shutdown: oneshot::Receiver<()>) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let mut core = core; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | println!("Starting proxy from {} to {}.", self.bind, self.target); [INFO] [stdout] 118 | if let Err((e, _)) = core.run(task) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_Error` [INFO] [stdout] 4 | pub(super) enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_Error` [INFO] [stdout] 4 | pub(super) enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<((), SelectNext>, {closure@src/forwarder.rs:113:13: 113:16}>, futures::MapErr, {closure@src/forwarder.rs:114:29: 114:32}>>), (error::Error, SelectNext>, {closure@src/forwarder.rs:113:13: 113:16}>, futures::MapErr, {closure@src/forwarder.rs:114:29: 114:32}>>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forwarder.rs:118:24 [INFO] [stdout] | [INFO] [stdout] 96 | fn listen(self, listener: TcpListener, core: Core, handle: Handle, shutdown: oneshot::Receiver<()>) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let mut core = core; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | println!("Starting proxy from {} to {}.", self.bind, self.target); [INFO] [stdout] 118 | if let Err((e, _)) = core.run(task) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fake_haproxy` (bin "fake_haproxy" test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_Error` [INFO] [stdout] 4 | pub(super) enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_Error` [INFO] [stdout] 4 | pub(super) enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fake_haproxy` (bin "fake_haproxy") due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "353f375288f09043308cb31e30859d0a2935980043d0603b9d90f9cba4bd865c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "353f375288f09043308cb31e30859d0a2935980043d0603b9d90f9cba4bd865c", kill_on_drop: false }` [INFO] [stdout] 353f375288f09043308cb31e30859d0a2935980043d0603b9d90f9cba4bd865c