[INFO] fetching crate faf-replay-parser 0.5.2... [INFO] checking faf-replay-parser-0.5.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate faf-replay-parser 0.5.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate faf-replay-parser 0.5.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate faf-replay-parser 0.5.2 [INFO] finished tweaking crates.io crate faf-replay-parser 0.5.2 [INFO] tweaked toml for crates.io crate faf-replay-parser 0.5.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate faf-replay-parser 0.5.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f43c9e2914221800d3abd90af3d8c74b05aa1179b271c3011b613a501457e1e0 [INFO] running `Command { std: "docker" "start" "-a" "f43c9e2914221800d3abd90af3d8c74b05aa1179b271c3011b613a501457e1e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f43c9e2914221800d3abd90af3d8c74b05aa1179b271c3011b613a501457e1e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f43c9e2914221800d3abd90af3d8c74b05aa1179b271c3011b613a501457e1e0", kill_on_drop: false }` [INFO] [stdout] f43c9e2914221800d3abd90af3d8c74b05aa1179b271c3011b613a501457e1e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a491e6439b396789e12ead28b7e30c40aa5e7ffa672e1daaf9f7c16f2512918a [INFO] running `Command { std: "docker" "start" "-a" "a491e6439b396789e12ead28b7e30c40aa5e7ffa672e1daaf9f7c16f2512918a", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking faf-replay-parser v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `scfa::replay::GameCommand` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scfa/parser.rs:1190:41 [INFO] [stdout] | [INFO] [stdout] 1157 | let ctx = ParserOptions { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1164 | let issue_command = parse_command(&mut data, &ctx, &mut vec![]) [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1169 | let command = GameCommand { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1190 | ReplayCommand::IssueCommand(issue_command) => { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `lua::LuaObject` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scfa/parser.rs:1231:17 [INFO] [stdout] | [INFO] [stdout] 1217 | let ctx = ParserOptions { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1224 | let command = parse_command(&mut data, &ctx, &mut vec![]) [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1231 | args, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `vec_read_until` is never used [INFO] [stdout] --> src/reader.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 154 | pub trait ReplayBufReadExt: io::BufRead + ReplayReadExt { [INFO] [stdout] | ---------------- method in this trait [INFO] [stdout] 155 | /// Convenience wrapper around `std::io::BufRead::read_until` for allocating a new `Vec`. [INFO] [stdout] 156 | fn vec_read_until(&mut self, byte: u8) -> io::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `vec_read_until` is never used [INFO] [stdout] --> src/reader.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 154 | pub trait ReplayBufReadExt: io::BufRead + ReplayReadExt { [INFO] [stdout] | ---------------- method in this trait [INFO] [stdout] 155 | /// Convenience wrapper around `std::io::BufRead::read_until` for allocating a new `Vec`. [INFO] [stdout] 156 | fn vec_read_until(&mut self, byte: u8) -> io::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `faf-replay-parser` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a491e6439b396789e12ead28b7e30c40aa5e7ffa672e1daaf9f7c16f2512918a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a491e6439b396789e12ead28b7e30c40aa5e7ffa672e1daaf9f7c16f2512918a", kill_on_drop: false }` [INFO] [stdout] a491e6439b396789e12ead28b7e30c40aa5e7ffa672e1daaf9f7c16f2512918a