[INFO] fetching crate egglog 0.2.0... [INFO] checking egglog-0.2.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate egglog 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate egglog 0.2.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate egglog 0.2.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate egglog 0.2.0 [INFO] tweaked toml for crates.io crate egglog 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate egglog 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 05d17d164c48799ce0c83f6054f067fe2268e74b1a6629dfc34380cf20bb30bc [INFO] running `Command { std: "docker" "start" "-a" "05d17d164c48799ce0c83f6054f067fe2268e74b1a6629dfc34380cf20bb30bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "05d17d164c48799ce0c83f6054f067fe2268e74b1a6629dfc34380cf20bb30bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05d17d164c48799ce0c83f6054f067fe2268e74b1a6629dfc34380cf20bb30bc", kill_on_drop: false }` [INFO] [stdout] 05d17d164c48799ce0c83f6054f067fe2268e74b1a6629dfc34380cf20bb30bc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 49d8379346b76bb052f1975da4e95f81201cc72bde7403bfdb734b05bdb9975b [INFO] running `Command { std: "docker" "start" "-a" "49d8379346b76bb052f1975da4e95f81201cc72bde7403bfdb734b05bdb9975b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling dot-structures v0.1.1 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Compiling either v1.10.0 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Compiling ena v0.14.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling into-attr v0.1.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling dot-generator v0.2.0 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling petgraph v0.6.4 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking generic_symbolic_expressions v5.0.4 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking symbol_table v0.3.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling into-attr-derive v0.2.1 [INFO] [stderr] Compiling lalrpop-util v0.20.2 [INFO] [stderr] Compiling regex v1.10.4 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling lalrpop v0.20.2 [INFO] [stderr] Checking pest v2.7.8 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking libtest-mimic v0.6.1 [INFO] [stderr] Compiling pest_meta v2.7.8 [INFO] [stderr] Compiling pest_generator v2.7.8 [INFO] [stderr] Compiling pest_derive v2.7.8 [INFO] [stderr] Checking graphviz-rust v0.6.6 [INFO] [stderr] Checking ordered-float v3.9.2 [INFO] [stderr] Checking egraph-serialize v0.1.0 [INFO] [stderr] Compiling egglog v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/function/index.rs:63:40 [INFO] [stdout] | [INFO] [stdout] 60 | pub(crate) fn to_canonicalize<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 63 | ) -> impl Iterator + '_ { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde-1` [INFO] [stdout] --> src/unionfind.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | #[cfg_attr(feature = "serde-1", derive(serde::Serialize, serde::Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `bin`, `default`, and `wasm-bindgen` [INFO] [stdout] = help: consider adding `serde-1` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/function/index.rs:63:40 [INFO] [stdout] | [INFO] [stdout] 60 | pub(crate) fn to_canonicalize<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 63 | ) -> impl Iterator + '_ { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde-1` [INFO] [stdout] --> src/unionfind.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | #[cfg_attr(feature = "serde-1", derive(serde::Serialize, serde::Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `bin`, `default`, and `wasm-bindgen` [INFO] [stdout] = help: consider adding `serde-1` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/remove_globals.rs:77:11 [INFO] [stdout] | [INFO] [stdout] 76 | fn replace_global_vars(expr: ResolvedExpr) -> ResolvedExpr { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | match expr.get_global_var() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/remove_globals.rs:190:53 [INFO] [stdout] | [INFO] [stdout] 189 | head: rule.head.clone().visit_exprs(&mut |expr| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | if let Some(resolved_var) = expr.get_global_var() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/remove_globals.rs:77:11 [INFO] [stdout] | [INFO] [stdout] 76 | fn replace_global_vars(expr: ResolvedExpr) -> ResolvedExpr { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | match expr.get_global_var() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/remove_globals.rs:190:53 [INFO] [stdout] | [INFO] [stdout] 189 | head: rule.head.clone().visit_exprs(&mut |expr| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | if let Some(resolved_var) = expr.get_global_var() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(gj::Context<'_>, gj::Program<'_>, Vec>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gj.rs:665:13 [INFO] [stdout] | [INFO] [stdout] 659 | mut f: F, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 665 | Context::new(self, cq, timestamp_ranges, include_subsumed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator> + '_` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gj.rs:737:25 [INFO] [stdout] | [INFO] [stdout] 730 | mut f: F, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 737 | for atom in cq.query.funcs() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, std::sync::Arc>, ConstraintError, std::sync::Arc>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 308 | let problem = Problem { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | problem.solve(|sort| sort.name()).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(gj::Context<'_>, gj::Program<'_>, Vec>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gj.rs:665:13 [INFO] [stdout] | [INFO] [stdout] 659 | mut f: F, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 665 | Context::new(self, cq, timestamp_ranges, include_subsumed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator> + '_` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gj.rs:737:25 [INFO] [stdout] | [INFO] [stdout] 730 | mut f: F, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 737 | for atom in cq.query.funcs() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `egglog` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::result::Result, std::sync::Arc>, ConstraintError, std::sync::Arc>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 308 | let problem = Problem { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | problem.solve(|sort| sort.name()).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `egglog` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "49d8379346b76bb052f1975da4e95f81201cc72bde7403bfdb734b05bdb9975b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49d8379346b76bb052f1975da4e95f81201cc72bde7403bfdb734b05bdb9975b", kill_on_drop: false }` [INFO] [stdout] 49d8379346b76bb052f1975da4e95f81201cc72bde7403bfdb734b05bdb9975b