[INFO] fetching crate edgedb-composable-query-derive 0.0.4... [INFO] checking edgedb-composable-query-derive-0.0.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate edgedb-composable-query-derive 0.0.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate edgedb-composable-query-derive 0.0.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate edgedb-composable-query-derive 0.0.4 [INFO] finished tweaking crates.io crate edgedb-composable-query-derive 0.0.4 [INFO] tweaked toml for crates.io crate edgedb-composable-query-derive 0.0.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (available: v1.0.0) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding itertools v0.11.0 (available: v0.13.0) [INFO] [stderr] Adding strum v0.25.0 (available: v0.26.3) [INFO] [stderr] Adding strum_macros v0.25.3 (available: v0.26.4) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 527f1045134132e925a912999d8d1c36e27ce122889d24d3f96fb7f32197f87f [INFO] running `Command { std: "docker" "start" "-a" "527f1045134132e925a912999d8d1c36e27ce122889d24d3f96fb7f32197f87f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "527f1045134132e925a912999d8d1c36e27ce122889d24d3f96fb7f32197f87f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "527f1045134132e925a912999d8d1c36e27ce122889d24d3f96fb7f32197f87f", kill_on_drop: false }` [INFO] [stdout] 527f1045134132e925a912999d8d1c36e27ce122889d24d3f96fb7f32197f87f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5adb50238438cc6f541ac46caefe3de6c857bf7e3fb35cee2f275b583f3b2f86 [INFO] running `Command { std: "docker" "start" "-a" "5adb50238438cc6f541ac46caefe3de6c857bf7e3fb35cee2f275b583f3b2f86", kill_on_drop: false }` [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking winnow v0.6.20 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking syn v2.0.79 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking insta v1.40.0 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking darling v0.20.10 [INFO] [stderr] Checking edgedb-composable-query-derive v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `query::QueryVar` [INFO] [stdout] --> src/composable_selector.rs:1:40 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{opts::ComposableQueryOpts, query::QueryVar, tokens::ComposableQueryAttribute}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/tokens.rs:129:28 [INFO] [stdout] | [INFO] [stdout] 129 | .ok_or({ "expected #[select] or #[direct] attribute for wrapper structs" })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 129 - .ok_or({ "expected #[select] or #[direct] attribute for wrapper structs" })?; [INFO] [stdout] 129 + .ok_or("expected #[select] or #[direct] attribute for wrapper structs")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/composable_selector.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut attribs = ComposableQueryAttribute::from_attrs(&item.attrs)?; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 84 | let args_kv = args [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | tokens.append_all(quote! { [INFO] [stdout] | ___________________________________- [INFO] [stdout] | |___________________________________| [INFO] [stdout] | |___________________________________| [INFO] [stdout] 94 | | { [INFO] [stdout] 95 | | let args = [#( #args_kv ),*].into(); [INFO] [stdout] 96 | | let mut buf = String::new(); [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] 102 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `selector_only` [INFO] [stdout] --> src/tokens.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | selector_only: bool, [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_selector_only` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ty` is never read [INFO] [stdout] --> src/object.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct EdgedbObjectField { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 12 | ident: Option, [INFO] [stdout] 13 | ty: Type, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `EdgedbObjectField` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `attrs` is never read [INFO] [stdout] --> src/object.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 20 | struct EdgedbObjectOpts { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 21 | ident: syn::Ident, [INFO] [stdout] 22 | attrs: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EdgedbObjectOpts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `edgedb-composable-query-derive` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5adb50238438cc6f541ac46caefe3de6c857bf7e3fb35cee2f275b583f3b2f86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5adb50238438cc6f541ac46caefe3de6c857bf7e3fb35cee2f275b583f3b2f86", kill_on_drop: false }` [INFO] [stdout] 5adb50238438cc6f541ac46caefe3de6c857bf7e3fb35cee2f275b583f3b2f86