[INFO] fetching crate drumbeat 0.1.1... [INFO] checking drumbeat-0.1.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate drumbeat 0.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate drumbeat 0.1.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate drumbeat 0.1.1 [INFO] finished tweaking crates.io crate drumbeat 0.1.1 [INFO] tweaked toml for crates.io crate drumbeat 0.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate drumbeat 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 60e0a6660ffc307be330846ac1deed5e1ced9c2665aaa2fea913e627d2597012 [INFO] running `Command { std: "docker" "start" "-a" "60e0a6660ffc307be330846ac1deed5e1ced9c2665aaa2fea913e627d2597012", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "60e0a6660ffc307be330846ac1deed5e1ced9c2665aaa2fea913e627d2597012", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60e0a6660ffc307be330846ac1deed5e1ced9c2665aaa2fea913e627d2597012", kill_on_drop: false }` [INFO] [stdout] 60e0a6660ffc307be330846ac1deed5e1ced9c2665aaa2fea913e627d2597012 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac7853d023ec2ada98101972bba22d1fe4ad0c29494722f831abc0697f51d4c7 [INFO] running `Command { std: "docker" "start" "-a" "ac7853d023ec2ada98101972bba22d1fe4ad0c29494722f831abc0697f51d4c7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.89 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking drumbeat v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event/observable.rs:187:12 [INFO] [stdout] | [INFO] [stdout] 184 | let guard = self.next.read().unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Some(guard.owner().unwrap().clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event/subscription.rs:37:11 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn finalize(&mut self, task: F) -> Self [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | match self.subscriber.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option + Send>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/task.rs:104:31 [INFO] [stdout] | [INFO] [stdout] 103 | pub(super) fn progress(self: Arc) -> bool { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | if let Some(mut future) = self.inner.lock().unwrap().future.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event/observable.rs:187:12 [INFO] [stdout] | [INFO] [stdout] 184 | let guard = self.next.read().unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Some(guard.owner().unwrap().clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `children` is never used [INFO] [stdout] --> src/event/dispatcher.rs:77:6 [INFO] [stdout] | [INFO] [stdout] 72 | pub(super) trait Dispatcher: Replicable + Send + Sync [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 77 | fn children(&self) -> Iter<'_, DispatchTarget>; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/event/observable.rs:388:12 [INFO] [stdout] | [INFO] [stdout] 388 | unsafe { ID.fetch_add(1, Ordering::Relaxed) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/sync/threadpool.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 63 | let id = unsafe { ID.fetch_add(1, Ordering::Relaxed) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/sync/worker.rs:100:23 [INFO] [stdout] | [INFO] [stdout] 100 | let id = unsafe { ID.fetch_add(1, Ordering::Relaxed) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `drumbeat` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event/subscription.rs:37:11 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn finalize(&mut self, task: F) -> Self [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | match self.subscriber.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option + Send>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/task.rs:104:31 [INFO] [stdout] | [INFO] [stdout] 103 | pub(super) fn progress(self: Arc) -> bool { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | if let Some(mut future) = self.inner.lock().unwrap().future.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `children` is never used [INFO] [stdout] --> src/event/dispatcher.rs:77:6 [INFO] [stdout] | [INFO] [stdout] 72 | pub(super) trait Dispatcher: Replicable + Send + Sync [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 77 | fn children(&self) -> Iter<'_, DispatchTarget>; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/event/observable.rs:388:12 [INFO] [stdout] | [INFO] [stdout] 388 | unsafe { ID.fetch_add(1, Ordering::Relaxed) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/sync/threadpool.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 63 | let id = unsafe { ID.fetch_add(1, Ordering::Relaxed) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/sync/worker.rs:100:23 [INFO] [stdout] | [INFO] [stdout] 100 | let id = unsafe { ID.fetch_add(1, Ordering::Relaxed) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `drumbeat` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ac7853d023ec2ada98101972bba22d1fe4ad0c29494722f831abc0697f51d4c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac7853d023ec2ada98101972bba22d1fe4ad0c29494722f831abc0697f51d4c7", kill_on_drop: false }` [INFO] [stdout] ac7853d023ec2ada98101972bba22d1fe4ad0c29494722f831abc0697f51d4c7