[INFO] fetching crate dropshot_endpoint 0.12.0... [INFO] checking dropshot_endpoint-0.12.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate dropshot_endpoint 0.12.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate dropshot_endpoint 0.12.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dropshot_endpoint 0.12.0 [INFO] finished tweaking crates.io crate dropshot_endpoint 0.12.0 [INFO] tweaked toml for crates.io crate dropshot_endpoint 0.12.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (available: v1.0.0) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9ac3c8c087635e00bc0b89498baa170911295c12c73525b4f9e1cd42a5edb613 [INFO] running `Command { std: "docker" "start" "-a" "9ac3c8c087635e00bc0b89498baa170911295c12c73525b4f9e1cd42a5edb613", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9ac3c8c087635e00bc0b89498baa170911295c12c73525b4f9e1cd42a5edb613", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ac3c8c087635e00bc0b89498baa170911295c12c73525b4f9e1cd42a5edb613", kill_on_drop: false }` [INFO] [stdout] 9ac3c8c087635e00bc0b89498baa170911295c12c73525b4f9e1cd42a5edb613 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4926cc72284a664b68e50cb153d64ab58fa534f1287c78aaf0cabae5a0249e26 [INFO] running `Command { std: "docker" "start" "-a" "4926cc72284a664b68e50cb153d64ab58fa534f1287c78aaf0cabae5a0249e26", kill_on_drop: false }` [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking newline-converter v0.3.0 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Compiling schema-derive v0.1.0 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.79 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking expectorate v1.1.0 [INFO] [stderr] Checking serde_tokenstream v0.2.2 [INFO] [stderr] Checking schema v0.1.0 [INFO] [stderr] Checking prettyplease v0.2.22 [INFO] [stderr] Checking dropshot_endpoint v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api_trait.rs:714:17 [INFO] [stdout] | [INFO] [stdout] 714 | let tag_config = self.make_tag_config(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 729 | / quote! { [INFO] [stdout] 730 | | let mut dropshot_api = #dropshot::ApiDescription::new()#tag_config; [INFO] [stdout] 731 | | let mut dropshot_errors: Vec<#dropshot::ApiDescriptionRegisterError> = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 739 | | } [INFO] [stdout] 740 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>, std::option::Option<&syn::Type>, std::option::Option<&syn::Type>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:309:13 [INFO] [stdout] | [INFO] [stdout] 277 | let (rqctx_ty, websocket_conn_ty) = params [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | let websocket_upgrade_ty = parse_quote! { #dropshot::WebsocketUpgrade }; [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | let endpoint_result_ty = [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | (rqctx_ty, websocket_conn, ret_ty) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>, std::option::Option<&syn::Type>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/endpoint.rs:299:56 [INFO] [stdout] | [INFO] [stdout] 281 | let rqctx_ty = [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | } else if let (Some(rqctx_ty), Some(ret_ty)) = (rqctx_ty, ret_ty) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, ErrorStoreData>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error_store.rs:60:29 [INFO] [stdout] | [INFO] [stdout] 59 | pub(crate) fn into_inner(self) -> Vec { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | std::mem::take(&mut self.data.borrow_mut().errors) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dropshot_endpoint` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api_trait.rs:714:17 [INFO] [stdout] | [INFO] [stdout] 714 | let tag_config = self.make_tag_config(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 729 | / quote! { [INFO] [stdout] 730 | | let mut dropshot_api = #dropshot::ApiDescription::new()#tag_config; [INFO] [stdout] 731 | | let mut dropshot_errors: Vec<#dropshot::ApiDescriptionRegisterError> = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 739 | | } [INFO] [stdout] 740 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>, std::option::Option<&syn::Type>, std::option::Option<&syn::Type>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:309:13 [INFO] [stdout] | [INFO] [stdout] 277 | let (rqctx_ty, websocket_conn_ty) = params [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | let websocket_upgrade_ty = parse_quote! { #dropshot::WebsocketUpgrade }; [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | let endpoint_result_ty = [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | (rqctx_ty, websocket_conn, ret_ty) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>, std::option::Option<&syn::Type>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/endpoint.rs:299:56 [INFO] [stdout] | [INFO] [stdout] 281 | let rqctx_ty = [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | } else if let (Some(rqctx_ty), Some(ret_ty)) = (rqctx_ty, ret_ty) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, ErrorStoreData>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error_store.rs:60:29 [INFO] [stdout] | [INFO] [stdout] 59 | pub(crate) fn into_inner(self) -> Vec { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | std::mem::take(&mut self.data.borrow_mut().errors) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `syn::Type` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/params.rs:775:17 [INFO] [stdout] | [INFO] [stdout] 658 | let some_type = parse_quote! { SomeType }; [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 659 | let self_context = parse_quote! { Self::Context }; [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 660 | let self_some_context = parse_quote! { Self::SomeContext }; [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 661 | let self_as_trait_context = [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 662 | parse_quote! { ::Context }; [INFO] [stdout] 663 | let unit = parse_quote! { () }; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 664 | let tuple = parse_quote! { (SomeType, OtherType) }; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 667 | let valid: &[(syn::Type, _)] = &[ [INFO] [stdout] | _________________________________________- [INFO] [stdout] 668 | | (parse_quote! { RequestContext }, Some(&some_type)), [INFO] [stdout] 669 | | // Self types for trait-based macros. [INFO] [stdout] 670 | | ( [INFO] [stdout] ... | [INFO] [stdout] 689 | | (parse_quote! { MyRequestContext }, None), [INFO] [stdout] 690 | | ]; [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 715 | let invalid: &[(syn::Type, RqctxTyError)] = &[ [INFO] [stdout] | ______________________________________________________- [INFO] [stdout] 716 | | (parse_quote! { &'a MyRequestContext }, RqctxTyError::NotTypePath), [INFO] [stdout] 717 | | (paren_generic_type, RqctxTyError::ArgsNotAngleBracketed), [INFO] [stdout] 718 | | ( [INFO] [stdout] ... | [INFO] [stdout] 722 | | (parse_quote! { RequestContext<'a> }, RqctxTyError::ArgNotType), [INFO] [stdout] 723 | | ]; [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 765 | quote! { #ty }, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 771 | quote! { #ty }, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 775 | let mut ty2 = ty.clone(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 780 | quote! { #ty }, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 786 | quote! { #ty }, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dropshot_endpoint` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "4926cc72284a664b68e50cb153d64ab58fa534f1287c78aaf0cabae5a0249e26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4926cc72284a664b68e50cb153d64ab58fa534f1287c78aaf0cabae5a0249e26", kill_on_drop: false }` [INFO] [stdout] 4926cc72284a664b68e50cb153d64ab58fa534f1287c78aaf0cabae5a0249e26