[INFO] fetching crate djin-protocol-derive 3.3.1... [INFO] checking djin-protocol-derive-3.3.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate djin-protocol-derive 3.3.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate djin-protocol-derive 3.3.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate djin-protocol-derive 3.3.1 [INFO] finished tweaking crates.io crate djin-protocol-derive 3.3.1 [INFO] tweaked toml for crates.io crate djin-protocol-derive 3.3.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a64f799a898899f810eefd865c606a9856fb9adcc20603addbddad5f68dbe18e [INFO] running `Command { std: "docker" "start" "-a" "a64f799a898899f810eefd865c606a9856fb9adcc20603addbddad5f68dbe18e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a64f799a898899f810eefd865c606a9856fb9adcc20603addbddad5f68dbe18e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a64f799a898899f810eefd865c606a9856fb9adcc20603addbddad5f68dbe18e", kill_on_drop: false }` [INFO] [stdout] a64f799a898899f810eefd865c606a9856fb9adcc20603addbddad5f68dbe18e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 492c4620c59b9b2d6efa2b1d79dbca3c3bd68ff56548f808330c9f296b0760bd [INFO] running `Command { std: "docker" "start" "-a" "492c4620c59b9b2d6efa2b1d79dbca3c3bd68ff56548f808330c9f296b0760bd", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.13 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking djin-protocol-derive v3.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `MetaList` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attr.rs:151:50 [INFO] [stdout] | [INFO] [stdout] 149 | meta_list.nested.into_iter().for_each(|nested_metas| { [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | match nested_metas { [INFO] [stdout] 151 | NestedMeta::Meta(syn::Meta::List(nested_list)) => { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `syn::Path` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attr.rs:324:51 [INFO] [stdout] | [INFO] [stdout] 323 | with_unitary_list(name, attrs).map(|nested| match nested { [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | syn::NestedMeta::Meta(syn::Meta::Path(path)) => match path.get_ident() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/enums.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 83 | (field_names, quote! { [INFO] [stdout] | ___________________________- [INFO] [stdout] | |___________________________| [INFO] [stdout] | |___________________________| [INFO] [stdout] | |___________________________| [INFO] [stdout] | |___________________________| [INFO] [stdout] 84 | | #parent_name { #( #field_name_refs ),* } [INFO] [stdout] 85 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | | let field_refs: Vec<_> = binding_names.iter().map(|i| quote! { ref #i }).collect(); [INFO] [stdout] | | ^^^^^^^^^^ [INFO] [stdout] 93 | | [INFO] [stdout] 94 | (binding_names, quote! { [INFO] [stdout] | _____________________________- [INFO] [stdout] | |_____________________________| [INFO] [stdout] 95 | | #parent_name ( #( #field_refs ),* ) [INFO] [stdout] 96 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/mod.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | let fields_variables: Vec = fields_named.named.iter().map(|field| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 66 | / quote! { [INFO] [stdout] 67 | | #( #fields_variables)* [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/mod.rs:48:43 [INFO] [stdout] | [INFO] [stdout] 42 | let field_attributes = &protocol(&field.attrs); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let update_hints = update_hints_after_read(field, &fields_named.named); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let update_hints_fixed = update_hint_fixed_length(field, &fields_named.named, field_attributes); [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | if let Some(skip_condition) = maybe_skip(field_attributes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `djin-protocol-derive` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `MetaList` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attr.rs:151:50 [INFO] [stdout] | [INFO] [stdout] 149 | meta_list.nested.into_iter().for_each(|nested_metas| { [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | match nested_metas { [INFO] [stdout] 151 | NestedMeta::Meta(syn::Meta::List(nested_list)) => { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `syn::Path` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attr.rs:324:51 [INFO] [stdout] | [INFO] [stdout] 323 | with_unitary_list(name, attrs).map(|nested| match nested { [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | syn::NestedMeta::Meta(syn::Meta::Path(path)) => match path.get_ident() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/enums.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 83 | (field_names, quote! { [INFO] [stdout] | ___________________________- [INFO] [stdout] | |___________________________| [INFO] [stdout] | |___________________________| [INFO] [stdout] | |___________________________| [INFO] [stdout] | |___________________________| [INFO] [stdout] 84 | | #parent_name { #( #field_name_refs ),* } [INFO] [stdout] 85 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | | let field_refs: Vec<_> = binding_names.iter().map(|i| quote! { ref #i }).collect(); [INFO] [stdout] | | ^^^^^^^^^^ [INFO] [stdout] 93 | | [INFO] [stdout] 94 | (binding_names, quote! { [INFO] [stdout] | _____________________________- [INFO] [stdout] | |_____________________________| [INFO] [stdout] 95 | | #parent_name ( #( #field_refs ),* ) [INFO] [stdout] 96 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/mod.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | let fields_variables: Vec = fields_named.named.iter().map(|field| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 66 | / quote! { [INFO] [stdout] 67 | | #( #fields_variables)* [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/mod.rs:48:43 [INFO] [stdout] | [INFO] [stdout] 42 | let field_attributes = &protocol(&field.attrs); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let update_hints = update_hints_after_read(field, &fields_named.named); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let update_hints_fixed = update_hint_fixed_length(field, &fields_named.named, field_attributes); [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | if let Some(skip_condition) = maybe_skip(field_attributes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `djin-protocol-derive` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "492c4620c59b9b2d6efa2b1d79dbca3c3bd68ff56548f808330c9f296b0760bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "492c4620c59b9b2d6efa2b1d79dbca3c3bd68ff56548f808330c9f296b0760bd", kill_on_drop: false }` [INFO] [stdout] 492c4620c59b9b2d6efa2b1d79dbca3c3bd68ff56548f808330c9f296b0760bd