[INFO] fetching crate dinglebit-store 1.1.0... [INFO] checking dinglebit-store-1.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate dinglebit-store 1.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate dinglebit-store 1.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dinglebit-store 1.1.0 [INFO] finished tweaking crates.io crate dinglebit-store 1.1.0 [INFO] tweaked toml for crates.io crate dinglebit-store 1.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 76 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (available: v0.10.4) [INFO] [stderr] Adding digest v0.9.0 (available: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding parking_lot v0.11.2 (available: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (available: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (available: v0.5.6) [INFO] [stderr] Adding sha2 v0.9.9 (available: v0.10.8) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6834f5324f031efc23aabf1e313a9ee8fa15e08aa9473fd221fbdcb6fedd185e [INFO] running `Command { std: "docker" "start" "-a" "6834f5324f031efc23aabf1e313a9ee8fa15e08aa9473fd221fbdcb6fedd185e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6834f5324f031efc23aabf1e313a9ee8fa15e08aa9473fd221fbdcb6fedd185e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6834f5324f031efc23aabf1e313a9ee8fa15e08aa9473fd221fbdcb6fedd185e", kill_on_drop: false }` [INFO] [stdout] 6834f5324f031efc23aabf1e313a9ee8fa15e08aa9473fd221fbdcb6fedd185e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bdbd26900720ddcf11033f362b106520756b2a06c0f3b369db6c83d24491de06 [INFO] running `Command { std: "docker" "start" "-a" "bdbd26900720ddcf11033f362b106520756b2a06c0f3b369db6c83d24491de06", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking dinglebit-store v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::result::Result, sled::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob.rs:202:15 [INFO] [stdout] | [INFO] [stdout] 174 | let mut f = match File::create(path.clone()) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | match self.db.insert(key, data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/blob.rs:240:33 [INFO] [stdout] | [INFO] [stdout] 240 | match self.db.remove(key.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dinglebit-store` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stdout] error: this value of type `std::result::Result, sled::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob.rs:202:15 [INFO] [stdout] | [INFO] [stdout] 174 | let mut f = match File::create(path.clone()) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | match self.db.insert(key, data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/blob.rs:240:33 [INFO] [stdout] | [INFO] [stdout] 240 | match self.db.remove(key.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dinglebit-store` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "bdbd26900720ddcf11033f362b106520756b2a06c0f3b369db6c83d24491de06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bdbd26900720ddcf11033f362b106520756b2a06c0f3b369db6c83d24491de06", kill_on_drop: false }` [INFO] [stdout] bdbd26900720ddcf11033f362b106520756b2a06c0f3b369db6c83d24491de06