[INFO] fetching crate ddi 0.2.1... [INFO] checking ddi-0.2.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate ddi 0.2.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ddi 0.2.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ddi 0.2.1 [INFO] finished tweaking crates.io crate ddi 0.2.1 [INFO] tweaked toml for crates.io crate ddi 0.2.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b2ef435a8a71f6cc1908f8885a284de8845d82a7470417c0943fdf70264dccb [INFO] running `Command { std: "docker" "start" "-a" "1b2ef435a8a71f6cc1908f8885a284de8845d82a7470417c0943fdf70264dccb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b2ef435a8a71f6cc1908f8885a284de8845d82a7470417c0943fdf70264dccb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b2ef435a8a71f6cc1908f8885a284de8845d82a7470417c0943fdf70264dccb", kill_on_drop: false }` [INFO] [stdout] 1b2ef435a8a71f6cc1908f8885a284de8845d82a7470417c0943fdf70264dccb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7fe9d4935124184826ca20efdac21b7cb4817f586214f95fe577ff5a7aa3c33f [INFO] running `Command { std: "docker" "start" "-a" "7fe9d4935124184826ca20efdac21b7cb4817f586214f95fe577ff5a7aa3c33f", kill_on_drop: false }` [INFO] [stderr] Checking ddi v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Entry<'_, K, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:489:19 [INFO] [stdout] | [INFO] [stdout] 486 | fn insert_with(&self, k: K, f: impl FnOnce() -> DDIResult) -> DDIResult<&V> { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 489 | match (*map).entry(k) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/lib.rs:644:13 [INFO] [stdout] | [INFO] [stdout] 644 | core::mem::drop(collection); [INFO] [stdout] | ^^^^^^^^^^^^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&ServiceCollection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 644 - core::mem::drop(collection); [INFO] [stdout] 644 + let _ = collection; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ddi` (lib test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Entry<'_, K, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:489:19 [INFO] [stdout] | [INFO] [stdout] 486 | fn insert_with(&self, k: K, f: impl FnOnce() -> DDIResult) -> DDIResult<&V> { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 489 | match (*map).entry(k) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/lib.rs:644:13 [INFO] [stdout] | [INFO] [stdout] 644 | core::mem::drop(collection); [INFO] [stdout] | ^^^^^^^^^^^^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&ServiceCollection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 644 - core::mem::drop(collection); [INFO] [stdout] 644 + let _ = collection; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ddi` (lib) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "7fe9d4935124184826ca20efdac21b7cb4817f586214f95fe577ff5a7aa3c33f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fe9d4935124184826ca20efdac21b7cb4817f586214f95fe577ff5a7aa3c33f", kill_on_drop: false }` [INFO] [stdout] 7fe9d4935124184826ca20efdac21b7cb4817f586214f95fe577ff5a7aa3c33f