[INFO] fetching crate db-core 0.2.1... [INFO] checking db-core-0.2.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate db-core 0.2.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate db-core 0.2.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate db-core 0.2.1 [INFO] finished tweaking crates.io crate db-core 0.2.1 [INFO] tweaked toml for crates.io crate db-core 0.2.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 77cf5a1b094c6ca81f88230cb51e4a07cdd80522e23e4b6c9036a8ac4f922168 [INFO] running `Command { std: "docker" "start" "-a" "77cf5a1b094c6ca81f88230cb51e4a07cdd80522e23e4b6c9036a8ac4f922168", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "77cf5a1b094c6ca81f88230cb51e4a07cdd80522e23e4b6c9036a8ac4f922168", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77cf5a1b094c6ca81f88230cb51e4a07cdd80522e23e4b6c9036a8ac4f922168", kill_on_drop: false }` [INFO] [stdout] 77cf5a1b094c6ca81f88230cb51e4a07cdd80522e23e4b6c9036a8ac4f922168 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 019f3b38638220bf361a03ad4678a3237e9d6ded0ee4856f1abc2e4d7fca52d9 [INFO] running `Command { std: "docker" "start" "-a" "019f3b38638220bf361a03ad4678a3237e9d6ded0ee4856f1abc2e4d7fca52d9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking db-core v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::log_mgr::io::LogRecordHeader` [INFO] [stdout] --> src/log_mgr/log_mgr.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub use crate::log_mgr::io::LogRecordHeader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:248:7 [INFO] [stdout] | [INFO] [stdout] 248 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:259:11 [INFO] [stdout] | [INFO] [stdout] 259 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:417:11 [INFO] [stdout] | [INFO] [stdout] 417 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:425:11 [INFO] [stdout] | [INFO] [stdout] 425 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:276:15 [INFO] [stdout] | [INFO] [stdout] 276 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:284:19 [INFO] [stdout] | [INFO] [stdout] 284 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:346:27 [INFO] [stdout] | [INFO] [stdout] 346 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:356:27 [INFO] [stdout] | [INFO] [stdout] 356 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:404:19 [INFO] [stdout] | [INFO] [stdout] 404 | #[cfg(feature = "metrics")] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:410:23 [INFO] [stdout] | [INFO] [stdout] 410 | #[cfg(not(feature = "metrics"))] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:579:19 [INFO] [stdout] | [INFO] [stdout] 579 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/system/instance.rs:141:104 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn open_write<'a>(&'a self, obj_id: &ObjectId, t: &'a mut Transaction, timeout: i64) -> Result { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/system/instance.rs:173:107 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn open_create<'a>(&'a self, file_id: u16, t: &'a mut Transaction, initial_size: usize) -> Result { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/block_mgr/block_mgr.rs:135:161 [INFO] [stdout] | [INFO] [stdout] 135 | ...ad<'b, T>(&'b self, block_id: &BlockId, init_fun: fn(BlockId, usize, Pinned<'b, BlockArea>) -> T, lock_type: usize) -> Result,... [INFO] [stdout] | -- lifetime `'b` declared here ^ this elided lifetime gets resolved as `'b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/block_mgr/block_mgr.rs:161:185 [INFO] [stdout] | [INFO] [stdout] 161 | ...te<'b, T>(&'b self, block_id: &BlockId, init_fun: fn(BlockId, usize, Pinned<'b, BlockArea>) -> T, try_lock: bool, lock_type: usize) -> Result,... [INFO] [stdout] | -- lifetime `'b` declared here ^ this elided lifetime gets resolved as `'b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/block_mgr/block.rs:64:31 [INFO] [stdout] | [INFO] [stdout] 58 | impl<'a, T> BlockLockedMut<'a, T> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 64 | pub fn immut(&'a self) -> &BlockLocked<'a, T> { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::alloc::LayoutErr`: Name does not follow std convention, use LayoutError [INFO] [stdout] --> src/common/errors.rs:219:17 [INFO] [stdout] | [INFO] [stdout] 219 | std::alloc::LayoutErr, IncorrectLayout, layout_err, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::alloc::LayoutErr`: Name does not follow std convention, use LayoutError [INFO] [stdout] --> src/common/errors.rs:209:79 [INFO] [stdout] | [INFO] [stdout] 209 | IncorrectLayout , incorrect_layout , std::alloc::LayoutErr, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/common/intercom.rs:202:33 [INFO] [stdout] | [INFO] [stdout] 202 | core::sync::atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/log_mgr/buf.rs:112:52 [INFO] [stdout] | [INFO] [stdout] 112 | let cur_acq_size = self.acquire_size.0.compare_and_swap( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/log_mgr/buf.rs:182:52 [INFO] [stdout] | [INFO] [stdout] 182 | let cur_acq_size = self.acquire_size.0.compare_and_swap( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buf_mgr/buf_mgr.rs:222:33 [INFO] [stdout] | [INFO] [stdout] 220 | let mut block_map = self.block_map.write().unwrap(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | [INFO] [stdout] 222 | if let Some(mut item) = self.get_free_block(&mut block_map) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, Arc>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buf_mgr/buf_writer.rs:103:28 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn terminate(self) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | if let Ok(waker) = Arc::try_unwrap(self.waker) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, Arc>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_mgr/fs.rs:198:25 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn terminate(self) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | if let Ok(jh) = Arc::try_unwrap(self.writer_thread) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/datastore.rs:445:29 [INFO] [stdout] | [INFO] [stdout] 445 | fn add_fi_blocks(&self, mut block_id: &mut BlockId, fi_block_num: usize, stub_pin: &AtomicU64, f: &std::fs::File) -> Result<(), Error> { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/datastore.rs:863:13 [INFO] [stdout] | [INFO] [stdout] 863 | let mut desc = xlock.get_mut(&file_id).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/datastore.rs:869:13 [INFO] [stdout] | [INFO] [stdout] 869 | let mut desc = xlock.get_mut(&file_id).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/block_driver.rs:731:26 [INFO] [stdout] | [INFO] [stdout] 731 | pub fn replay(&self, mut rs: &mut ReplayState, data: &[u8]) -> Result<(), Error> { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/system/instance.rs:360:35 [INFO] [stdout] | [INFO] [stdout] 346 | pub fn terminate(self) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | if let Ok(checkpointer) = Arc::try_unwrap(checkpointer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/system/checkpointer.rs:129:15 [INFO] [stdout] | [INFO] [stdout] 124 | log_mgr: LogMgr, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | tran_mgr: TranMgr) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | { [INFO] [stdout] 129 | match StorageDriver::new(conf, csns.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(Pinned<'_, BlockArea>, usize)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mgr/block_mgr.rs:141:40 [INFO] [stdout] | [INFO] [stdout] 139 | let lock_holder = RwLockGuard::Read(self.locks[lid].read().unwrap()); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | [INFO] [stdout] 141 | if let Some((data, buf_idx)) = self.buf_mgr.get_block(&block_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(Pinned<'_, BlockArea>, usize)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mgr/block_mgr.rs:171:40 [INFO] [stdout] | [INFO] [stdout] 165 | let lock_holder = if try_lock { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | if let Some((data, buf_idx)) = self.buf_mgr.get_block(&block_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mgr/block_mgr.rs:225:29 [INFO] [stdout] | [INFO] [stdout] 224 | let lock_holder = RwLockGuard::Write(self.locks[lid].write().unwrap()); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | if let Some(data) = self.buf_mgr.get_block_by_idx(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `write_ready` is never read [INFO] [stdout] --> src/buf_mgr/buf_writer.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct BufWriter { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | write_ready: SyncNotification, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BufWriter` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Metrics` is never constructed [INFO] [stdout] --> src/log_mgr/buf.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 243 | pub struct Metrics { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Metrics` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_extent_bit` is never used [INFO] [stdout] --> src/block_mgr/free_info.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl FreeInfo { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 121 | pub fn set_extent_bit(&self, file_id: u16, extent_id: u16, set: bool) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `used_iter` is never used [INFO] [stdout] --> src/block_mgr/free_info.rs:321:12 [INFO] [stdout] | [INFO] [stdout] 305 | impl FiData { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 321 | pub fn used_iter(&self) -> FiDataIter { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/block_mgr/block.rs:25:10 [INFO] [stdout] | [INFO] [stdout] 25 | Read(RwLockReadGuard<'a, ()>), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 25 | Read(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/block_mgr/block.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | Write(RwLockWriteGuard<'a, ()>), [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 26 | Write(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_crc` is never used [INFO] [stdout] --> src/block_mgr/block.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 86 | pub trait BasicBlock { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 87 | [INFO] [stdout] 88 | fn get_crc(&self) -> u32; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `delete_entry` is never used [INFO] [stdout] --> src/block_mgr/block.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 131 | impl<'a> DataBlock<'a> { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 276 | pub fn delete_entry(&mut self, entry_id: u16) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `mark_extent_full` and `set_free_info_free` are never used [INFO] [stdout] --> src/block_mgr/allocator.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 37 | impl BlockAllocator { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 93 | pub fn mark_extent_full(&self, file_id: u16, extent_id: u16) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 127 | pub fn set_free_info_free(&self, block_id: &BlockId) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/storage/datastore.rs:764:9 [INFO] [stdout] | [INFO] [stdout] 764 | drop(v); [INFO] [stdout] | ^^^^^-^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `()` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 764 - drop(v); [INFO] [stdout] 764 + let _ = v; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 37 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `db-core` (lib) due to 9 previous errors; 37 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "019f3b38638220bf361a03ad4678a3237e9d6ded0ee4856f1abc2e4d7fca52d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "019f3b38638220bf361a03ad4678a3237e9d6ded0ee4856f1abc2e4d7fca52d9", kill_on_drop: false }` [INFO] [stdout] 019f3b38638220bf361a03ad4678a3237e9d6ded0ee4856f1abc2e4d7fca52d9