[INFO] fetching crate datafusion-physical-optimizer 42.0.0... [INFO] checking datafusion-physical-optimizer-42.0.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate datafusion-physical-optimizer 42.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate datafusion-physical-optimizer 42.0.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate datafusion-physical-optimizer 42.0.0 [INFO] finished tweaking crates.io crate datafusion-physical-optimizer 42.0.0 [INFO] tweaked toml for crates.io crate datafusion-physical-optimizer 42.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 195 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding chrono-tz v0.9.0 (available: v0.10.0) [INFO] [stderr] Adding chrono-tz-build v0.3.0 (available: v0.4.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (available: v0.5.7) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding lexical-core v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-integer v0.8.6 (available: v1.0.2) [INFO] [stderr] Adding lexical-util v0.8.5 (available: v1.0.3) [INFO] [stderr] Adding lexical-write-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-write-integer v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding sqlparser v0.50.0 (available: v0.51.0) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 155d5691681a704a0e55c12baee0664e20e20524fdbbad811d146f578cb47ea5 [INFO] running `Command { std: "docker" "start" "-a" "155d5691681a704a0e55c12baee0664e20e20524fdbbad811d146f578cb47ea5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "155d5691681a704a0e55c12baee0664e20e20524fdbbad811d146f578cb47ea5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "155d5691681a704a0e55c12baee0664e20e20524fdbbad811d146f578cb47ea5", kill_on_drop: false }` [INFO] [stdout] 155d5691681a704a0e55c12baee0664e20e20524fdbbad811d146f578cb47ea5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b9d78d045e709e7cc8fbe91d1ef6fe29c4e29b38ef251bee2ba9ec870fb40277 [INFO] running `Command { std: "docker" "start" "-a" "b9d78d045e709e7cc8fbe91d1ef6fe29c4e29b38ef251bee2ba9ec870fb40277", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking arrow-schema v53.0.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v53.0.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking arrow-data v53.0.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling sqlparser_derive v0.2.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling snafu-derive v0.8.5 [INFO] [stderr] Checking sqlparser v0.50.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking snafu v0.8.5 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking datafusion-common-runtime v42.0.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking object_store v0.11.0 [INFO] [stderr] Checking arrow-array v53.0.0 [INFO] [stderr] Checking arrow-select v53.0.0 [INFO] [stderr] Checking arrow-arith v53.0.0 [INFO] [stderr] Checking arrow-row v53.0.0 [INFO] [stderr] Checking arrow-cast v53.0.0 [INFO] [stderr] Checking arrow-ord v53.0.0 [INFO] [stderr] Checking arrow-string v53.0.0 [INFO] [stderr] Checking arrow-csv v53.0.0 [INFO] [stderr] Checking arrow-ipc v53.0.0 [INFO] [stderr] Checking arrow-json v53.0.0 [INFO] [stderr] Checking arrow v53.0.0 [INFO] [stderr] Checking datafusion-common v42.0.0 [INFO] [stderr] Checking datafusion-expr-common v42.0.0 [INFO] [stderr] Checking datafusion-physical-expr-common v42.0.0 [INFO] [stderr] Checking datafusion-functions-aggregate-common v42.0.0 [INFO] [stderr] Checking datafusion-expr v42.0.0 [INFO] [stderr] Checking datafusion-execution v42.0.0 [INFO] [stderr] Checking datafusion-physical-expr v42.0.0 [INFO] [stderr] Checking datafusion-functions-aggregate v42.0.0 [INFO] [stderr] Checking datafusion-physical-plan v42.0.0 [INFO] [stderr] Checking datafusion-physical-optimizer v42.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aggregate_statistics.rs:52:41 [INFO] [stdout] | [INFO] [stdout] 49 | plan: Arc, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | if let Some(partial_agg_exec) = take_optimizable(&*plan) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/limited_distinct_aggregation.rs:169:25 [INFO] [stdout] | [INFO] [stdout] 166 | plan.transform_down(|plan| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | LimitedDistinctAggregation::transform_limit(plan.to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topk_aggregation.rs:145:40 [INFO] [stdout] | [INFO] [stdout] 144 | plan.transform_down(|plan| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Ok(if let Some(plan) = TopKAggregation::transform_sort(&plan) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `datafusion-physical-optimizer` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aggregate_statistics.rs:52:41 [INFO] [stdout] | [INFO] [stdout] 49 | plan: Arc, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | if let Some(partial_agg_exec) = take_optimizable(&*plan) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/limited_distinct_aggregation.rs:169:25 [INFO] [stdout] | [INFO] [stdout] 166 | plan.transform_down(|plan| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | LimitedDistinctAggregation::transform_limit(plan.to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topk_aggregation.rs:145:40 [INFO] [stdout] | [INFO] [stdout] 144 | plan.transform_down(|plan| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Ok(if let Some(plan) = TopKAggregation::transform_sort(&plan) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `datafusion-physical-optimizer` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "b9d78d045e709e7cc8fbe91d1ef6fe29c4e29b38ef251bee2ba9ec870fb40277", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9d78d045e709e7cc8fbe91d1ef6fe29c4e29b38ef251bee2ba9ec870fb40277", kill_on_drop: false }` [INFO] [stdout] b9d78d045e709e7cc8fbe91d1ef6fe29c4e29b38ef251bee2ba9ec870fb40277