[INFO] fetching crate datafusion-expr 42.0.0... [INFO] checking datafusion-expr-42.0.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate datafusion-expr 42.0.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate datafusion-expr 42.0.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate datafusion-expr 42.0.0 [INFO] finished tweaking crates.io crate datafusion-expr 42.0.0 [INFO] tweaked toml for crates.io crate datafusion-expr 42.0.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 151 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding chrono-tz v0.9.0 (available: v0.10.0) [INFO] [stderr] Adding chrono-tz-build v0.3.0 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding lexical-core v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-integer v0.8.6 (available: v1.0.2) [INFO] [stderr] Adding lexical-util v0.8.5 (available: v1.0.3) [INFO] [stderr] Adding lexical-write-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-write-integer v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding sqlparser v0.50.0 (available: v0.51.0) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 30c98887541be7c6540547a03138eeed160b2f222736af39bb7f837baabf9b3c [INFO] running `Command { std: "docker" "start" "-a" "30c98887541be7c6540547a03138eeed160b2f222736af39bb7f837baabf9b3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "30c98887541be7c6540547a03138eeed160b2f222736af39bb7f837baabf9b3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30c98887541be7c6540547a03138eeed160b2f222736af39bb7f837baabf9b3c", kill_on_drop: false }` [INFO] [stdout] 30c98887541be7c6540547a03138eeed160b2f222736af39bb7f837baabf9b3c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb120485e578172f69a52d5c3fc641f4a3213c148a75fa5676d78ed1fc394fc2 [INFO] running `Command { std: "docker" "start" "-a" "fb120485e578172f69a52d5c3fc641f4a3213c148a75fa5676d78ed1fc394fc2", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking arrow-schema v53.0.0 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking arrow-buffer v53.0.0 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Checking arrow-data v53.0.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling sqlparser_derive v0.2.2 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling ctor v0.2.8 [INFO] [stderr] Checking sqlparser v0.50.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking arrow-array v53.0.0 [INFO] [stderr] Checking arrow-select v53.0.0 [INFO] [stderr] Checking arrow-row v53.0.0 [INFO] [stderr] Checking arrow-arith v53.0.0 [INFO] [stderr] Checking arrow-cast v53.0.0 [INFO] [stderr] Checking arrow-string v53.0.0 [INFO] [stderr] Checking arrow-ord v53.0.0 [INFO] [stderr] Checking arrow-csv v53.0.0 [INFO] [stderr] Checking arrow-json v53.0.0 [INFO] [stderr] Checking arrow-ipc v53.0.0 [INFO] [stderr] Checking arrow v53.0.0 [INFO] [stderr] Checking datafusion-common v42.0.0 [INFO] [stderr] Checking datafusion-expr-common v42.0.0 [INFO] [stderr] Checking datafusion-physical-expr-common v42.0.0 [INFO] [stderr] Checking datafusion-functions-aggregate-common v42.0.0 [INFO] [stderr] Checking datafusion-expr v42.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `plan::LogicalPlan` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logical_plan/plan.rs:918:22 [INFO] [stdout] | [INFO] [stdout] 801 | mut expr: Vec, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 802 | inputs: Vec, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 918 | let (left, right) = self.only_two_inputs(inputs)?; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `plan::LogicalPlan` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logical_plan/plan.rs:918:22 [INFO] [stdout] | [INFO] [stdout] 801 | mut expr: Vec, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 802 | inputs: Vec, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 918 | let (left, right) = self.only_two_inputs(inputs)?; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `datafusion-expr` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `datafusion-expr` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "fb120485e578172f69a52d5c3fc641f4a3213c148a75fa5676d78ed1fc394fc2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb120485e578172f69a52d5c3fc641f4a3213c148a75fa5676d78ed1fc394fc2", kill_on_drop: false }` [INFO] [stdout] fb120485e578172f69a52d5c3fc641f4a3213c148a75fa5676d78ed1fc394fc2