[INFO] fetching crate dark_iron_ecs 0.7.0... [INFO] checking dark_iron_ecs-0.7.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate dark_iron_ecs 0.7.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate dark_iron_ecs 0.7.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dark_iron_ecs 0.7.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate dark_iron_ecs 0.7.0 [INFO] tweaked toml for crates.io crate dark_iron_ecs 0.7.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate dark_iron_ecs 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 05a74ec4882f6cae54d47bcab2a9ba947bb808c84d7807676feb15afbb03c73f [INFO] running `Command { std: "docker" "start" "-a" "05a74ec4882f6cae54d47bcab2a9ba947bb808c84d7807676feb15afbb03c73f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "05a74ec4882f6cae54d47bcab2a9ba947bb808c84d7807676feb15afbb03c73f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05a74ec4882f6cae54d47bcab2a9ba947bb808c84d7807676feb15afbb03c73f", kill_on_drop: false }` [INFO] [stdout] 05a74ec4882f6cae54d47bcab2a9ba947bb808c84d7807676feb15afbb03c73f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 32e3b05baffd41767d40ac2a3a192b82628f4cb88c774aca1b609e6156131f8f [INFO] running `Command { std: "docker" "start" "-a" "32e3b05baffd41767d40ac2a3a192b82628f4cb88c774aca1b609e6156131f8f", kill_on_drop: false }` [INFO] [stderr] Checking dark_iron_ecs v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/core/world.rs:77:67 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn create_query<'a, T: QueryParams<'a>>(&'a self) -> Query { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/core/world.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn create_query_with_constraint<'a, T: QueryParams<'a>, C: QueryConstraint>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 84 | &'a self, [INFO] [stdout] 85 | ) -> Query { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/core/world.rs:77:67 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn create_query<'a, T: QueryParams<'a>>(&'a self) -> Query { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/core/world.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn create_query_with_constraint<'a, T: QueryParams<'a>, C: QueryConstraint>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 84 | &'a self, [INFO] [stdout] 85 | ) -> Query { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/coroutine.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 125 | coordinator: std::rc::Rc>, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | ) -> Self { [INFO] [stdout] 127 | unsafe { &(*coordinator.borrow().get_coroutine_manager()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/coroutine.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 133 | coordinator: std::rc::Rc>, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | ) -> Self { [INFO] [stdout] 135 | unsafe { &mut (*coordinator.borrow().get_coroutine_manager_mut()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/entity_manager.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 18 | coordinator: std::rc::Rc>, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | ) -> Self { [INFO] [stdout] 20 | unsafe { &*coordinator.borrow().get_entity_manager() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/entity_manager.rs:28:24 [INFO] [stdout] | [INFO] [stdout] 26 | coordinator: std::rc::Rc>, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Self { [INFO] [stdout] 28 | unsafe { &mut *coordinator.borrow().get_entity_manager_mut() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/coroutine.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 125 | coordinator: std::rc::Rc>, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | ) -> Self { [INFO] [stdout] 127 | unsafe { &(*coordinator.borrow().get_coroutine_manager()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/coroutine.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 133 | coordinator: std::rc::Rc>, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | ) -> Self { [INFO] [stdout] 135 | unsafe { &mut (*coordinator.borrow().get_coroutine_manager_mut()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/entity_manager.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 18 | coordinator: std::rc::Rc>, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | ) -> Self { [INFO] [stdout] 20 | unsafe { &*coordinator.borrow().get_entity_manager() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/entity_manager.rs:28:24 [INFO] [stdout] | [INFO] [stdout] 26 | coordinator: std::rc::Rc>, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Self { [INFO] [stdout] 28 | unsafe { &mut *coordinator.borrow().get_entity_manager_mut() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/event.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 82 | fn get_param(coordinator: Rc>) -> Self { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | unsafe { &(*coordinator.borrow().get_event_manager()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/event.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 88 | fn get_param(coordinator: Rc>) -> Self { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | unsafe { &mut (*coordinator.borrow().get_event_manager_mut()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/event.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 82 | fn get_param(coordinator: Rc>) -> Self { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | unsafe { &(*coordinator.borrow().get_event_manager()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/event.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 88 | fn get_param(coordinator: Rc>) -> Self { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | unsafe { &mut (*coordinator.borrow().get_event_manager_mut()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/resources.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 119 | fn get_param(coordinator: Rc>) -> Self { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | unsafe { &(*coordinator.borrow().get_resource_manager()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/resources.rs:126:25 [INFO] [stdout] | [INFO] [stdout] 125 | fn get_param(coordinator: Rc>) -> Self { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | unsafe { &mut (*coordinator.borrow().get_resource_manager_mut()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/resources.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 119 | fn get_param(coordinator: Rc>) -> Self { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | unsafe { &(*coordinator.borrow().get_resource_manager()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/resources.rs:126:25 [INFO] [stdout] | [INFO] [stdout] 125 | fn get_param(coordinator: Rc>) -> Self { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | unsafe { &mut (*coordinator.borrow().get_resource_manager_mut()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/system.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 126 | fn get_param(world: Rc>) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | unsafe { &(*world.borrow().get_system_manager()) } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, Coordinator>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/system.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 126 | fn get_param(world: Rc>) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | unsafe { &(*world.borrow().get_system_manager()) } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dark_iron_ecs` (lib) due to 10 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `dark_iron_ecs` (lib test) due to 10 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "32e3b05baffd41767d40ac2a3a192b82628f4cb88c774aca1b609e6156131f8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32e3b05baffd41767d40ac2a3a192b82628f4cb88c774aca1b609e6156131f8f", kill_on_drop: false }` [INFO] [stdout] 32e3b05baffd41767d40ac2a3a192b82628f4cb88c774aca1b609e6156131f8f