[INFO] fetching crate cultivar 0.2.1... [INFO] checking cultivar-0.2.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate cultivar 0.2.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate cultivar 0.2.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cultivar 0.2.1 [INFO] finished tweaking crates.io crate cultivar 0.2.1 [INFO] tweaked toml for crates.io crate cultivar 0.2.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate cultivar 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5b5d80c38222275fb57bfb52898448e8d4befc8230fcdb4bb24aaefcdd96be3 [INFO] running `Command { std: "docker" "start" "-a" "f5b5d80c38222275fb57bfb52898448e8d4befc8230fcdb4bb24aaefcdd96be3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5b5d80c38222275fb57bfb52898448e8d4befc8230fcdb4bb24aaefcdd96be3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5b5d80c38222275fb57bfb52898448e8d4befc8230fcdb4bb24aaefcdd96be3", kill_on_drop: false }` [INFO] [stdout] f5b5d80c38222275fb57bfb52898448e8d4befc8230fcdb4bb24aaefcdd96be3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7712bb91b6ea9f594de364eb7009621166403705f3c22a69b0704aaeaf12dab2 [INFO] running `Command { std: "docker" "start" "-a" "7712bb91b6ea9f594de364eb7009621166403705f3c22a69b0704aaeaf12dab2", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.206 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling serde_derive v1.0.206 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking cultivar v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Child` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub(crate) fn run_command + Clone, I>(cmd: S, args: I) -> Result [INFO] [stdout] | --- ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | / Command::new(cmd.to_owned()) [INFO] [stdout] 27 | | .args(args.to_owned()) [INFO] [stdout] 28 | | .spawn() [INFO] [stdout] 29 | | .map_err(|e| { [INFO] [stdout] ... | [INFO] [stdout] 33 | | ) [INFO] [stdout] 34 | | })? [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `args` is never read [INFO] [stdout] --> src/cultivation.rs:55:14 [INFO] [stdout] | [INFO] [stdout] 49 | pub(crate) struct Test [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 55 | pub(crate) args: ValueMap, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Unimplemented` is never constructed [INFO] [stdout] --> src/error.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 4 | pub(crate) enum Error [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 10 | Unimplemented(&'static str), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cultivar` (bin "cultivar") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Child` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub(crate) fn run_command + Clone, I>(cmd: S, args: I) -> Result [INFO] [stdout] | --- ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | / Command::new(cmd.to_owned()) [INFO] [stdout] 27 | | .args(args.to_owned()) [INFO] [stdout] 28 | | .spawn() [INFO] [stdout] 29 | | .map_err(|e| { [INFO] [stdout] ... | [INFO] [stdout] 33 | | ) [INFO] [stdout] 34 | | })? [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `args` is never read [INFO] [stdout] --> src/cultivation.rs:55:14 [INFO] [stdout] | [INFO] [stdout] 49 | pub(crate) struct Test [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 55 | pub(crate) args: ValueMap, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Unimplemented` is never constructed [INFO] [stdout] --> src/error.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 4 | pub(crate) enum Error [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 10 | Unimplemented(&'static str), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cultivar` (bin "cultivar" test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7712bb91b6ea9f594de364eb7009621166403705f3c22a69b0704aaeaf12dab2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7712bb91b6ea9f594de364eb7009621166403705f3c22a69b0704aaeaf12dab2", kill_on_drop: false }` [INFO] [stdout] 7712bb91b6ea9f594de364eb7009621166403705f3c22a69b0704aaeaf12dab2