[INFO] fetching crate cueball 0.3.5... [INFO] checking cueball-0.3.5 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate cueball 0.3.5 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate cueball 0.3.5 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cueball 0.3.5 [INFO] finished tweaking crates.io crate cueball 0.3.5 [INFO] tweaked toml for crates.io crate cueball 0.3.5 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate cueball 0.3.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 97443cc2ae6c01a1ebd2da562eae3db1a65b7f40bf4168c35b6956888e790701 [INFO] running `Command { std: "docker" "start" "-a" "97443cc2ae6c01a1ebd2da562eae3db1a65b7f40bf4168c35b6956888e790701", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "97443cc2ae6c01a1ebd2da562eae3db1a65b7f40bf4168c35b6956888e790701", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97443cc2ae6c01a1ebd2da562eae3db1a65b7f40bf4168c35b6956888e790701", kill_on_drop: false }` [INFO] [stdout] 97443cc2ae6c01a1ebd2da562eae3db1a65b7f40bf4168c35b6956888e790701 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c3b2bba334d50d495333044daae5d0d9e9e633c832b2c501e9d75b01eaf19338 [INFO] running `Command { std: "docker" "start" "-a" "c3b2bba334d50d495333044daae5d0d9e9e633c832b2c501e9d75b01eaf19338", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling slog v2.5.2 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Checking arc-swap v0.4.6 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking crossbeam v0.2.12 [INFO] [stderr] Checking instant v0.1.3 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking sha1 v0.6.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking slog-scope v4.3.0 [INFO] [stderr] Checking slog-stdlog v3.0.5 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking backoff v0.1.6 [INFO] [stderr] Checking timer v0.2.0 [INFO] [stderr] Checking slog-term v2.5.0 [INFO] [stderr] Compiling derive_more v0.14.1 [INFO] [stderr] Checking cueball v0.3.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/connection_pool.rs:530:13 [INFO] [stdout] | [INFO] [stdout] 530 | let mut connection_data = connection_data_guard.deref_mut(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/connection_pool.rs:530:13 [INFO] [stdout] | [INFO] [stdout] 530 | let mut connection_data = connection_data_guard.deref_mut(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), ::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection_pool.rs:736:23 [INFO] [stdout] | [INFO] [stdout] 731 | fn close_connection(log: Logger, key: BackendKey, mut conn: C) [INFO] [stdout] | --- -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 736 | if let Err(err) = conn.close() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), ::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection_pool.rs:736:23 [INFO] [stdout] | [INFO] [stdout] 731 | fn close_connection(log: Logger, key: BackendKey, mut conn: C) [INFO] [stdout] | --- -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 736 | if let Err(err) = conn.close() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cueball` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cueball` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c3b2bba334d50d495333044daae5d0d9e9e633c832b2c501e9d75b01eaf19338", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3b2bba334d50d495333044daae5d0d9e9e633c832b2c501e9d75b01eaf19338", kill_on_drop: false }` [INFO] [stdout] c3b2bba334d50d495333044daae5d0d9e9e633c832b2c501e9d75b01eaf19338