[INFO] fetching crate criticaltrust 0.4.0... [INFO] checking criticaltrust-0.4.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate criticaltrust 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate criticaltrust 0.4.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate criticaltrust 0.4.0 [INFO] finished tweaking crates.io crate criticaltrust 0.4.0 [INFO] tweaked toml for crates.io crate criticaltrust 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 167 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding h2 v0.3.26 (available: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (available: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (available: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (available: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.24.2 (available: v0.27.3) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding rustls v0.21.12 (available: v0.23.13) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (available: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (available: v0.102.8) [INFO] [stderr] Adding security-framework v2.11.1 (available: v3.0.0) [INFO] [stderr] Adding tokio-rustls v0.24.1 (available: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d8c430d63d002c2088daf83d2f7e38b35013dc2f4fd2abafe839319d14797bce [INFO] running `Command { std: "docker" "start" "-a" "d8c430d63d002c2088daf83d2f7e38b35013dc2f4fd2abafe839319d14797bce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d8c430d63d002c2088daf83d2f7e38b35013dc2f4fd2abafe839319d14797bce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8c430d63d002c2088daf83d2f7e38b35013dc2f4fd2abafe839319d14797bce", kill_on_drop: false }` [INFO] [stdout] d8c430d63d002c2088daf83d2f7e38b35013dc2f4fd2abafe839319d14797bce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87689e9589f8d2efdf3b9469cbea19309783fa166f58a04c21619c60bc43df63 [INFO] running `Command { std: "docker" "start" "-a" "87689e9589f8d2efdf3b9469cbea19309783fa166f58a04c21619c60bc43df63", kill_on_drop: false }` [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking criticaltrust v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Zeroizing>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keys/algorithms/ecdsa_p256_sha256_asn1_spki_der.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 46 | let key = SecretKey::random(&mut rand_core::OsRng); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Ok(PrivateKeyBytes::owned( [INFO] [stdout] 48 | / key.to_pkcs8_der() [INFO] [stdout] 49 | | .expect("generated private key cannot be encoded") [INFO] [stdout] 50 | | .to_bytes() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signatures/payload.rs:86:37 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn into_verified(self, keys: &dyn PublicKeysRepository) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | if let Some(deserialized) = self.verified_deserialized.into_inner() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Zeroizing>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keys/algorithms/ecdsa_p256_sha256_asn1_spki_der.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 46 | let key = SecretKey::random(&mut rand_core::OsRng); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Ok(PrivateKeyBytes::owned( [INFO] [stdout] 48 | / key.to_pkcs8_der() [INFO] [stdout] 49 | | .expect("generated private key cannot be encoded") [INFO] [stdout] 50 | | .to_bytes() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `criticaltrust` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signatures/payload.rs:86:37 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn into_verified(self, keys: &dyn PublicKeysRepository) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | if let Some(deserialized) = self.verified_deserialized.into_inner() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `criticaltrust` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "87689e9589f8d2efdf3b9469cbea19309783fa166f58a04c21619c60bc43df63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87689e9589f8d2efdf3b9469cbea19309783fa166f58a04c21619c60bc43df63", kill_on_drop: false }` [INFO] [stdout] 87689e9589f8d2efdf3b9469cbea19309783fa166f58a04c21619c60bc43df63