[INFO] fetching crate cpclib-basic 0.8.1... [INFO] checking cpclib-basic-0.8.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate cpclib-basic 0.8.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate cpclib-basic 0.8.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cpclib-basic 0.8.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate cpclib-basic 0.8.1 [INFO] tweaked toml for crates.io crate cpclib-basic 0.8.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate cpclib-basic 0.8.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc08baba2a539421c57a402033f9609a4290c623e22c6ccc474351d0d654f58d [INFO] running `Command { std: "docker" "start" "-a" "dc08baba2a539421c57a402033f9609a4290c623e22c6ccc474351d0d654f58d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc08baba2a539421c57a402033f9609a4290c623e22c6ccc474351d0d654f58d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc08baba2a539421c57a402033f9609a4290c623e22c6ccc474351d0d654f58d", kill_on_drop: false }` [INFO] [stdout] dc08baba2a539421c57a402033f9609a4290c623e22c6ccc474351d0d654f58d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0984caebc23a614836f37bf6c7b5f3096321cd1dd3762a5bbd04ba513ede8a32 [INFO] running `Command { std: "docker" "start" "-a" "0984caebc23a614836f37bf6c7b5f3096321cd1dd3762a5bbd04ba513ede8a32", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling iana-time-zone v0.1.60 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking resolve-path v0.1.0 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking bitfield v0.14.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Compiling chrono v0.4.38 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling built v0.7.4 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Compiling cpclib-sna v0.8.2 [INFO] [stderr] Compiling cpclib-basic v0.8.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking cpclib-common v0.8.1 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling delegate v0.12.0 [INFO] [stderr] Compiling num_enum_derive v0.7.3 [INFO] [stderr] Checking num_enum v0.7.3 [INFO] [stderr] Checking serde v1.0.204 [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/string_parser.rs:87:6 [INFO] [stdout] | [INFO] [stdout] 87 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/string_parser.rs:87:6 [INFO] [stdout] | [INFO] [stdout] 87 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `cpclib_common::winnow::Parser::recognize`: Replaced with `Parser::take` [INFO] [stdout] --> src/string_parser.rs:919:10 [INFO] [stdout] | [INFO] [stdout] 919 | .recognize() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `cpclib_common::winnow::Parser::recognize`: Replaced with `Parser::take` [INFO] [stdout] --> src/string_parser.rs:919:10 [INFO] [stdout] | [INFO] [stdout] 919 | .recognize() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ParserError` [INFO] [stdout] --> src/string_parser.rs:6:50 [INFO] [stdout] | [INFO] [stdout] 6 | use cpclib_common::winnow::error::{ContextError, ParserError, StrContext}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ParserError` [INFO] [stdout] --> src/string_parser.rs:6:50 [INFO] [stdout] | [INFO] [stdout] 6 | use cpclib_common::winnow::error::{ContextError, ParserError, StrContext}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `mantissa` is never read [INFO] [stdout] --> src/string_parser.rs:811:13 [INFO] [stdout] | [INFO] [stdout] 811 | let mut mantissa: u64 = 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `mask` is never read [INFO] [stdout] --> src/string_parser.rs:812:13 [INFO] [stdout] | [INFO] [stdout] 812 | let mut mask: u64 = 0x80000000; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `mantissa` is never read [INFO] [stdout] --> src/string_parser.rs:811:13 [INFO] [stdout] | [INFO] [stdout] 811 | let mut mantissa: u64 = 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `mask` is never read [INFO] [stdout] --> src/string_parser.rs:812:13 [INFO] [stdout] | [INFO] [stdout] 812 | let mut mask: u64 = 0x80000000; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `cpclib_common::winnow::error::ParseError<&str, ContextError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string_parser.rs:1049:17 [INFO] [stdout] | [INFO] [stdout] 1043 | let res = parse_basic_line.parse(&mut &code); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1049 | Err(e) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `cpclib_common::winnow::error::ParseError<&str, ContextError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string_parser.rs:1061:17 [INFO] [stdout] | [INFO] [stdout] 1056 | let res = parse_instruction.parse(&mut &code); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1061 | Err(e) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `cpclib_common::winnow::error::ParseError<&str, ContextError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string_parser.rs:1088:17 [INFO] [stdout] | [INFO] [stdout] 1083 | let res = parse_numeric_expression(NumericExpressionConstraint::None).parse(&mut &code); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1088 | Err(e) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `cpclib_common::winnow::error::ParseError<&str, ContextError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string_parser.rs:1100:17 [INFO] [stdout] | [INFO] [stdout] 1095 | let res = parse_print_expression.parse(&mut &code); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1100 | Err(e) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:170:13 [INFO] [stdout] | [INFO] [stdout] 170 | _ => unreachable!() [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/lib.rs:170:13 [INFO] [stdout] | [INFO] [stdout] 163 | Ok((prog, _)) => Ok(prog), [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] 164 | Err(e) => { [INFO] [stdout] | ------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 170 | _ => unreachable!() [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(BasicProgram, &str), cpclib_common::winnow::error::ParseError<&str, ContextError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:162:15 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn parse>(code: S) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let input = code.as_ref(); [INFO] [stdout] 162 | match (parse_basic_program, space0).parse(&mut &input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:170:13 [INFO] [stdout] | [INFO] [stdout] 170 | _ => unreachable!() [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/lib.rs:170:13 [INFO] [stdout] | [INFO] [stdout] 163 | Ok((prog, _)) => Ok(prog), [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] 164 | Err(e) => { [INFO] [stdout] | ------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 170 | _ => unreachable!() [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(BasicProgram, &str), cpclib_common::winnow::error::ParseError<&str, ContextError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:162:15 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn parse>(code: S) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let input = code.as_ref(); [INFO] [stdout] 162 | match (parse_basic_program, space0).parse(&mut &input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cpclib-basic` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `check_token_tokenisation` is never used [INFO] [stdout] --> src/string_parser.rs:1055:8 [INFO] [stdout] | [INFO] [stdout] 1055 | fn check_token_tokenisation(code: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cpclib-basic` (lib test) due to 6 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0984caebc23a614836f37bf6c7b5f3096321cd1dd3762a5bbd04ba513ede8a32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0984caebc23a614836f37bf6c7b5f3096321cd1dd3762a5bbd04ba513ede8a32", kill_on_drop: false }` [INFO] [stdout] 0984caebc23a614836f37bf6c7b5f3096321cd1dd3762a5bbd04ba513ede8a32