[INFO] fetching crate core_cbc_casper 0.1.0... [INFO] checking core_cbc_casper-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate core_cbc_casper 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate core_cbc_casper 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate core_cbc_casper 0.1.0 [INFO] finished tweaking crates.io crate core_cbc_casper 0.1.0 [INFO] tweaked toml for crates.io crate core_cbc_casper 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate core_cbc_casper 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc7b4f42abafe3f162b0fccd6bba5eca0a0ace415f80480cd810f33a765d7463 [INFO] running `Command { std: "docker" "start" "-a" "cc7b4f42abafe3f162b0fccd6bba5eca0a0ace415f80480cd810f33a765d7463", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc7b4f42abafe3f162b0fccd6bba5eca0a0ace415f80480cd810f33a765d7463", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc7b4f42abafe3f162b0fccd6bba5eca0a0ace415f80480cd810f33a765d7463", kill_on_drop: false }` [INFO] [stdout] cc7b4f42abafe3f162b0fccd6bba5eca0a0ace415f80480cd810f33a765d7463 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e302d8604ef9cb82bd82485b0f51095cf683ab45787721d2a0722fb515ef1ce [INFO] running `Command { std: "docker" "start" "-a" "2e302d8604ef9cb82bd82485b0f51095cf683ab45787721d2a0722fb515ef1ce", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling syn v1.0.8 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking constant_time_eq v0.1.4 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking itertools v0.8.1 [INFO] [stderr] Checking static_assertions v0.2.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.9 [INFO] [stderr] Compiling bincode v1.2.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking fixed-hash v0.3.2 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking crossbeam-queue v0.2.0 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking crypto-mac v0.5.2 [INFO] [stderr] Checking blake2 v0.7.1 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Checking bstr v0.2.8 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking tinytemplate v1.0.2 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stderr] Checking core_cbc_casper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `ProtoBlock` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:229:15 [INFO] [stdout] | [INFO] [stdout] 224 | incomplete_block: Block, [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | ..((**incomplete_block.arc()).clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `HashSet<&Block>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:390:14 [INFO] [stdout] | [INFO] [stdout] 381 | let protocol_state = Self::find_all_accessible_blocks(latest_messages_honest); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | &protocol_state.iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tests_common/integer.rs:32:62 [INFO] [stdout] | [INFO] [stdout] 32 | #[derive(Clone, Eq, Debug, Ord, PartialOrd, PartialEq, Hash, serde_derive::Serialize)] [INFO] [stdout] | ^---------------------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_IntegerWrapper` [INFO] [stdout] 33 | pub struct IntegerWrapper(pub u32); [INFO] [stdout] | -------------- `IntegerWrapper` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `serde_derive::Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `serde_derive::Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `serde_derive::Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tests_common/vote_count.rs:50:70 [INFO] [stdout] | [INFO] [stdout] 50 | #[derive(Clone, Copy, Eq, Ord, PartialOrd, PartialEq, Hash, Default, serde_derive::Serialize)] [INFO] [stdout] | ^---------------------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_VoteCount` [INFO] [stdout] 51 | pub struct VoteCount { [INFO] [stdout] | --------- `VoteCount` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `serde_derive::Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `serde_derive::Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `serde_derive::Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/blockchain.rs:81:45 [INFO] [stdout] | [INFO] [stdout] 81 | #[derive(Clone, Eq, PartialEq, Debug, Hash, Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_ProtoBlock` [INFO] [stdout] 82 | struct ProtoBlock { [INFO] [stdout] | ---------- `ProtoBlock` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `finish` that must be used [INFO] [stdout] --> src/util/hash.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / fixed_hash::construct_fixed_hash!( [INFO] [stdout] 22 | | pub struct Hash(64); [INFO] [stdout] 23 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the macro `fixed_hash::construct_fixed_hash` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `core_cbc_casper` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2e302d8604ef9cb82bd82485b0f51095cf683ab45787721d2a0722fb515ef1ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e302d8604ef9cb82bd82485b0f51095cf683ab45787721d2a0722fb515ef1ce", kill_on_drop: false }` [INFO] [stdout] 2e302d8604ef9cb82bd82485b0f51095cf683ab45787721d2a0722fb515ef1ce