[INFO] fetching crate convex 0.7.0... [INFO] checking convex-0.7.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate convex 0.7.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate convex 0.7.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate convex 0.7.0 [INFO] finished tweaking crates.io crate convex 0.7.0 [INFO] tweaked toml for crates.io crate convex 0.7.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate convex 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3d31f2ae40204b721a69fb83f4bc430fd603d926bef006b129e31646824af401 [INFO] running `Command { std: "docker" "start" "-a" "3d31f2ae40204b721a69fb83f4bc430fd603d926bef006b129e31646824af401", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3d31f2ae40204b721a69fb83f4bc430fd603d926bef006b129e31646824af401", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d31f2ae40204b721a69fb83f4bc430fd603d926bef006b129e31646824af401", kill_on_drop: false }` [INFO] [stdout] 3d31f2ae40204b721a69fb83f4bc430fd603d926bef006b129e31646824af401 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e7477e253057da2007fa103c8af7524602905a60748a966611af2636a7dcc326 [INFO] running `Command { std: "docker" "start" "-a" "e7477e253057da2007fa103c8af7524602905a60748a966611af2636a7dcc326", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling openssl-sys v0.9.88 [INFO] [stderr] Compiling tokio v1.28.2 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Compiling openssl v0.10.54 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling tempfile v3.6.0 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking cpufeatures v0.2.8 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling serde v1.0.164 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Compiling libm v0.2.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling serde_json v1.0.97 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Compiling async-trait v0.1.68 [INFO] [stderr] Checking bitmaps v3.2.0 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking pretty_assertions v1.3.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking imbl-sized-chunks v0.1.1 [INFO] [stderr] Checking sha1 v0.10.5 [INFO] [stderr] Checking imbl v3.0.0 [INFO] [stderr] Checking headers v0.3.8 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking proptest v1.2.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling proptest-derive v0.4.0 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling serde_derive v1.0.164 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Compiling tracing-attributes v0.1.25 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking tungstenite v0.20.1 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-tungstenite v0.20.1 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking convex_sync_types v0.7.0 [INFO] [stderr] Checking convex v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `WebSocketInternal` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/web_socket_manager.rs:200:13 [INFO] [stdout] | [INFO] [stdout] 200 | let mut internal = WebSocketInternal::new( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 210 | / select_biased! { [INFO] [stdout] 211 | | _ = self.ping_ticker.tick().fuse() => { [INFO] [stdout] 212 | | let now = Instant::now(); [INFO] [stdout] 213 | | if now - internal.last_server_response > Self::SERVER_INACTIVITY_THRESHOLD { [INFO] [stdout] ... | [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `WebSocketInternal` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/web_socket_manager.rs:200:13 [INFO] [stdout] | [INFO] [stdout] 200 | let mut internal = WebSocketInternal::new( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 210 | / select_biased! { [INFO] [stdout] 211 | | _ = self.ping_ticker.tick().fuse() => { [INFO] [stdout] 212 | | let now = Instant::now(); [INFO] [stdout] 213 | | if now - internal.last_server_response > Self::SERVER_INACTIVITY_THRESHOLD { [INFO] [stdout] ... | [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `convex` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: missing documentation for an associated function [INFO] [stdout] --> src/client/mod.rs:437:9 [INFO] [stdout] | [INFO] [stdout] 437 | pub async fn with_test_protocol() -> anyhow::Result<(Self, TestProtocolManager)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | #![warn(missing_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/base_client/mod.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | #[cfg_attr(test, derive(proptest_derive::Arbitrary))] [INFO] [stdout] | ^------------------------- [INFO] [stdout] | | [INFO] [stdout] | `Arbitrary` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_ARBITRARY_FOR_SubscriberId` [INFO] [stdout] 78 | pub struct SubscriberId(QueryId, usize); [INFO] [stdout] | ------------ `SubscriberId` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `proptest_derive::Arbitrary` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `proptest_derive::Arbitrary` may come from an old version of the `proptest_derive` crate, try updating your dependency with `cargo update -p proptest_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `proptest_derive::Arbitrary` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/base_client/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn query_id(&self) -> QueryId { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `convex` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e7477e253057da2007fa103c8af7524602905a60748a966611af2636a7dcc326", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7477e253057da2007fa103c8af7524602905a60748a966611af2636a7dcc326", kill_on_drop: false }` [INFO] [stdout] e7477e253057da2007fa103c8af7524602905a60748a966611af2636a7dcc326