[INFO] fetching crate commonware-p2p 0.0.19... [INFO] checking commonware-p2p-0.0.19 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate commonware-p2p 0.0.19 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate commonware-p2p 0.0.19 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate commonware-p2p 0.0.19 [INFO] finished tweaking crates.io crate commonware-p2p 0.0.19 [INFO] tweaked toml for crates.io crate commonware-p2p 0.0.19 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 177 packages to latest compatible versions [INFO] [stderr] Adding block-buffer v0.9.0 (available: v0.10.4) [INFO] [stderr] Adding dashmap v5.5.3 (available: v6.1.0) [INFO] [stderr] Adding digest v0.9.0 (available: v0.10.7) [INFO] [stderr] Adding fixedbitset v0.4.2 (available: v0.5.7) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding radium v0.7.0 (available: v1.1.0) [INFO] [stderr] Adding sha2 v0.9.9 (available: v0.10.8) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding wyz v0.5.1 (available: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a4ce9d0e504cad14a2ae847b7f0e95e0c61809d744a374350ea9290a9e9de1da [INFO] running `Command { std: "docker" "start" "-a" "a4ce9d0e504cad14a2ae847b7f0e95e0c61809d744a374350ea9290a9e9de1da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a4ce9d0e504cad14a2ae847b7f0e95e0c61809d744a374350ea9290a9e9de1da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4ce9d0e504cad14a2ae847b7f0e95e0c61809d744a374350ea9290a9e9de1da", kill_on_drop: false }` [INFO] [stdout] a4ce9d0e504cad14a2ae847b7f0e95e0c61809d744a374350ea9290a9e9de1da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96d2a6e12aa5ea7ab641bdb65542c2adced6ef016e48b84c99d76a4d81a03b37 [INFO] running `Command { std: "docker" "start" "-a" "96d2a6e12aa5ea7ab641bdb65542c2adced6ef016e48b84c99d76a4d81a03b37", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling bytes v1.7.2 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling fastrand v2.1.1 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling portable-atomic v1.9.0 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling multimap v0.10.0 [INFO] [stderr] Checking subtle-ng v2.5.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking spinning_top v0.3.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking nonzero_ext v0.3.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking no-std-compat v0.4.1 [INFO] [stderr] Compiling prometheus-client v0.22.3 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling cc v1.1.22 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling blst v0.3.13 [INFO] [stderr] Compiling tempfile v3.13.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling prost-derive v0.13.3 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling prometheus-client-derive-encode v0.4.2 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking curve25519-dalek-ng v4.1.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Compiling prost v0.13.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling prost-types v0.13.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Compiling prost-build v0.13.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking governor v0.6.3 [INFO] [stderr] Compiling commonware-p2p v0.0.19 (/opt/rustwide/workdir) [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking ed25519-consensus v2.1.0 [INFO] [stderr] Checking commonware-runtime v0.0.5 [INFO] [stderr] Checking commonware-cryptography v0.0.8 [INFO] [stdout] error: this value of type `EphemeralSecret` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/connection/instance.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 29 | mut runtime: impl Rng + CryptoRng + Spawner + Clock, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | mut config: Config, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | mut sink: Si, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | mut stream: St, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | peer: PublicKey, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let secret = x25519::new(&mut runtime); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | / select! { [INFO] [stdout] 47 | | _timeout = runtime.sleep_until(deadline) => { [INFO] [stdout] 48 | | return Err(Error::HandshakeTimeout) [INFO] [stdout] 49 | | }, [INFO] [stdout] ... | [INFO] [stdout] 52 | | }, [INFO] [stdout] 53 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let msg = select! { [INFO] [stdout] | ___________________- [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] 57 | | _timeout = runtime.sleep_until(deadline) => { [INFO] [stdout] 58 | | return Err(Error::HandshakeTimeout) [INFO] [stdout] 59 | | }, [INFO] [stdout] ... | [INFO] [stdout] 62 | | }, [INFO] [stdout] 63 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `EphemeralSecret` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/connection/instance.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 29 | mut runtime: impl Rng + CryptoRng + Spawner + Clock, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | mut config: Config, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | mut sink: Si, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | mut stream: St, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | peer: PublicKey, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let secret = x25519::new(&mut runtime); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | / select! { [INFO] [stdout] 47 | | _timeout = runtime.sleep_until(deadline) => { [INFO] [stdout] 48 | | return Err(Error::HandshakeTimeout) [INFO] [stdout] 49 | | }, [INFO] [stdout] ... | [INFO] [stdout] 52 | | }, [INFO] [stdout] 53 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let msg = select! { [INFO] [stdout] | ___________________- [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] 57 | | _timeout = runtime.sleep_until(deadline) => { [INFO] [stdout] 58 | | return Err(Error::HandshakeTimeout) [INFO] [stdout] 59 | | }, [INFO] [stdout] ... | [INFO] [stdout] 62 | | }, [INFO] [stdout] 63 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `EphemeralSecret` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/connection/instance.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 95 | mut runtime: impl Rng + CryptoRng + Spawner + Clock, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | mut config: Config, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | mut handshake: IncomingHandshake, [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let secret = x25519::new(&mut runtime); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | / select! { [INFO] [stdout] 113 | | _timeout = runtime.sleep_until(handshake.deadline) => { [INFO] [stdout] 114 | | return Err(Error::HandshakeTimeout) [INFO] [stdout] 115 | | }, [INFO] [stdout] ... | [INFO] [stdout] 118 | | }, [INFO] [stdout] 119 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `EphemeralSecret` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/connection/instance.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 95 | mut runtime: impl Rng + CryptoRng + Spawner + Clock, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | mut config: Config, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | mut handshake: IncomingHandshake, [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let secret = x25519::new(&mut runtime); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | / select! { [INFO] [stdout] 113 | | _timeout = runtime.sleep_until(handshake.deadline) => { [INFO] [stdout] 114 | | return Err(Error::HandshakeTimeout) [INFO] [stdout] 115 | | }, [INFO] [stdout] ... | [INFO] [stdout] 118 | | }, [INFO] [stdout] 119 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Handle>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/actors/peer/actor.rs:138:13 [INFO] [stdout] | [INFO] [stdout] 120 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | let mut send_handler: Handle> = self.runtime.spawn({ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Handle>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/actors/peer/actor.rs:138:13 [INFO] [stdout] | [INFO] [stdout] 120 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | let mut send_handler: Handle> = self.runtime.spawn({ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Handle<()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/network.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 127 | pub async fn run(self) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | // Start tracker [INFO] [stdout] 129 | let mut tracker_task = self.runtime.spawn(self.tracker.run()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Handle<()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/network.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 127 | pub async fn run(self) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | // Start tracker [INFO] [stdout] 129 | let mut tracker_task = self.runtime.spawn(self.tracker.run()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `bytes::Bytes` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/mod.rs:358:34 [INFO] [stdout] | [INFO] [stdout] 355 | let mut received = HashSet::new(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | let (sender, message) = receiver.recv().await.unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `wire::Message` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/connection/handshake.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 12 | runtime: E, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(wire::Message { [INFO] [stdout] | ________^ [INFO] [stdout] 33 | | payload: Some(wire::message::Payload::Handshake(wire::Handshake { [INFO] [stdout] 34 | | recipient_public_key, [INFO] [stdout] 35 | | ephemeral_public_key: x25519::encode_public_key(ephemeral_public_key), [INFO] [stdout] ... | [INFO] [stdout] 41 | | })), [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `commonware-p2p` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `peer::ingress::Message` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/actors/tracker/actor.rs:855:21 [INFO] [stdout] | [INFO] [stdout] 721 | let (actor, mut mailbox, mut oracle) = Actor::new(runtime.clone(), cfg); [INFO] [stdout] | ----------- ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 729 | let mut peer1_signer = Ed25519::from_seed(1); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 730 | let peer1 = peer1_signer.public_key(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 731 | let peer2 = Ed25519::from_seed(2).public_key(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 732 | let peer3 = Ed25519::from_seed(3).public_key(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 735 | let (peer_mailbox, mut peer_receiver) = peer::Mailbox::test(); [INFO] [stdout] | ------------ ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 736 | mailbox.construct(peer1.clone(), peer_mailbox.clone()).await; [INFO] [stdout] 737 | let msg = peer_receiver.next().await.unwrap(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 759 | let msg = peer_receiver.next().await.unwrap(); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 765 | let bits: BitVec = BitVec::from_vec(bit_vec.bits); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 792 | let msg = peer_receiver.next().await.unwrap(); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 798 | let bits: BitVec = BitVec::from_vec(bit_vec.bits); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 847 | let msg = peer_receiver.next().await.unwrap(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 855 | let msg = peer_receiver.next().await.unwrap(); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `authenticated::wire::Message` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/authenticated/connection/handshake.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 12 | runtime: E, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(wire::Message { [INFO] [stdout] | ________^ [INFO] [stdout] 33 | | payload: Some(wire::message::Payload::Handshake(wire::Handshake { [INFO] [stdout] 34 | | recipient_public_key, [INFO] [stdout] 35 | | ephemeral_public_key: x25519::encode_public_key(ephemeral_public_key), [INFO] [stdout] ... | [INFO] [stdout] 41 | | })), [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `commonware-p2p` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "96d2a6e12aa5ea7ab641bdb65542c2adced6ef016e48b84c99d76a4d81a03b37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96d2a6e12aa5ea7ab641bdb65542c2adced6ef016e48b84c99d76a4d81a03b37", kill_on_drop: false }` [INFO] [stdout] 96d2a6e12aa5ea7ab641bdb65542c2adced6ef016e48b84c99d76a4d81a03b37