[INFO] fetching crate coap-server 0.1.1... [INFO] checking coap-server-0.1.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate coap-server 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate coap-server 0.1.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate coap-server 0.1.1 [INFO] finished tweaking crates.io crate coap-server 0.1.1 [INFO] tweaked toml for crates.io crate coap-server 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate coap-server 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c9ade07ce4557c505e350e697f7cd3c399cddbfa2890dc14a31c81cdcb478f05 [INFO] running `Command { std: "docker" "start" "-a" "c9ade07ce4557c505e350e697f7cd3c399cddbfa2890dc14a31c81cdcb478f05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c9ade07ce4557c505e350e697f7cd3c399cddbfa2890dc14a31c81cdcb478f05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9ade07ce4557c505e350e697f7cd3c399cddbfa2890dc14a31c81cdcb478f05", kill_on_drop: false }` [INFO] [stdout] c9ade07ce4557c505e350e697f7cd3c399cddbfa2890dc14a31c81cdcb478f05 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76e5199f451c08f1fa185f49a012bd72191f4a744382273325435e11d2afa71e [INFO] running `Command { std: "docker" "start" "-a" "76e5199f451c08f1fa185f49a012bd72191f4a744382273325435e11d2afa71e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling syn v1.0.89 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Checking lru_time_cache v0.11.11 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking coap-lite v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking dyn-clone v1.0.5 [INFO] [stderr] Checking sync_wrapper v0.1.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling async-stream-impl v0.3.3 [INFO] [stderr] Checking async-stream v0.3.3 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking tokio-util v0.7.0 [INFO] [stderr] Checking coap-server v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `CoapRequest` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/resource_handler.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 69 | wrapped_request: Request, [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | ) -> Result<(), CoapError> { [INFO] [stdout] 71 | let mut initial_pair = wrapped_request.original.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 91 | / tokio::select! { [INFO] [stdout] 92 | | _ = &mut receiver.termination_rx => { [INFO] [stdout] 93 | | debug!("Observe terminated by peer: {:?}", initial_pair.source); [INFO] [stdout] 94 | | break [INFO] [stdout] ... | [INFO] [stdout] 144 | | } [INFO] [stdout] 145 | | } [INFO] [stdout] | |_________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `CoapRequest` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/resource_handler.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 69 | wrapped_request: Request, [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | ) -> Result<(), CoapError> { [INFO] [stdout] 71 | let mut initial_pair = wrapped_request.original.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 91 | / tokio::select! { [INFO] [stdout] 92 | | _ = &mut receiver.termination_rx => { [INFO] [stdout] 93 | | debug!("Observe terminated by peer: {:?}", initial_pair.source); [INFO] [stdout] 94 | | break [INFO] [stdout] ... | [INFO] [stdout] 144 | | } [INFO] [stdout] 145 | | } [INFO] [stdout] | |_________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/retransmission_manager.rs:67:35 [INFO] [stdout] | [INFO] [stdout] 66 | let key = MessageKey::new(&packet, peer.clone()); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | if let Some(ack_handle) = self.unacknowledged_messages.remove(&key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/retransmission_manager.rs:67:35 [INFO] [stdout] | [INFO] [stdout] 66 | let key = MessageKey::new(&packet, peer.clone()); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | if let Some(ack_handle) = self.unacknowledged_messages.remove(&key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `message_id` is never read [INFO] [stdout] --> src/app/retransmission_manager.rs:257:17 [INFO] [stdout] | [INFO] [stdout] 257 | let mut message_id = None; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/app/retransmission_manager.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 256 | let mut sent_packet = Packet::new(); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `T` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/u24.rs:162:19 [INFO] [stdout] | [INFO] [stdout] 161 | let result = T::try_from(one_too_many); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | if let Ok(converted) = result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `lookup_exact` is never used [INFO] [stdout] --> src/app/path_matcher.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl PathMatcher { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 78 | pub fn lookup_exact(&self, path: &[String]) -> Option<&V> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/app/retransmission_manager.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 127 | impl TransmissionParameters { [INFO] [stdout] | --------------------------- associated function in this implementation [INFO] [stdout] 128 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_message_id` is never used [INFO] [stdout] --> src/app/retransmission_manager.rs:167:12 [INFO] [stdout] | [INFO] [stdout] 166 | impl SendReliably { [INFO] [stdout] | -------------------------------------------- method in this implementation [INFO] [stdout] 167 | pub fn get_message_id(&self) -> MessageId { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/udp/udp_framed_fork.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 181 | / impl UdpFramed [INFO] [stdout] 182 | | where [INFO] [stdout] 183 | | T: Borrow, [INFO] [stdout] | |_________________________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 208 | pub fn get_ref(&self) -> &T { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 219 | pub fn get_mut(&mut self) -> &mut T { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 228 | pub fn codec(&self) -> &C { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 237 | pub fn codec_mut(&mut self) -> &mut C { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 242 | pub fn read_buffer(&self) -> &BytesMut { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 247 | pub fn read_buffer_mut(&mut self) -> &mut BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 252 | pub fn into_inner(self) -> T { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `coap-server` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `lookup_exact` is never used [INFO] [stdout] --> src/app/path_matcher.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl PathMatcher { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 78 | pub fn lookup_exact(&self, path: &[String]) -> Option<&V> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/udp/udp_framed_fork.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 181 | / impl UdpFramed [INFO] [stdout] 182 | | where [INFO] [stdout] 183 | | T: Borrow, [INFO] [stdout] | |_________________________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 208 | pub fn get_ref(&self) -> &T { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 219 | pub fn get_mut(&mut self) -> &mut T { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 228 | pub fn codec(&self) -> &C { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 237 | pub fn codec_mut(&mut self) -> &mut C { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 242 | pub fn read_buffer(&self) -> &BytesMut { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 247 | pub fn read_buffer_mut(&mut self) -> &mut BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 252 | pub fn into_inner(self) -> T { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `coap-server` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "76e5199f451c08f1fa185f49a012bd72191f4a744382273325435e11d2afa71e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76e5199f451c08f1fa185f49a012bd72191f4a744382273325435e11d2afa71e", kill_on_drop: false }` [INFO] [stdout] 76e5199f451c08f1fa185f49a012bd72191f4a744382273325435e11d2afa71e