[INFO] fetching crate cloudr 1.3.0... [INFO] checking cloudr-1.3.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate cloudr 1.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate cloudr 1.3.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cloudr 1.3.0 [INFO] finished tweaking crates.io crate cloudr 1.3.0 [INFO] tweaked toml for crates.io crate cloudr 1.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 373ff63dd103e92a3512e8874ab503d80a3bdca06189ff5d9cd5cc8e095bcfb4 [INFO] running `Command { std: "docker" "start" "-a" "373ff63dd103e92a3512e8874ab503d80a3bdca06189ff5d9cd5cc8e095bcfb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "373ff63dd103e92a3512e8874ab503d80a3bdca06189ff5d9cd5cc8e095bcfb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "373ff63dd103e92a3512e8874ab503d80a3bdca06189ff5d9cd5cc8e095bcfb4", kill_on_drop: false }` [INFO] [stdout] 373ff63dd103e92a3512e8874ab503d80a3bdca06189ff5d9cd5cc8e095bcfb4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fa71dbcbac94ec212e57f14ed38be0d26fa5cb84224de0ed8774de6db7f9ab9d [INFO] running `Command { std: "docker" "start" "-a" "fa71dbcbac94ec212e57f14ed38be0d26fa5cb84224de0ed8774de6db7f9ab9d", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking cloudr v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `suspicious_auto_trait_impls` has been removed: no longer needed, see issue #93367 for more information [INFO] [stdout] --> src/lib.rs:124:10 [INFO] [stdout] | [INFO] [stdout] 124 | #![allow(suspicious_auto_trait_impls)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/iter.rs:112:62 [INFO] [stdout] | [INFO] [stdout] 111 | impl<'a, K, V> IterMut<'a, K, V> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 112 | pub fn new(pairs: Vec<(&'a K, &'a mut &'a V)>) -> IterMut { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `suspicious_auto_trait_impls` has been removed: no longer needed, see issue #93367 for more information [INFO] [stdout] --> src/lib.rs:124:10 [INFO] [stdout] | [INFO] [stdout] 124 | #![allow(suspicious_auto_trait_impls)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/iter.rs:112:62 [INFO] [stdout] | [INFO] [stdout] 111 | impl<'a, K, V> IterMut<'a, K, V> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 112 | pub fn new(pairs: Vec<(&'a K, &'a mut &'a V)>) -> IterMut { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, HashMap>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cloud.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 205 | pub fn merge_in_place(&self, other: DataCloud<'a, K, V>) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | self.nodes.borrow_mut().extend(other.nodes.into_inner().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, HashMap>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cloud.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn merge_with(self, other: &DataCloud<'a, K, V>) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | other.nodes.borrow_mut().extend(self.nodes.into_inner().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:712:48 [INFO] [stdout] | [INFO] [stdout] 712 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:716:48 [INFO] [stdout] | [INFO] [stdout] 716 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:743:48 [INFO] [stdout] | [INFO] [stdout] 743 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:748:52 [INFO] [stdout] | [INFO] [stdout] 748 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:884:40 [INFO] [stdout] | [INFO] [stdout] 884 | new_map.insert(k.clone(), v.clone().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cloudr` (lib test) due to 3 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `RefMut<'_, HashMap>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cloud.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 205 | pub fn merge_in_place(&self, other: DataCloud<'a, K, V>) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | self.nodes.borrow_mut().extend(other.nodes.into_inner().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, HashMap>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cloud.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn merge_with(self, other: &DataCloud<'a, K, V>) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | other.nodes.borrow_mut().extend(self.nodes.into_inner().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:712:48 [INFO] [stdout] | [INFO] [stdout] 712 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:716:48 [INFO] [stdout] | [INFO] [stdout] 716 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:743:48 [INFO] [stdout] | [INFO] [stdout] 743 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:748:52 [INFO] [stdout] | [INFO] [stdout] 748 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:884:40 [INFO] [stdout] | [INFO] [stdout] 884 | new_map.insert(k.clone(), v.clone().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cloudr` (lib) due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fa71dbcbac94ec212e57f14ed38be0d26fa5cb84224de0ed8774de6db7f9ab9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa71dbcbac94ec212e57f14ed38be0d26fa5cb84224de0ed8774de6db7f9ab9d", kill_on_drop: false }` [INFO] [stdout] fa71dbcbac94ec212e57f14ed38be0d26fa5cb84224de0ed8774de6db7f9ab9d