[INFO] fetching crate cliclack 0.3.5... [INFO] checking cliclack-0.3.5 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate cliclack 0.3.5 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate cliclack 0.3.5 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cliclack 0.3.5 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate cliclack 0.3.5 [INFO] tweaked toml for crates.io crate cliclack 0.3.5 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate cliclack 0.3.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b696fa7fb8730c44e97adacbfddb154f77b72f9bd1297d2609dfe062b8cef12c [INFO] running `Command { std: "docker" "start" "-a" "b696fa7fb8730c44e97adacbfddb154f77b72f9bd1297d2609dfe062b8cef12c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b696fa7fb8730c44e97adacbfddb154f77b72f9bd1297d2609dfe062b8cef12c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b696fa7fb8730c44e97adacbfddb154f77b72f9bd1297d2609dfe062b8cef12c", kill_on_drop: false }` [INFO] [stdout] b696fa7fb8730c44e97adacbfddb154f77b72f9bd1297d2609dfe062b8cef12c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 68b857e81170537a03c082d39ddf7a0e901c90c15fd6ee4768e86bdb3ce0ea71 [INFO] running `Command { std: "docker" "start" "-a" "68b857e81170537a03c082d39ddf7a0e901c90c15fd6ee4768e86bdb3ce0ea71", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ctrlc v3.4.4 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking cliclack v0.3.5 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Input` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:74:15 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new(prompt: impl Display) -> Self { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Input` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:74:15 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new(prompt: impl Display) -> Self { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/password.rs:33:19 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(prompt: impl Display) -> Self { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | mask: THEME.lock().unwrap().password_mask(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/password.rs:33:19 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(prompt: impl Display) -> Self { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | mask: THEME.lock().unwrap().password_mask(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Term` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:289:5 [INFO] [stdout] | [INFO] [stdout] 288 | fn term_write(line: impl Display) -> io::Result<()> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | Term::stderr().write_str(line.to_string().as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:300:16 [INFO] [stdout] | [INFO] [stdout] 299 | pub fn intro(title: impl Display) -> io::Result<()> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | term_write(THEME.lock().unwrap().format_intro(&title.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:305:16 [INFO] [stdout] | [INFO] [stdout] 304 | pub fn outro(message: impl Display) -> io::Result<()> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | term_write(THEME.lock().unwrap().format_outro(&message.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn outro_cancel(message: impl Display) -> io::Result<()> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | term_write( [INFO] [stdout] 311 | / THEME [INFO] [stdout] 312 | | .lock() [INFO] [stdout] 313 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 319 | pub fn outro_note(prompt: impl Display, message: impl Display) -> io::Result<()> { [INFO] [stdout] | ------ ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | term_write( [INFO] [stdout] 321 | / THEME [INFO] [stdout] 322 | | .lock() [INFO] [stdout] 323 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 385 | pub fn note(prompt: impl Display, message: impl Display) -> io::Result<()> { [INFO] [stdout] | ------ ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 386 | term_write( [INFO] [stdout] 387 | / THEME [INFO] [stdout] 388 | | .lock() [INFO] [stdout] 389 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:400:13 [INFO] [stdout] | [INFO] [stdout] 398 | fn log(text: impl Display, symbol: impl Display) -> io::Result<()> { [INFO] [stdout] | ---- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 399 | term_write( [INFO] [stdout] 400 | / THEME [INFO] [stdout] 401 | | .lock() [INFO] [stdout] 402 | | .unwrap() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Term` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:289:5 [INFO] [stdout] | [INFO] [stdout] 288 | fn term_write(line: impl Display) -> io::Result<()> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | Term::stderr().write_str(line.to_string().as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:300:16 [INFO] [stdout] | [INFO] [stdout] 299 | pub fn intro(title: impl Display) -> io::Result<()> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | term_write(THEME.lock().unwrap().format_intro(&title.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:305:16 [INFO] [stdout] | [INFO] [stdout] 304 | pub fn outro(message: impl Display) -> io::Result<()> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | term_write(THEME.lock().unwrap().format_outro(&message.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn outro_cancel(message: impl Display) -> io::Result<()> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | term_write( [INFO] [stdout] 311 | / THEME [INFO] [stdout] 312 | | .lock() [INFO] [stdout] 313 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 319 | pub fn outro_note(prompt: impl Display, message: impl Display) -> io::Result<()> { [INFO] [stdout] | ------ ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | term_write( [INFO] [stdout] 321 | / THEME [INFO] [stdout] 322 | | .lock() [INFO] [stdout] 323 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 385 | pub fn note(prompt: impl Display, message: impl Display) -> io::Result<()> { [INFO] [stdout] | ------ ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 386 | term_write( [INFO] [stdout] 387 | / THEME [INFO] [stdout] 388 | | .lock() [INFO] [stdout] 389 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:400:13 [INFO] [stdout] | [INFO] [stdout] 398 | fn log(text: impl Display, symbol: impl Display) -> io::Result<()> { [INFO] [stdout] | ---- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 399 | term_write( [INFO] [stdout] 400 | / THEME [INFO] [stdout] 401 | | .lock() [INFO] [stdout] 402 | | .unwrap() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cliclack` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cliclack` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "68b857e81170537a03c082d39ddf7a0e901c90c15fd6ee4768e86bdb3ce0ea71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68b857e81170537a03c082d39ddf7a0e901c90c15fd6ee4768e86bdb3ce0ea71", kill_on_drop: false }` [INFO] [stdout] 68b857e81170537a03c082d39ddf7a0e901c90c15fd6ee4768e86bdb3ce0ea71