[INFO] fetching crate circulate 0.5.0... [INFO] checking circulate-0.5.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate circulate 0.5.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate circulate 0.5.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate circulate 0.5.0 [INFO] finished tweaking crates.io crate circulate 0.5.0 [INFO] tweaked toml for crates.io crate circulate 0.5.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate circulate 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e61991440a6fcdf5e76c611d7582c14e7876cad5f3766319b5f351b42c300cf4 [INFO] running `Command { std: "docker" "start" "-a" "e61991440a6fcdf5e76c611d7582c14e7876cad5f3766319b5f351b42c300cf4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e61991440a6fcdf5e76c611d7582c14e7876cad5f3766319b5f351b42c300cf4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e61991440a6fcdf5e76c611d7582c14e7876cad5f3766319b5f351b42c300cf4", kill_on_drop: false }` [INFO] [stdout] e61991440a6fcdf5e76c611d7582c14e7876cad5f3766319b5f351b42c300cf4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec854b652189f1a3d18e6d2b14d92bdd7bf7df652016a1fc278b2bb488d273c6 [INFO] running `Command { std: "docker" "start" "-a" "ec854b652189f1a3d18e6d2b14d92bdd7bf7df652016a1fc278b2bb488d273c6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.34 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.83 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking half v2.2.1 [INFO] [stderr] Compiling anyhow v1.0.55 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking pot v3.0.0 [INFO] [stderr] Checking arc-bytes v0.3.3 [INFO] [stderr] Checking circulate v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:287:35 [INFO] [stdout] | [INFO] [stdout] 284 | let mut subscribers = self.data.subscribers.write(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let mut topics = self.data.topics.write(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | let mut subscriptions = self.data.subscriptions.write(); [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | if let Some(subscriber) = subscribers.remove(&subscriber_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:287:35 [INFO] [stdout] | [INFO] [stdout] 284 | let mut subscribers = self.data.subscribers.write(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let mut topics = self.data.topics.write(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | let mut subscriptions = self.data.subscriptions.write(); [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | if let Some(subscriber) = subscribers.remove(&subscriber_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `circulate` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `circulate` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "ec854b652189f1a3d18e6d2b14d92bdd7bf7df652016a1fc278b2bb488d273c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec854b652189f1a3d18e6d2b14d92bdd7bf7df652016a1fc278b2bb488d273c6", kill_on_drop: false }` [INFO] [stdout] ec854b652189f1a3d18e6d2b14d92bdd7bf7df652016a1fc278b2bb488d273c6