[INFO] fetching crate chess-core 0.1.0... [INFO] checking chess-core-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate chess-core 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate chess-core 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate chess-core 0.1.0 [INFO] finished tweaking crates.io crate chess-core 0.1.0 [INFO] tweaked toml for crates.io crate chess-core 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 32 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] caabde037f835a4e60a23617c51dff62df97bc96971b8a424f371e1080cbbd71 [INFO] running `Command { std: "docker" "start" "-a" "caabde037f835a4e60a23617c51dff62df97bc96971b8a424f371e1080cbbd71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "caabde037f835a4e60a23617c51dff62df97bc96971b8a424f371e1080cbbd71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "caabde037f835a4e60a23617c51dff62df97bc96971b8a424f371e1080cbbd71", kill_on_drop: false }` [INFO] [stdout] caabde037f835a4e60a23617c51dff62df97bc96971b8a424f371e1080cbbd71 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34261bc8d299af08c938538e710e4ae27d81691f56265f0594c07d8c3817effa [INFO] running `Command { std: "docker" "start" "-a" "34261bc8d299af08c938538e710e4ae27d81691f56265f0594c07d8c3817effa", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Compiling chess-derive v0.1.0 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking chess-core v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `TileId` [INFO] [stdout] --> src/game/mod.rs:3:37 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::msg::{PieceId, PlayerId, TileId}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::math::XyPair` [INFO] [stdout] --> src/game/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use self::math::XyPair; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::types::Piece` [INFO] [stdout] --> src/layout.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::types::Piece; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/layout.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Rc` and `Weak` [INFO] [stdout] --> src/layout.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | use std::rc::{Rc, Weak}; [INFO] [stdout] | ^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `xy_to_index` [INFO] [stdout] --> src/types.rs:2:38 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::game::math::{index_to_xy, xy_to_index}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/lib.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 13 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Direction` [INFO] [stdout] --> src/lib.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | use types::{Direction, RawBoard}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::math::XyPair` [INFO] [stdout] --> src/game/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use self::math::XyPair; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::types::Piece` [INFO] [stdout] --> src/layout.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::types::Piece; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/layout.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Rc` and `Weak` [INFO] [stdout] --> src/layout.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | use std::rc::{Rc, Weak}; [INFO] [stdout] | ^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `xy_to_index` [INFO] [stdout] --> src/types.rs:2:38 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::game::math::{index_to_xy, xy_to_index}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/lib.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 13 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Direction` [INFO] [stdout] --> src/lib.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | use types::{Direction, RawBoard}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/types.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `board` [INFO] [stdout] --> src/game/mod.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | board: &types::RawBoard, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_board` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pid` [INFO] [stdout] --> src/lib.rs:172:37 [INFO] [stdout] | [INFO] [stdout] 172 | Action::SetActivePlayer(pid) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pid` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `move` [INFO] [stdout] --> src/lib.rs:186:26 [INFO] [stdout] | [INFO] [stdout] 186 | Action::Move(r#move) => { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_move` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 247 | for mut white_piece in w.into_iter() { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:253:13 [INFO] [stdout] | [INFO] [stdout] 253 | for mut black_piece in b.into_iter() { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `CliMsg` is never used [INFO] [stdout] --> src/msg.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | pub(crate) enum CliMsg { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Response` is never used [INFO] [stdout] --> src/msg.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | pub(crate) enum Response { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/types.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `board` [INFO] [stdout] --> src/game/mod.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | board: &types::RawBoard, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_board` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p1` [INFO] [stdout] --> src/game/mod.rs:258:17 [INFO] [stdout] | [INFO] [stdout] 258 | let mut p1 = PlayerData::new_white_player(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_p1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p2` [INFO] [stdout] --> src/game/mod.rs:259:17 [INFO] [stdout] | [INFO] [stdout] 259 | let mut p2 = PlayerData::new_black_player(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_p2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/game/mod.rs:258:13 [INFO] [stdout] | [INFO] [stdout] 258 | let mut p1 = PlayerData::new_white_player(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/game/mod.rs:259:13 [INFO] [stdout] | [INFO] [stdout] 259 | let mut p2 = PlayerData::new_black_player(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pid` [INFO] [stdout] --> src/lib.rs:172:37 [INFO] [stdout] | [INFO] [stdout] 172 | Action::SetActivePlayer(pid) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pid` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `move` [INFO] [stdout] --> src/lib.rs:186:26 [INFO] [stdout] | [INFO] [stdout] 186 | Action::Move(r#move) => { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_move` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 247 | for mut white_piece in w.into_iter() { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:253:13 [INFO] [stdout] | [INFO] [stdout] 253 | for mut black_piece in b.into_iter() { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:329:13 [INFO] [stdout] | [INFO] [stdout] 324 | let mut gm = spawn_game_master(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | let vision_options: Result = gm.request_vision(game_id, piece_id); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `CliMsg` is never used [INFO] [stdout] --> src/msg.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | pub(crate) enum CliMsg { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Response` is never used [INFO] [stdout] --> src/msg.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | pub(crate) enum Response { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/game/mod.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 308 | bt.update_piece(beyonce_shared, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 308 | let _ = bt.update_piece(beyonce_shared, true); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chess-core` (lib test) due to 2 previous errors; 20 warnings emitted [INFO] running `Command { std: "docker" "inspect" "34261bc8d299af08c938538e710e4ae27d81691f56265f0594c07d8c3817effa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34261bc8d299af08c938538e710e4ae27d81691f56265f0594c07d8c3817effa", kill_on_drop: false }` [INFO] [stdout] 34261bc8d299af08c938538e710e4ae27d81691f56265f0594c07d8c3817effa