[INFO] fetching crate certified-vars 0.1.4... [INFO] checking certified-vars-0.1.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate certified-vars 0.1.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate certified-vars 0.1.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate certified-vars 0.1.4 [INFO] finished tweaking crates.io crate certified-vars 0.1.4 [INFO] tweaked toml for crates.io crate certified-vars 0.1.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 122 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (available: v0.7.6) [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding block-buffer v0.9.0 (available: v0.10.4) [INFO] [stderr] Adding candid v0.7.18 (available: v0.10.10) [INFO] [stderr] Adding candid_derive v0.4.5 (available: v0.6.6) [INFO] [stderr] Adding digest v0.9.0 (available: v0.10.7) [INFO] [stderr] Adding fixedbitset v0.4.2 (available: v0.5.7) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding ic-cdk v0.5.7 (available: v0.16.0) [INFO] [stderr] Adding ic-types v0.5.0 (available: v0.7.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding lalrpop v0.19.12 (available: v0.21.0) [INFO] [stderr] Adding lalrpop-util v0.19.12 (available: v0.21.0) [INFO] [stderr] Adding logos v0.12.1 (available: v0.14.2) [INFO] [stderr] Adding logos-derive v0.12.1 (available: v0.14.2) [INFO] [stderr] Adding num_enum v0.5.11 (available: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.5.11 (available: v0.7.3) [INFO] [stderr] Adding phf_shared v0.10.0 (available: v0.11.2) [INFO] [stderr] Adding pretty v0.10.0 (available: v0.12.3) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (available: v3.2.0) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding sha2 v0.9.9 (available: v0.10.8) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding term v0.7.0 (available: v1.0.0) [INFO] [stderr] Adding toml_edit v0.19.15 (available: v0.22.22) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (available: v0.6.20) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cbe232ebba3b6a28877b8e4c631d9fbd2387dd779dc4b5a97beadd5fc7d13b27 [INFO] running `Command { std: "docker" "start" "-a" "cbe232ebba3b6a28877b8e4c631d9fbd2387dd779dc4b5a97beadd5fc7d13b27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cbe232ebba3b6a28877b8e4c631d9fbd2387dd779dc4b5a97beadd5fc7d13b27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbe232ebba3b6a28877b8e4c631d9fbd2387dd779dc4b5a97beadd5fc7d13b27", kill_on_drop: false }` [INFO] [stdout] cbe232ebba3b6a28877b8e4c631d9fbd2387dd779dc4b5a97beadd5fc7d13b27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e55735ca012fdc539b94090d00aef56307f1945f16103e19f06d330b57b5d8b [INFO] running `Command { std: "docker" "start" "-a" "0e55735ca012fdc539b94090d00aef56307f1945f16103e19f06d330b57b5d8b", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling is-terminal v0.4.13 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking pretty v0.10.0 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking lalrpop-util v0.19.12 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Compiling logos-derive v0.12.1 [INFO] [stderr] Compiling candid_derive v0.4.5 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Checking logos v0.12.1 [INFO] [stderr] Checking binread v2.2.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking ic-types v0.5.0 [INFO] [stderr] Compiling candid v0.7.18 [INFO] [stderr] Checking ic-cdk v0.5.7 [INFO] [stderr] Checking certified-vars v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/map.rs:178:30 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn append_deep(&mut self, key: K, value: V) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | let mut value = Some(value); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | if let Some(value) = value.take() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option, &mut V)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbtree/entry.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn insert(self, value: V) -> &'a mut V { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | self.map.insert(self.key, value).1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(K, V)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbtree/entry.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn remove(self) -> V { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | self.map.delete(&self.key).unwrap().1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 354 | mut h: *mut Node, [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:405:13 [INFO] [stdout] | [INFO] [stdout] 405 | mut h: *mut Node, [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:927:17 [INFO] [stdout] | [INFO] [stdout] 927 | let mut result = go(self.root, key, value); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:886:13 [INFO] [stdout] | [INFO] [stdout] 886 | mut h: *mut Node, [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:1121:9 [INFO] [stdout] | [INFO] [stdout] 1121 | let mut x = (*h).left; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:1139:9 [INFO] [stdout] | [INFO] [stdout] 1139 | let mut x = (*h).right; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DebugView` is never constructed [INFO] [stdout] --> src/rbtree.rs:1195:8 [INFO] [stdout] | [INFO] [stdout] 1195 | struct DebugView(*const Node); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/map.rs:178:30 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn append_deep(&mut self, key: K, value: V) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | let mut value = Some(value); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | if let Some(value) = value.take() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `certified-vars` (lib) due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `(std::option::Option, &mut V)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbtree/entry.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn insert(self, value: V) -> &'a mut V { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | self.map.insert(self.key, value).1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(K, V)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbtree/entry.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn remove(self) -> V { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | self.map.delete(&self.key).unwrap().1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 354 | mut h: *mut Node, [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:405:13 [INFO] [stdout] | [INFO] [stdout] 405 | mut h: *mut Node, [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:927:17 [INFO] [stdout] | [INFO] [stdout] 927 | let mut result = go(self.root, key, value); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:886:13 [INFO] [stdout] | [INFO] [stdout] 886 | mut h: *mut Node, [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:1121:9 [INFO] [stdout] | [INFO] [stdout] 1121 | let mut x = (*h).left; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rbtree.rs:1139:9 [INFO] [stdout] | [INFO] [stdout] 1139 | let mut x = (*h).right; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `certified-vars` (lib test) due to 4 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0e55735ca012fdc539b94090d00aef56307f1945f16103e19f06d330b57b5d8b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e55735ca012fdc539b94090d00aef56307f1945f16103e19f06d330b57b5d8b", kill_on_drop: false }` [INFO] [stdout] 0e55735ca012fdc539b94090d00aef56307f1945f16103e19f06d330b57b5d8b