[INFO] fetching crate cashmere 0.0.1... [INFO] checking cashmere-0.0.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate cashmere 0.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cashmere 0.0.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cashmere 0.0.1 [INFO] finished tweaking crates.io crate cashmere 0.0.1 [INFO] tweaked toml for crates.io crate cashmere 0.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8ac097608ccc8dba4f625b0293490f26a4075def70d36486c2405e9dc1fb872b [INFO] running `Command { std: "docker" "start" "-a" "8ac097608ccc8dba4f625b0293490f26a4075def70d36486c2405e9dc1fb872b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ac097608ccc8dba4f625b0293490f26a4075def70d36486c2405e9dc1fb872b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ac097608ccc8dba4f625b0293490f26a4075def70d36486c2405e9dc1fb872b", kill_on_drop: false }` [INFO] [stdout] 8ac097608ccc8dba4f625b0293490f26a4075def70d36486c2405e9dc1fb872b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5770b754cc18e2b96827c22d26220193264612bb6441751cf4ea825568091147 [INFO] running `Command { std: "docker" "start" "-a" "5770b754cc18e2b96827c22d26220193264612bb6441751cf4ea825568091147", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking order-stat v0.1.3 [INFO] [stderr] Checking cashmere v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `ScapegoatChangeOutcome<::Ownership>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:584:15 [INFO] [stdout] | [INFO] [stdout] 561 | let [mut dest, sibling] = if go_left { [INFO] [stdout] | -------- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 568 | let Some(mut node) = dest.get() else { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 584 | match node.insert(balance, next_dim, gas - 1, ins, resolve_equal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ScapegoatChangeOutcome<::Ownership>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:584:15 [INFO] [stdout] | [INFO] [stdout] 561 | let [mut dest, sibling] = if go_left { [INFO] [stdout] | -------- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 568 | let Some(mut node) = dest.get() else { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 584 | match node.insert(balance, next_dim, gas - 1, ins, resolve_equal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ScapegoatChangeOutcome<::Ownership>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:643:15 [INFO] [stdout] | [INFO] [stdout] 633 | let [mut rebuilding_child, sibling] = if subtree_height(self.left()) == self_height { [INFO] [stdout] | -------------------- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 642 | let mut node = unsafe { rebuilding_child.get_unchecked() }; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 643 | match node.rebuild_deepest_leaf(balance, next_dim) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ScapegoatChangeOutcome<::Ownership>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:643:15 [INFO] [stdout] | [INFO] [stdout] 633 | let [mut rebuilding_child, sibling] = if subtree_height(self.left()) == self_height { [INFO] [stdout] | -------------------- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 642 | let mut node = unsafe { rebuilding_child.get_unchecked() }; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 643 | match node.rebuild_deepest_leaf(balance, next_dim) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option::Ownership>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:758:15 [INFO] [stdout] | [INFO] [stdout] 752 | let mut descend_into = if go_left { [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 757 | let Some(mut child) = descend_into.get() else { return None }; [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 758 | match child.remove_value(val, Self::Value::next_dim(dim)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option::Ownership>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:758:15 [INFO] [stdout] | [INFO] [stdout] 752 | let mut descend_into = if go_left { [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 757 | let Some(mut child) = descend_into.get() else { return None }; [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 758 | match child.remove_value(val, Self::Value::next_dim(dim)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::hash_map::Entry<'_, K, *mut Node>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:282:15 [INFO] [stdout] | [INFO] [stdout] 280 | pub fn try_insert(&mut self, key: K, value: V) -> Result<(), &V> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let current_size = self.len(); [INFO] [stdout] 282 | match self.items.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::hash_map::Entry<'_, K, *mut Node>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:282:15 [INFO] [stdout] | [INFO] [stdout] 280 | pub fn try_insert(&mut self, key: K, value: V) -> Result<(), &V> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let current_size = self.len(); [INFO] [stdout] 282 | match self.items.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `validate` is never used [INFO] [stdout] --> src/node.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 74 | pub trait Tree: IntoIterator::Ownership> { [INFO] [stdout] | ---- method in this trait [INFO] [stdout] ... [INFO] [stdout] 80 | fn validate(&self); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/node.rs:957:12 [INFO] [stdout] | [INFO] [stdout] 953 | / impl<'a, Node> ViewingBinaryTreeIter<'a, Node> [INFO] [stdout] 954 | | where [INFO] [stdout] 955 | | Node: BinaryNode + Ownable, [INFO] [stdout] | |_______________________________- associated function in this implementation [INFO] [stdout] 956 | { [INFO] [stdout] 957 | pub fn new<'b: 'a, T>(tree: &'b T) -> Self [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `validate` is never used [INFO] [stdout] --> src/node.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 74 | pub trait Tree: IntoIterator::Ownership> { [INFO] [stdout] | ---- method in this trait [INFO] [stdout] ... [INFO] [stdout] 80 | fn validate(&self); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/node.rs:957:12 [INFO] [stdout] | [INFO] [stdout] 953 | / impl<'a, Node> ViewingBinaryTreeIter<'a, Node> [INFO] [stdout] 954 | | where [INFO] [stdout] 955 | | Node: BinaryNode + Ownable, [INFO] [stdout] | |_______________________________- associated function in this implementation [INFO] [stdout] 956 | { [INFO] [stdout] 957 | pub fn new<'b: 'a, T>(tree: &'b T) -> Self [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cashmere` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cashmere` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5770b754cc18e2b96827c22d26220193264612bb6441751cf4ea825568091147", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5770b754cc18e2b96827c22d26220193264612bb6441751cf4ea825568091147", kill_on_drop: false }` [INFO] [stdout] 5770b754cc18e2b96827c22d26220193264612bb6441751cf4ea825568091147